Kodi Community Forum
DialogFavourites crashing onclick - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+--- Thread: DialogFavourites crashing onclick (/showthread.php?tid=352715)



DialogFavourites crashing onclick - jurialmunkey - 2020-03-21

I'm having an issue with my new skin Arctic Horizon where DialogFavourites is crashing once you click on an item

I tried stripping the dialog down to a very basic list and I'm still getting the crash, so it doesn't appear to be a problem with the dialog itself.

Other things I tried:
Remove all other dialogs in the skin.
Remove all animations.
Remove all custom windows.
Remove all home menu code (just using a keyboard shortcut to launch favourites).

I still get the crash no matter what I try. It doesn't happen in any other skin.
Does anyone have any suggestions? I'm completely stumped on what the cause might be and there's nothing in the log to give any hints.

Arctic Horizon Github:
https://github.com/jurialmunkey/skin.arctic.horizon


RE: DialogFavourites crashing onclick - ronie - 2020-03-21

might be a kodi bug...

if you add a windowclose animation to the dialog, it won't crash anymore
xml:
<animation effect="fade" start="100" end="0" time="100">WindowClose</animation>



RE: DialogFavourites crashing onclick - ronie - 2020-03-21

https://github.com/xbmc/xbmc/pull/17528


RE: DialogFavourites crashing onclick - jurialmunkey - 2020-03-21

Can confirm that it works. Big big thanks! I was really tearing my hair out over that one.

I would never have thought to try *adding* a WindowClose animation. Usually it's the other way around (e.g. having a WindowClose animation in DialogButtonMenu used to cause issues).