Kodi Community Forum
Release Disney+ - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Video Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=154)
+---- Thread: Release Disney+ (/showthread.php?tid=353316)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77

RE: Disney+ - matthuisman - 2021-08-26

@badsheep
You need to compare with their website or app. They may not have french subs for that movie etc..
And if you've restricted audio to only English, 2 audio streams seems right

RE: Disney+ - badsheep - 2021-08-26

Quote:You need to compare with their website or app. They may not have french subs for that movie etc..
I did, there are French subtitles for that movie on the website.
Quote:And if you've restricted audio to only English, 2 audio streams seems right
Yes absolutely, that was the goal : limit the streams to 2, to be sure it doesn't exceed any number, so that the subtitle could appear...
but it's not the case.
When I said "Strange", it was related to the lack of subtitle, not to the fact that there was 2 audio streams... sorry my English is not very good I wasn't clear.

RE: Disney+ - matthuisman - 2021-08-27

@badsheep
i just tested with newest 101 dalmatians (1996) on kodi 18
or were you meaning Cruella (2021)?

i have put audio allow list to en & subtitle allow list to fr
(maybe your trying to put in french instead of fr ?)
and I got two french subtitle streams

also, picking a quality or having the quality preset to anything except Bypass, will also reduce the stream count too
as it removes all the other quality streams

RE: Disney+ - badsheep - 2021-08-27

I'm sorry @matthuisman and so ashamed : it works I have the subtitles...

The reasons is that I deinstalled everything, reinstalled everything to try to understand, and I went too fast to check the parameters... and I chose No in front of "Non-forced Subs"  Tongue

So sorry for waisting your time !

RE: Disney+ - badsheep - 2021-08-27

Still I always have my bug of before, the one described here...

Thank you very much for your job and for your help !

RE: Disney+ - matthuisman - 2021-08-27

I saw that. I suspect That'll be a bug in inputstream adaptive. Seeking across chapters causing crashes
I don't have Mac to test with either.
Can you get the issue happening on any other devices?

RE: Disney+ - badsheep - 2021-08-27

I can test on a Windows 10 pc...
I'll see that tomorrow and will let you know.

RE: Disney+ - badsheep - 2021-08-27

Hello,

I did some tests on the Windows 10 PC, with a fresh new 19.1 : I could't reproduce the bug.

So as you say it may be a bug with Mac OS.

RE: Disney+ - badsheep - 2021-08-27

I did some tests to check if it was related to the input stream adaptive version... it doesn't seem to be related.

Mac OS, Kodi v18.x, inputstream v.2.4.8 (last version available) > CRASH
Mac OS, Kodi v19.1, inputstream v.2.6.23 (last version available) > CRASH
Windows 10, Kodi v19.1, inputstream v.2.6.23 (last version available) > NO CRASH

RE: Disney+ - ThomB - 2021-08-29

Hello,

I would like to report a bug but first of all since it's my first post in this thread, a big thank you to you Matt for this amazing add-on Smile

When I play movies containing chapters, Kodi crashes when the playback reaches the chapter or when I select a chapter in the OSD.
I think it may be the same bug as the one reported by @badsheep above but I'm not 100% sure.
I am able to reproduce the bug every time with the following steps:
  1. Play "Iron Man 2" movie (but I think the bug would occur for any movie containing chapters so any Marvel movies)
  2. Open the "Bookmark" menu from the OSD button and select one of the chapters
    OR
    Play any second after 1h57min04sec
The second use case (when the chapter is not selected) is the most annoying but both of them prevents you from watching the whole movie (including the post-credits scenes ^^).

I initially discovered this on a Rapsberry Pi 3 with OSMC 2021.08-1 / Kodi 19.1 / Disney+ 0.9.3 => error log is here

I was also able to reproduce the bug on another machine with Mac OS 10.11.6 / Kodi 18.9 / Disney+ 0.9.3. The error is slightly different though:
  • Surprisingly there are no chapters displayed in the OSD menu
  • The first time the playback reaches 1h57min04sec, the movie is just stopped, I am sent back to the previous Kodi window but Kodi is still working. If I try again to play the movie and to jump to a time after 1h57min04sec, Kodi crashes.

The error log is here.
The first error (when the movie is stopped but Kodi still alive) is: Control 55 in window 10025 has been asked to focus, but it can't
The second error (which makes Kodi crashes) is the same as on OSMC: ERROR: Got MSGQ_ABORT or MSGO_IS_ERROR return true

Do you think it's a bug with InputSteam Adaptive and that I should report it in their repo (I didn't find any on-going issues related to chapters in their database)?
Is there a way (even a dirty one) to disable the creation of chapters in the Disney+ add-on?

Thanks in advance for your help!

RE: Disney+ - matthuisman - 2021-08-30

@ThomB
you need to disable "Skip end credits" in the add-on settings.
that code will kick in at 1h57min04 to then ffwd to the end of the movie
that should allow you to watch credits / any after credits scenes

But that actually made me aware of something I need to update.
Currently I am assuming there is nothing after credits, but sometimes there is.
skip credits should ffwd only to the end of the credits - not the end of the stream.
Their website does this, so i'll look into fixing.

But yes, your issue sounds same as other user.
It's an issue where I think Inputstream Adapative is crashing on Linux / mac when its seeking across chapters.
You'll notice if you disable skip credits, you should be able to let it play through without issue.

We are looking into the crashing when seeking across chapters issue Smile

RE: Disney+ - ThomB - 2021-08-30

Thanks for the fast answer!

Disabling « Skip credits » works as you said Smile
Moreover I confirm that version 0.9.4 correctly skip the credits but not the post-credits scenes anymore: you were super fast at fixing this!

Good to know that the bug with chapters in InputStream is being analyzed. Could you please post back here when it is fixed?

Unrelated question: are you interested in having the add-on translated to other languages than the ones already available? If yes, how should I upload the language file? I didn’t find any repository with the code of the add-on where I could submit it.

RE: Disney+ - matthuisman - 2021-08-30

You can follow progress on the IA bug here: https://github.com/xbmc/inputstream.adaptive/issues/783

Yes, translations are great

You can PR against https://github.com/matthuisman/slyguy.addons/tree/master/slyguy.disney.plus

Also, a lot of common strings come from the common addon
https://github.com/matthuisman/slyguy.addons/tree/master/script.module.slyguy

Thank you!

RE: Disney+ - badsheep - 2021-08-30

If it can be useful, I had the same problems with the Netflix add-on...

RE: Disney+ - matthuisman - 2021-08-31

@ThomB @badsheep

are you able to please try this Inpustream Adaptive build on Kodi 19 on Mac
https://jenkins.kodi.tv/job/xbmc/job/inputstream.adaptive/job/PR-784/1/artifact/cmake/addons/build/zips/inputstream.adaptive+osx-x86_64/inputstream.adaptive-2.6.23.zip

see if it fixes / improves seeking across chapters.
thanks