Kodi Community Forum
Bug TMDb scraper bug on region code passing - Printable Version

Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Scrapers (https://forum.kodi.tv/forumdisplay.php?fid=60)
--- Thread: Bug TMDb scraper bug on region code passing (/showthread.php?tid=359488)



TMDb scraper bug on region code passing - pbodq - 2020-12-31

Region codes passing to requires capital letters. Small letters results in empty GetSearchResults from CurlFile sessions.

..\Kodi\addons\metadata.themoviedb.org\resources\settings.xml
Please update the three Chinese region codes (zh) to



<?xml version="1.0" encoding="utf-8"?>
<settings>
<setting label="30002" type="select" values="ar-AE|ar-SA|..................|zh-CN|zh-TW|zh-HK" id="language" default="en"/>
</settings>

https://forum.kodi.tv/showthread.php?tid=332665&pid=2750602#pid2750602
Three years ago, i already pointed out that issue but no replies from private messages. Since my account privileges is too low and i could not directly contact the author.
By github commitment, no response neither from 2-years old repo.

Or anybody could advise an efficient way for me to update the repository?


RE: TMDb scraper bug on region code passing - Karellen - 2020-12-31

@pbodq

Please update to the Python version of the scraper where this is already implemented...
https://kodi.wiki/view/Add-on:The_Movie_Database_Python
https://kodi.wiki/view/Add-on:TMDb_TV_Shows


RE: TMDb scraper bug on region code passing - pbodq - 2020-12-31

(2020-12-31, 07:25)Karellen Wrote: @pbodq

Please update to the Python version of the scraper where this is already implemented...
https://kodi.wiki/view/Add-on:The_Movie_Database_Python
https://kodi.wiki/view/Add-on:TMDb_TV_Shows

thanks. I will try this work flow and contact you if i find difficulties


RE: TMDb scraper bug on region code passing - pbodq - 2020-12-31

(2020-12-31, 07:25)Karellen Wrote: @pbodq

Please update to the Python version of the scraper where this is already implemented...
https://kodi.wiki/view/Add-on:The_Movie_Database_Python
https://kodi.wiki/view/Add-on:TMDb_TV_Shows

I saw the python v1.3.1 already included my suggestion.
how about the old v5.2.5 ? Will the team add this update?


RE: TMDb scraper bug on region code passing - Karellen - 2020-12-31

(2020-12-31, 08:13)pbodq Wrote: how about the old v5.2.5 ? Will the team add this update?
It is up to @olympia, but I do not think so otherwise it would already have been done.

Anyway you seem very knowledgeable, you can easily make the change yourself as you have already found the location to be edited.


RE: TMDb scraper bug on region code passing - pbodq - 2020-12-31

(2020-12-31, 08:19)Karellen Wrote:
(2020-12-31, 08:13)pbodq Wrote: how about the old v5.2.5 ? Will the team add this update?
It is up to @olympia, but I do not think so otherwise it would already have been done.

Anyway you seem very knowledgeable, you can easily make the change yourself as you have already found the location to be edited.

yes, i have already fixed that file in my computer.

However, there are many Chinese users downloading the v5.2.5 from the repository. I cannot tell them one by one. They are suffering from this. Or team can obsolete v5.2.5 and force people to use v1.3.1

Can you help me to notify olympia? I cannot PM him.
Two years ago, he added these 3 Chinese locales into v5.1.x . At that moment, TMDb web API still accepted small letters requests, so i did not further follow that update anymore.

However, it restricts the requirement 1 year later during the platform reforms and I just recently update my movie cache and find this problem again.


RE: TMDb scraper bug on region code passing - Karellen - 2020-12-31

(2020-12-31, 10:03)pbodq Wrote: Can you help me to notify olympia?
I already have. I pinged him in my post.

It would be quicker if you created a PR, then all he needs to do is check it and merge it.


RE: TMDb scraper bug on region code passing - Karellen - 2020-12-31

@pbodq

You are in luck. It looks like olympia update the languages for you.

It is important that you reset your scraper so then new settings take effect. Follow these instructions... https://forum.kodi.tv/showthread.php?tid=357864&pid=2983546#pid2983546


RE: TMDb scraper bug on region code passing - pbodq - 2021-01-01

(2020-12-31, 22:06)Karellen Wrote: @pbodq

You are in luck. It looks like olympia update the languages for you.

It is important that you reset your scraper so then new settings take effect. Follow these instructions... https://forum.kodi.tv/showthread.php?tid=357864&pid=2983546#pid2983546

yes, thanks for your help. i just downloaded it and tested. Wonderful!!


This forum uses Lukasz Tkacz MyBB addons.