Kodi Community Forum
Fixing PGS subtitle bug - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+---- Forum: VideoPlayer Development (https://forum.kodi.tv/forumdisplay.php?fid=240)
+---- Thread: Fixing PGS subtitle bug (/showthread.php?tid=363441)



Fixing PGS subtitle bug - hugohuetzel - 2021-07-06

Hi,

i am trying to fix a bug with PGS subtitles in 3D mode. I found the place where the bug happens but i don't understand the purpose of the modification of width or height of the subtitle overlay which is done only in 3D mode. (see  File: xbmc/cores/VideoPlayer/DVDCodecs/Overlay/DVDOverlayCodecFFmpeg.cpp Line: 245ff)
When i comment this out all is going fine with PGS subtitles in 3D mode.

Can someone tell me the purpose of this code?


ps: i hope this is not again a double or cross post


RE: Fixing PGS subtitle bug - Dukar - 2023-07-31

(2021-07-06, 09:39)hugohuetzel Wrote: Hi,

i am trying to fix a bug with PGS subtitles in 3D mode. I found the place where the bug happens but i don't understand the purpose of the modification of width or height of the subtitle overlay which is done only in 3D mode. (see  File: xbmc/cores/VideoPlayer/DVDCodecs/Overlay/DVDOverlayCodecFFmpeg.cpp Line: 245ff)
When i comment this out all is going fine with PGS subtitles in 3D mode.

Can someone tell me the purpose of this code?


ps: i hope this is not again a double or cross post
The modification of width or height of the subtitle overlay in 3D mode (Line 245ff in DVDOverlayCodecFFmpeg.cpp) seems to be causing a bug with PGS subtitles. By commenting it out, the issue is resolved. The code likely adjusts the subtitle rendering for 3D content, but further investigation is needed to understand its exact purpose.


RE: Fixing PGS subtitle bug - pinkpanther77 - 2024-04-22

Hi! This is an old thread but how can I find this file?


RE: Fixing PGS subtitle bug - scott967 - 2024-04-25

It's part of the code base at the xbmc team github account xbmc repo, but unless you are in a position to compile/build Kodi yourself doesn't do you any good.  You can start with the wiki though if interested.

scott s.
.


This forum uses Lukasz Tkacz MyBB addons.