Kodi Community Forum
Beta Artwork support and other improvements - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: PVR & Live TV Support (https://forum.kodi.tv/forumdisplay.php?fid=167)
+---- Forum: VDR (https://forum.kodi.tv/forumdisplay.php?fid=169)
+---- Thread: Beta Artwork support and other improvements (/showthread.php?tid=363935)

Pages: 1 2 3


Artwork support and other improvements - -Dis - 2021-08-10

I've made version of VDR vnsiserver and Kodi VNSI client which supports movie and tv series artwork.

With modified VNSI you also need vdr-plugin-tvscraper (https://github.com/vdr-projects/vdr-plugin-tvscraper). vdr-plugin-scraper2vdr should also work but it's not tested.

Currently server and client have to be in same machine for this to work.

Modified VNSI can be found:
vnsiserver: https://github.com/Dis90/vdr-plugin-vnsiserver/tree/tvscraper
pvr.vdr.vnsi: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper


Any feedback and suggestions are welcome Smile


RE: Artwork support and other improvements - -Dis - 2021-08-13

I updated forum topic to "...and other improvements" because I'm currently working to get recordings playback progress sync between VDR and Kodi to work. What are your thoughts should it be configurable (on or off)? It is now possible enable/disable backend resume positions. Default is disabled.

Edit. new versions with artwork and playback progress from VDR available:
vnsiserver: https://github.com/Dis90/vdr-plugin-vnsiserver/tree/tvscraper_playbackprogress
pvr.vdr.vnsi: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_playbackprogress


I still need to do:
- VNSI protocol version check to both server and client so nothing breaks example when users vnsiserver doesn't support artwork/resume position but client does.
- Support for artwork from remote server


Edit 17.8. New versions available:
vnsiserver: https://github.com/Dis90/vdr-plugin-vnsiserver/tree/tvscraper_backendresume
pvr.vdr.vnsi: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_backendresume

Edit 17.11.
pvr.vdr.vnsi:
Kodi Matrix: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_backendresume_matrix
Kodi Nexus: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_backendresume_nexus


RE: Artwork support and other improvements - P0jn0A - 2021-08-18

(2021-08-13, 00:32)-Dis Wrote: I updated forum topic to "...and other improvements" because I'm currently working to get recordings playback progress sync between VDR and Kodi to work. What are your thoughts should it be configurable (on or off)? It is now possible enable/disable backend resume positions. Default is disabled.

Edit. new versions with artwork and playback progress from VDR available:
vnsiserver: https://github.com/Dis90/vdr-plugin-vnsiserver/tree/tvscraper_playbackprogress
pvr.vdr.vnsi: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_playbackprogress


I still need to do:
- VNSI protocol version check to both server and client so nothing breaks example when users vnsiserver doesn't support artwork/resume position but client does.
- Support for artwork from remote server


Edit 17.8. New versions available:
vnsiserver: https://github.com/Dis90/vdr-plugin-vnsiserver/tree/tvscraper_backendresume
pvr.vdr.vnsi: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_backendresume

I am very appreciated to see new steps forward.
My vdr server are installed with ubuntu and need a refresh next year.
years ago, i did compile the packages by myself. This was better than using binary packages from others.

What Linux Distribution do you use?
I have e fresh Manjaro installation and will test your source code.

There is a nasty bug with the option "Replace filenames with library titles". Maybe you are able to fix the issue too?


RE: Artwork support and other improvements - -Dis - 2021-08-19

(2021-08-18, 18:48)P0jn0A Wrote:
(2021-08-13, 00:32)-Dis Wrote: I updated forum topic to "...and other improvements" because I'm currently working to get recordings playback progress sync between VDR and Kodi to work. What are your thoughts should it be configurable (on or off)? It is now possible enable/disable backend resume positions. Default is disabled.

Edit. new versions with artwork and playback progress from VDR available:
vnsiserver: https://github.com/Dis90/vdr-plugin-vnsiserver/tree/tvscraper_playbackprogress
pvr.vdr.vnsi: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_playbackprogress


I still need to do:
- VNSI protocol version check to both server and client so nothing breaks example when users vnsiserver doesn't support artwork/resume position but client does.
- Support for artwork from remote server


Edit 17.8. New versions available:
vnsiserver: https://github.com/Dis90/vdr-plugin-vnsiserver/tree/tvscraper_backendresume
pvr.vdr.vnsi: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_backendresume

I am very appreciated to see new steps forward.
My vdr server are installed with ubuntu and need a refresh next year.
years ago, i did compile the packages by myself. This was better than using binary packages from others.

What Linux Distribution do you use?
I have e fresh Manjaro installation and will test your source code.

There is a nasty bug with the option "Replace filenames with library titles". Maybe you are able to fix the issue too?
I'm using Ubuntu. Good if you have time to test this on different platform. Currently this is only tested by me.

Do you want explain "Replace filenames with library titles" bug? I can try to fix it but I didn't even know such a feature Big Grin


RE: Artwork support and other improvements - P0jn0A - 2021-08-19

(2021-08-19, 14:09)-Dis Wrote:
(2021-08-18, 18:48)P0jn0A Wrote:
(2021-08-13, 00:32)-Dis Wrote: I updated forum topic to "...and other improvements" because I'm currently working to get recordings playback progress sync between VDR and Kodi to work. What are your thoughts should it be configurable (on or off)? It is now possible enable/disable backend resume positions. Default is disabled.

Edit. new versions with artwork and playback progress from VDR available:
vnsiserver: https://github.com/Dis90/vdr-plugin-vnsiserver/tree/tvscraper_playbackprogress
pvr.vdr.vnsi: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_playbackprogress


I still need to do:
- VNSI protocol version check to both server and client so nothing breaks example when users vnsiserver doesn't support artwork/resume position but client does.
- Support for artwork from remote server


Edit 17.8. New versions available:
vnsiserver: https://github.com/Dis90/vdr-plugin-vnsiserver/tree/tvscraper_backendresume
pvr.vdr.vnsi: https://github.com/Dis90/pvr.vdr.vnsi/tree/tvscraper_backendresume

I am very appreciated to see new steps forward.
My vdr server are installed with ubuntu and need a refresh next year.
years ago, i did compile the packages by myself. This was better than using binary packages from others.

What Linux Distribution do you use?
I have e fresh Manjaro installation and will test your source code.

There is a nasty bug with the option "Replace filenames with library titles". Maybe you are able to fix the issue too?
I'm using Ubuntu. Good if you have time to test this on different platform. Currently this is only tested by me.

Do you want explain "Replace filenames with library titles" bug? I can try to fix it but I didn't even know such a feature Big Grin
This feature "Replace filenames..." replaces only recording with information in the video database (movie section), so you can easily find recordings with no information in the video db. Without this feature you have to screen the kodi.log for missing videos and this is ugly.

i opened an issue in the year 2018: Replace filenames with library titles" will not work with VDR VNSI Client #14791

skin: estuary mod v2 matrix
You can find the switch under:
Settings -> Media settings -> videos -> rubrik "files"

I have my complete vdr recordings under kodi -> video -> source recordings
no nfs or cifs in use!
and central mysql/mariadb database hold all information.
I can see every recording from any kodi client with vnsi without any additional configuration.
This is really one of the best features for me. Install kodi, configure vnsi (optional advanced settings for videodb) that's all.

if you go to the video section and select media source "recordings", than you will see all you vdr recordings (cutted with %). No fanart and only the description from vdr is visible. Than play a recording and stop it after a view seconds. Now you will see the replaces filename with the video title and the fanart is visible. If you restart kodi, the fanart is not visible till you play the recording.
But, if you select the movie section, the fanart of the same recording is visible an playable and persistent.

i hope this explain the setting


RE: Artwork support and other improvements - -Dis - 2021-08-19

(2021-08-19, 20:29)P0jn0A Wrote: This feature "Replace filenames..." replaces only recording with information in the video database (movie section), so you can easily find recordings with no information in the video db. Without this feature you have to screen the kodi.log for missing videos and this is ugly.

i opened an issue in the year 2018: Replace filenames with library titles" will not work with VDR VNSI Client #14791

skin: estuary mod v2 matrix
You can find the switch under:
Settings -> Media settings -> videos -> rubrik "files"

I have my complete vdr recordings under kodi -> video -> source recordings
no nfs or cifs in use!
and central mysql/mariadb database hold all information.
I can see every recording from any kodi client with vnsi without any additional configuration.
This is really one of the best features for me. Install kodi, configure vnsi (optional advanced settings for videodb) that's all.

if you go to the video section and select media source "recordings", than you will see all you vdr recordings (cutted with %). No fanart and only the description from vdr is visible. Than play a recording and stop it after a view seconds. Now you will see the replaces filename with the video title and the fanart is visible. If you restart kodi, the fanart is not visible till you play the recording.
But, if you select the movie section, the fanart of the same recording is visible an playable and persistent.

i hope this explain the setting

I didn't know it is possible add recordings to video library. I don't think this is something I can fix, unfortunately. More likely Kodi feature.

I can see recorded movies in library and Videos -> Files -> Movies folder from VDR (metadata from scraper) and also in TV -> Recordings. But TV -> Recordings reverts back to VDR info after reboot. Is this same behavior you experienced or did I miss something?


RE: Artwork support and other improvements - P0jn0A - 2021-08-19

(2021-08-19, 21:10)-Dis Wrote:
(2021-08-19, 20:29)P0jn0A Wrote: This feature "Replace filenames..." replaces only recording with information in the video database (movie section), so you can easily find recordings with no information in the video db. Without this feature you have to screen the kodi.log for missing videos and this is ugly.

i opened an issue in the year 2018: Replace filenames with library titles" will not work with VDR VNSI Client #14791

skin: estuary mod v2 matrix
You can find the switch under:
Settings -> Media settings -> videos -> rubrik "files"

I have my complete vdr recordings under kodi -> video -> source recordings
no nfs or cifs in use!
and central mysql/mariadb database hold all information.
I can see every recording from any kodi client with vnsi without any additional configuration.
This is really one of the best features for me. Install kodi, configure vnsi (optional advanced settings for videodb) that's all.

if you go to the video section and select media source "recordings", than you will see all you vdr recordings (cutted with %). No fanart and only the description from vdr is visible. Than play a recording and stop it after a view seconds. Now you will see the replaces filename with the video title and the fanart is visible. If you restart kodi, the fanart is not visible till you play the recording.
But, if you select the movie section, the fanart of the same recording is visible an playable and persistent.

i hope this explain the setting

I didn't know it is possible add recordings to video library. I don't think this is something I can fix, unfortunately. More likely Kodi feature.

I can see recorded movies in library and Videos -> Files -> Movies folder from VDR (metadata from scraper) and also in TV -> Recordings. But TV -> Recordings reverts back to VDR info after reboot. Is this same behavior you experienced or did I miss something?
Yes, this is it.

you can add recordings to the video library. i do this with all my vdr recordings,
but i didn't get series working yet. maybe i have to play with regex to recognise the recording series


RE: Artwork support and other improvements - -Dis - 2021-08-19

(2021-08-19, 21:57)P0jn0A Wrote:
(2021-08-19, 21:10)-Dis Wrote:
(2021-08-19, 20:29)P0jn0A Wrote: This feature "Replace filenames..." replaces only recording with information in the video database (movie section), so you can easily find recordings with no information in the video db. Without this feature you have to screen the kodi.log for missing videos and this is ugly.

i opened an issue in the year 2018: Replace filenames with library titles" will not work with VDR VNSI Client #14791

skin: estuary mod v2 matrix
You can find the switch under:
Settings -> Media settings -> videos -> rubrik "files"

I have my complete vdr recordings under kodi -> video -> source recordings
no nfs or cifs in use!
and central mysql/mariadb database hold all information.
I can see every recording from any kodi client with vnsi without any additional configuration.
This is really one of the best features for me. Install kodi, configure vnsi (optional advanced settings for videodb) that's all.

if you go to the video section and select media source "recordings", than you will see all you vdr recordings (cutted with %). No fanart and only the description from vdr is visible. Than play a recording and stop it after a view seconds. Now you will see the replaces filename with the video title and the fanart is visible. If you restart kodi, the fanart is not visible till you play the recording.
But, if you select the movie section, the fanart of the same recording is visible an playable and persistent.

i hope this explain the setting

I didn't know it is possible add recordings to video library. I don't think this is something I can fix, unfortunately. More likely Kodi feature.

I can see recorded movies in library and Videos -> Files -> Movies folder from VDR (metadata from scraper) and also in TV -> Recordings. But TV -> Recordings reverts back to VDR info after reboot. Is this same behavior you experienced or did I miss something?
Yes, this is it.

you can add recordings to the video library. i do this with all my vdr recordings,
but i didn't get series working yet. maybe i have to play with regex to recognise the recording series
Probably intended behavior in Kodi that it favors data from backend over Kodi library data in TV -> Recordings section.


RE: Artwork support and other improvements - MarkusEh - 2022-02-22

Hi Dis,

I tried this out, but I don't see any images in Kodi Sad .
Where should I see them?

I see some strange messages in kodi log:
Quote:2022-02-22 17:55:17.229 T:10990   ERROR <general>: AddOnLog: pvr.vdr.vnsi: ReadResult - request timed out after 3 seconds
2022-02-22 17:55:17.229 T:10990   ERROR <general>: AddOnLog: pvr.vdr.vnsi: SupportChannelScan - Can't get response packed

2022-02-22 17:55:23.704 T:10995   ERROR <general>: GetChannelGroupMembers: Add-on 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.xxx.xxx:34890' returned an error: server error
 
This is strange, as I can watch TV in KODI, so it works.


RE: Artwork support and other improvements - MarkusEh - 2022-02-23

Hi,

I got somewhat further: In my first try (see last post), I used the master of your repositories. This is wrong, so now I'm using the new branches. The server log:
Quote:Feb 23 08:32:18 rpi4s vdr: [2812] loading /var/lib/vdr/plugins/vnsiserver/allowed_hosts.conf
Feb 23 08:32:18 rpi4s vdr: [2812] VNSI: Client with ID 10 connected: 192.168.178.56:44834
Feb 23 08:32:18 rpi4s vdr: [3235] VNSI Socket 7 thread started (pid=2792, tid=3235, prio=high)
Feb 23 08:32:18 rpi4s vdr: [3236] VNSI Client 10->192.168.178.56:44834 thread started (pid=2792, tid=3236, prio=high)
Feb 23 08:32:18 rpi4s vdr: [3236] VNSI: Welcome client 'XBMC Media Center' with protocol version '14'
looks good. Client log:
Quote:2022-02-23 08:32:18.615 T:28111   ERROR <general>: AddOnLog: pvr.vdr.vnsi: SupportChannelScan - Can't get response packed
2022-02-23 08:32:18.615 T:28111    INFO <general>: AddOnLog: pvr.vdr.vnsi: SupportRecordingsUndelete - Undelete not supported on backend (min. Ver. 1.3.0; Protocol 7)
2022-02-23 08:32:18.621 T:28139    INFO <general>: AddOnLog: pvr.vdr.vnsi: Logged in at '1645601538+3600' to 'VDR-Network-Streaming-Interface (VNSI) Server' Version: '1.8.0' with protocol version '14'
2022-02-23 08:32:21.623 T:28139   ERROR <general>: AddOnLog: pvr.vdr.vnsi: ReadResult - request timed out after 3 seconds
2022-02-23 08:32:21.624 T:28139   ERROR <general>: AddOnLog: pvr.vdr.vnsi: SupportChannelScan - Can't get response packed
2022-02-23 08:32:21.625 T:28111   ERROR <general>: AddOnLog: pvr.vdr.vnsi: ReadResult - request timed out after 3 seconds
2022-02-23 08:32:21.625 T:28111   ERROR <general>: AddOnLog: pvr.vdr.vnsi: GetTimerTypes - Can't get response packed

2022-02-23 08:32:27.734 T:28143   ERROR <general>: GetChannelGroupMembers: Add-on 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.178.33:34890' returned an error: server error
2022-02-23 08:32:27.734 T:28143   ERROR <general>: GetChannelGroupMembers: PVR client 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.178.33:34890' returned an error: server error
2022-02-23 08:32:28.177 T:28143   ERROR <general>: GetChannelGroups: Add-on 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.178.33:34890' returned an error: server error
2022-02-23 08:32:28.177 T:28143   ERROR <general>: GetChannelGroups: PVR client 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.178.33:34890' returned an error: server error
2022-02-23 08:32:31.179 T:28143   ERROR <general>: AddOnLog: pvr.vdr.vnsi: ReadResult - request timed out after 3 seconds
2022-02-23 08:32:31.180 T:28143   ERROR <general>: AddOnLog: pvr.vdr.vnsi: GetAvailableRecordings - Can't get response packed
2022-02-23 08:32:31.180 T:28143   ERROR <general>: GetRecordings: Add-on 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.178.33:34890' returned an error: unknown error
2022-02-23 08:32:31.180 T:28143   ERROR <general>: GetRecordings: PVR client 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.178.33:34890' returned an error: unknown error
2022-02-23 08:32:31.182 T:28143    INFO <general>: PVR Manager: Started
2022-02-23 08:32:34.182 T:28145   ERROR <general>: AddOnLog: pvr.vdr.vnsi: ReadResult - request timed out after 3 seconds
2022-02-23 08:32:34.182 T:28145   ERROR <general>: AddOnLog: pvr.vdr.vnsi: GetDriveSpace - Can't get response packed
2022-02-23 08:32:34.182 T:28145   ERROR <general>: GetDriveSpace: Add-on 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.178.33:34890' returned an error: server error
2022-02-23 08:32:34.183 T:28143   ERROR <general>: AddOnLog: pvr.vdr.vnsi: ReadResult - request timed out after 3 seconds
2022-02-23 08:32:34.183 T:28143   ERROR <general>: AddOnLog: pvr.vdr.vnsi: GetChannels - Can't get response packed
2022-02-23 08:32:34.183 T:28143   ERROR <general>: GetChannels: Add-on 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.178.33:34890' returned an error: server error
2022-02-23 08:32:34.183 T:28143   ERROR <general>: GetChannels: PVR client 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.178.33:34890' returned an error: server error
2022-02-23 08:32:37.183 T:28145   ERROR <general>: AddOnLog: pvr.vdr.vnsi: ReadResult - request timed out after 3 seconds
2022-02-23 08:32:37.183 T:28145   ERROR <general>: AddOnLog: pvr.vdr.vnsi: GetChannelsAmount - Can't get response packed
2022-02-23 08:32:37.183 T:28145   ERROR <general>: GetChannelsAmount: Add-on 'VDR-Network-Streaming-Interface (VNSI) Server:192.168.178.33:34890' returned an error: server error
I cannot see channels, I cannot see recordings, and I cannot watch TV Sad


RE: Artwork support and other improvements - MarkusEh - 2022-02-24

Finally, it works Smile
I had to increase the "Connect timeout(s)" value in the KODI vnsi addon settings.

So, now I have a feature request: Could you also support artwork, in addition to posters? Best would be to support all image types supported by KODI.


RE: Artwork support and other improvements - -Dis - 2022-02-24

@MarkusEh Sorry I just now noticed your messages.

Good that you made it work. Unfortunately Kodi PVR supports only thumbnail and fanart for recordings and only icon for epg. See https://alwinesch.github.io/group__cpp__kodi__addon__pvr.html

There's Estuary mod available which uses own PVR artwork module https://forum.kodi.tv/showthread.php?tid=366400
I haven't tested it.


RE: Artwork support and other improvements - -Dis - 2022-02-24

For some reason VNSI uses picon name format for channel logos. What you think is channel name better? That is what most VDR skins also uses and Kodi if you enable logo scan from PVR settings. I've already made this change for my own purposes.

I really hope that someone will take over this project.


RE: Artwork support and other improvements - MarkusEh - 2022-02-24

Hi Dis,

Recordings also do have an "Icon path"?


RE: Artwork support and other improvements - -Dis - 2022-02-24

I think that is meant to be used with channel logo. At least I made it that way in my own version (not in Github). It shows icon next to recording name in lists.

Edit. actually I don't use icon path in recordings because that overwrites channel logos.

Change this in src/ClientInstance.cpp:
Code:

if (m_protocol >= 6)
{
std:Confusedtring path = CVNSISettings::Get().GetIconPath();
std:Confusedtring ref = vresp->extract_String();
if (!path.empty())
{
if (path[path.length() - 1] != '/')
path += '/';
path += ref;
path += ".png";
tag.SetIconPath(path);
}
}

To this:
Code:

      if (m_protocol >= 6)
      {
        std:Confusedtring path = CVNSISettings::Get().GetIconPath();
        vresp->extract_String(); // PiconRef - unused
        std:Confusedtring ch = tag.GetChannelName();
        std::transform(ch.begin(), ch.end(), ch.begin(), ::tolower);

        if (!path.empty())
        {
          if (path[path.length() - 1] != '/')
            path += '/';
          path += ch;
          path += ".png";
          tag.SetIconPath(path);
        }
      }

If you want to use channel logos which aren't in picon naming and from VNSI Client settings specify path to logos.

This way can see channel logos next to recording name and of course in EPG.

Artwork for PVR is really a mess and documentation doesn't clearly explain what is used for what. And why there's no poster at all?