+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: General Support (https://forum.kodi.tv/forumdisplay.php?fid=111)
+---- Forum: Android (https://forum.kodi.tv/forumdisplay.php?fid=164)
+---- Thread: Release [obsolete - now in nightlies] Build - Dolby Vision compatibility/quality improvements (/showthread.php?tid=371557)
RE: Build - Dolby Vision compatibility/quality improvements - quietvoid - 2024-01-21
(2024-01-21, 13:01)samcuddy123 Wrote: I don’t suppose there is any information on whether the disable dv or hdr setting will get authorised into master? Or do you know get that information until it happens?
There hasn't been an attempt to get it merged in Kodi upstream.
RE: Build - Dolby Vision compatibility/quality improvements - fritsch - 2024-01-21
I see the struggle of adding Strings and Settings for Android only to Kodi and much more to design the underlaying "home growness" (kodi's homegrown ;-)) of Video Decoder selections to form a good solution. Infact I had a similar issue this morning. On the one hand side I wanted to give users the possibility to shoot themselves in the foot with some audio quality settings, but I also did not want to break defaults or cause regressions. Additionally similar to Video-Decoders - queyring setting is not really forseen in the audio sink.
I infact went with an advancedsettings and tagged it v21 only. Given that most stuff works for "most users" out of the box now. This might be a possibility to make it "very lean" into V21.
RE: Build - Dolby Vision compatibility/quality improvements - quietvoid - 2024-01-21
(2024-01-21, 13:48)fritsch Wrote: I see the struggle of adding Strings and Settings for Android only to Kodi and much more to design the underlaying "home growness" (kodi's homegrown ;-)) of Video Decoder selections to form a good solution. Infact I had a similar issue this morning. On the one hand side I wanted to give users the possibility to shoot themselves in the foot with some audio quality settings, but I also did not want to break defaults or cause regressions. Additionally similar to Video-Decoders - queyring setting is not really forseen in the audio sink.
I infact went with an advancedsettings and tagged it v21 only. Given that most stuff works for "most users" out of the box now. This might be a possibility to make it "very lean" into V21.
The settings isn't really the issue but I've explained it in detail here: https://github.com/xbmc/xbmc/issues/24390#issuecomment-1877207470
It would also be useful on webOS.
RE: Build - Dolby Vision compatibility/quality improvements - fritsch - 2024-01-21
Ah - you are concerned right now. That the detection _before hand_ is not good enough, as the information might just not be available for knowing it at that time. Yeah - similar issue we had for years with "progressive" vs. "interlaced" which might only be known after some packages clearly, here we improved the render reconfiguration. If ffmpeg could parse that stuff during demuxer stage already, it could be shipped via hints.
In practice though - you have access to entire ffmpeg helpers / entire ffmpeg library even on Android. And even VideoPlayer can send OnAVChange whenever something fundamentally changes.
RE: Build - Dolby Vision compatibility/quality improvements - quietvoid - 2024-01-21
The information is available it's just not supported by the bitstream parser.
The FFmpeg SEI parsers aren't exposed which is why I said they're not available, so it would have to be partially copied or done from scratch.
Doing this at demux time would require a custom bsf which is probably more complicated.
RE: Build - Dolby Vision compatibility/quality improvements - samcuddy123 - 2024-01-21
That was a lot of complex words I do not understand 😂. All I got was that it hasn’t been submitted to be part of kodi main builds and by the sounds of it may not be for a while. Haha
RE: Build - Dolby Vision compatibility/quality improvements - black_eagle - 2024-01-21
Hmmm, This isn't an area I know much about at all. However, I do know that my viewing experience would be much worse without this. I also know I would prefer to run vanilla Kodi rather than other peoples builds (or even my own as building for Android I find a PITA). Therefore, as "it works™" I would like to see it included. Saves me trying to follow multiple forks to get the best experience.....
RE: Build - Dolby Vision compatibility/quality improvements - samcuddy123 - 2024-01-21
Mine too. Have only been using the build for less than a day and it’s hugely Improved it’s gone from me looking at other hardware to now being more than happy with my firestick 4K max.
RE: Build - Dolby Vision compatibility/quality improvements - boboc - 2024-01-21
I use this fix for about 5 months and am happy with it. I compile Kodi myself and can cherry-pick quietvoid' commit before compiling from master branch. If I use official nightly builds (for various tests) it doesn't take that long until I stumble upon a video which gives me a black screen again. Then I install my build with the fix, which always fixes the issue.
I have never encountered a video which wouldn't work with current fix. Even though the fix doesn't cover all possible theoretical cases, it works perfectly in real life and in my opinion should be included in v21. Otherwise AFT users have to use custom builds.
RE: Build - Dolby Vision compatibility/quality improvements - frodo19 - 2024-01-22
I use these build almost one year, when the first quietvoid build released.
Without that. I have lot of black screen, unplayable movies, in Firesticks.
But I use paralel in all of my android devices, like shield tv pro 2019, homatics, and dune boxes.
Never had any issue with those boxes too, was would cause this build.
Im really sad, cos this dv/hdr10plus switch not part of main kodi.
Its just simple working good.
RE: Build - Dolby Vision compatibility/quality improvements - quietvoid - 2024-01-22
I'll try to take some time this week to look into implementing it properly.
RE: Build - Dolby Vision compatibility/quality improvements - Sholander - 2024-01-22
That would be great if can finally be merged into official builds
If it does not work out is it possible that you can work it out with CoreElec devs to include it to their 21.x builds?
Don't know if you worked on "Maven's" builds (which I also use along with CE), or did @Maven include your code into his builds by himself; I can only say that his builds work the same as your build does - perfect. Thanx for your effort!
RE: Build - Dolby Vision compatibility/quality improvements - boboc - 2024-01-22
Maven has merged quietvoid' fix into his builds on my request
RE: Build - Dolby Vision compatibility/quality improvements - frodo19 - 2024-01-22
Also CoreElec builded the first dv version with quietvoid help, for homatics boxes.
CoreELEC has built auto switch, to force dv when dv and HDR+ available together. There is no black screen.
When you want just hdr10plus, you can set manual dv off.
So there no need changes.
RE: Build - Dolby Vision compatibility/quality improvements - Sholander - 2024-01-22
Yes, I'm aware of that, but it is implemented only in "ne" versions, which cannot be installed on N2; so my interest is implementation in "ng" version.