+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Subtitle Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=143)
+---- Thread: [RELEASE] OpenSubtitles OSD (Script) (/showthread.php?tid=56083)
- fidoboy - 2009-09-17
don't get the activated sub, just look into the same folder than the current playing movie for a file with the same name but with different extension.
With linked by has i want to mean if it was downloaded using this script, sorry...
The other data:
Name of the movie is the current title (original title)
Language should be the XBMC language by default (add the option in script settings)
Service to upload to, should be defined in script settings also...
regards,
- amet - 2009-09-17
fidoboy Wrote:don't get the activated sub, just look into the same folder than the current playing movie for a file with the same name but with different extension.
With linked by has i want to mean if it was downloaded using this script, sorry...
The other data:
Name of the movie is the current title (original title)
Language should be the XBMC language by default (add the option in script settings)
Service to upload to, should be defined in script settings also...
regards,
You wouldn want to upload the name of the movie as "Year.One.UNRATED.DVDRip.XviD-ARROW.avi" when the movie is called "Year One (2009)".
Not everyone has all the movies scanned in the library, and if the movie is not in the library thats what the "Title" is.
the script has two download languages, we need to tell the script which one to use. maybe its the manually added sub and the language is not the same as scripts default.
complicated, and you have to take in account that not all the setups are the same.
XBOX users will not be able to upload subs for movies that are on SMB drives.
Zeljko
- ezechiel1917 - 2009-09-17
Amet Wrote:that just gave me an idea. we could calculate how far the movie is watched, and if it is more than 90% consider the users action as "upload".... no one will be downloading a sub 90% in to a movie...Wow, that's a great idea!
Amet Wrote:it will still need a lot of input from the userI think you should be able to get name of movie/series+season+ep# from Library, active subtitle file shouldn't be a problem too I guess, language of subs can be autodetected if language string is present in subtitle filename, and service can be set in options. So in ideal situation we wouldn't need anything else than confirmation to upload subs with all of previously mentioned details.
1) name of the movie.
2) possibly subtitle file(not sure we can get the info we need from XBMC)
3) language of the sub
4) service to upload to
plus user name and password in settings menu.
- amet - 2009-09-17
ezechiel1917 Wrote:Wow, that's a great idea!
I think you should be able to get name of movie/series+season+ep# from Library, active subtitle file shouldn't be a problem too I guess, language of subs can be autodetected if language string is present in subtitle filename, and service can be set in options. So in ideal situation we wouldn't need anything else than confirmation to upload subs with all of previously mentioned details.
I have explained about the movie names here :
Amet Wrote:You wouldn want to upload the name of the movie as "Year.One.UNRATED.DVDRip.XviD-ARROW.avi" when the movie is called "Year One (2009)".
Not everyone has all the movies scanned in the library, and if the movie is not in the library thats what the "Title" is.
the script has two download languages, we need to tell the script which one to use. maybe its the manually added sub and the language is not the same as scripts default.
complicated, and you have to take in account that not all the setups are the same.
XBOX users will not be able to upload subs for movies that are on SMB drives.
Zeljko
the language string is present in the sub file that is downloaded with script, if its not we are depending on user to rename the file so it has the language.
preselecting service limits it to one service, and if thats the service we downloaded from its uploading the same file...
Having more opinions would definitely help.
Zeljko
- ezechiel1917 - 2009-09-17
I guess I didn't make myself clear enough. I don't see a reason why should I download subs with one service and upload those subs to other service, while it might be a good idea for someone (then you have to really watch a whole movie first) I had something else on my mind.
I prefer doing all the job first on a workstation, download subs there, sync them, get nfo/thumbs etc., then have movies scanned to XBMC library and I'd like simple way to upload them to OSDb. Although I could upload these subtitles outside XBMC I would like to upload them as easy as possible. Your script and OSDb hashing looks as good option for it. If I'm already watching a movie (or finishing one) I'd simply submit these subtitles. No extra info needed.
Ofc there will be people who don't have movies in library, then you have to prompt all the info like you said. I'm fine with this alternative, but having a simple way is better solution for people who have things properly organized already.
- amet - 2009-09-17
ezechiel1917 Wrote:I guess I didn't make myself clear enough. I don't see a reason why should I download subs with one service and upload those subs to other service, while it might be a good idea for someone (then you have to really watch a whole movie first) I had something else on my mind.
I prefer doing all the job first on a workstation, download subs there, sync them, get nfo/thumbs etc., then have movies scanned to XBMC library and I'd like simple way to upload them to OSDb. Although I could upload these subtitles outside XBMC I would like to upload them as easy as possible. Your script and OSDb hashing looks as good option for it. If I'm already watching a movie (or finishing one) I'd simply submit these subtitles. No extra info needed.
Ofc there will be people who don't have movies in library, then you have to prompt all the info like you said. I'm fine with this alternative, but having a simple way is better solution for people who have things properly organized already.
I am 100% with you on this. I will not watch a movie/Tv Series before its scanned in a library and all the thumbs are in place. but if you look back just in this post you will see that people use funny names and release names from different groups whose name has almost nothing to do with the file name.
As easy it would be for people like yourself who have the whole library sorted, I have to put the alternative solutions in place for people that dont.
I am working on the code, but I am still unsure about implementation
Zeljko
- Ramshackles - 2009-09-17
Amet, any chance of adding subtitlesource.org ? I still find myself going there often for a bit rarer subs.
Pretty sure they have an documented api.
- amet - 2009-09-17
Ramshackles Wrote:Amet, any chance of adding subtitlesource.org ? I still find myself going there often for a bit rarer subs.
Pretty sure they have an documented api.
I dont think so, It only has 8 supported languages.
Sorry mate, If they decide to expand a bit and support more languages I would definitely look into it.
Zeljko
- infy - 2009-09-20
Again awesome...recent progress is really great.
Because I have my movies on the network somewhere, I use the custom subtitles folder.
I've had automated programs add subtitles to my movies (on the network) a while back. These aren't always the right ones (not in sync or just plain wrong)
When I notice this I ofcourse use your awesome script. Here come my two questions..
Does it automatically switch to the new one uploaded to the custom folder?
If my first pick downloaded by your program turns out to be out of sync and I use it again and pick a different one will it automatically pick the new one? That would be great. Because I think now it might not do it. I think it's needed to go into the audio/sound section and scroll through av subs.
If my conclusions are wrong, I'm sorry...
keep up the good work! you're my hero :p
- amet - 2009-09-20
infy Wrote:Again awesome...recent progress is really great.
Because I have my movies on the network somewhere, I use the custom subtitles folder.
I've had automated programs add subtitles to my movies (on the network) a while back. These aren't always the right ones (not in sync or just plain wrong)
When I notice this I ofcourse use your awesome script. Here come my two questions..
Does it automatically switch to the new one uploaded to the custom folder?
Yes the script is programed to do that. It will enable/activate the last downloaded subtitle.
infy Wrote:If my first pick downloaded by your program turns out to be out of sync and I use it again and pick a different one will it automatically pick the new one? That would be great. Because I think now it might not do it. I think it's needed to go into the audio/sound section and scroll through av subs.
I mentioned this earlier in the thread, sometimes without the valid reason the old subtitle will get stuck and you need to toggle it in subtitles menu. I am not sure why it happens and it is totally random, I have tested with the same file downloading 10-15 times in a row. sometimes (1 out of 10 times) it got stuck to the old sub. Unfortunately there isnt much I can do as it seems to be the XBMC issue of not recognising the stream correctly.
infy Wrote:If my conclusions are wrong, I'm sorry...
keep up the good work! you're my hero :p
I am glad you have found it usefull, it wouldnt be half as fun if I didnt share it with this great community.
Check the first page:
PHP Code:
New Version 1.35 is out now.
- Changed OpenSubtitles.org to new server, the response is much faster
- Finnish Translation
- Added Debug log toggle button in settings, if you are having trouble with the script you will need to enable this before posting the xbmc debug log.
- Added support for accented characters in file names.If you are using accented characters please let me know that everything is working correctly.
- Few visual fixes
If there are any problems please let me know.
Zeljko
- mindweaver - 2009-09-22
Quote:Just upgraded to osOSD 1.33 and my Aeon skin textures is gone. I can only see the osOSD text items. What could be wrong?
Amet Wrote:Can you post the log?
How did you upgrade?
Zeljko
I used the SVN Repo Installer to upgrade as used before.
here is my log: http://pastebin.com/f638698fb
It is the same for 1.35
- amet - 2009-09-22
mindweaver Wrote:I used the SVN Repo Installer to upgrade as used before.
here is my log: http://pastebin.com/f638698fb
It is the same for 1.35
In 1.35 you need to enable debug log in scripts settings menu before posting the log as it is switched off by default. Enabling XBMC debug log would also help.
Did you by any chance copy xml file from scripts 720p folder to the Aeon skins 720p? if yes you would need to copy all the media files frfom media folder. on xp portability mode there is a problem that the script doesn't find the xml file and media files.
Zeljko
- mindweaver - 2009-09-22
Amet Wrote:In 1.35 you need to enable debug log in scripts settings menu before posting the log as it is switched off by default. Enabling XBMC debug log would also help.
Zeljko
ok, will fix that.
-
On another note:
With the latest SVN (22975) I get the following:
Code:
09:24:37 T:4856 M:1237196800 NOTICE: File "C:\Users\XXX\AppData\Roaming\XBMC\scripts\OpenSubtitles_OSD\default.py", line 151, in ?
09:24:37 T:4856 M:1237196800 NOTICE: ui = gui.GUI( "script-OpenSubtitles_OSD-"+ skin +".xml" , os.getcwd(), "Default")
09:24:37 T:4856 M:1237131264 NOTICE: TypeError
09:24:37 T:4856 M:1237131264 NOTICE: :
09:24:37 T:4856 M:1237131264 NOTICE: XML File for Window is missing
09:24:37 T:4856 M:1237131264 ERROR: Scriptresult: ErrorSeems that it can't find the xml. Could this have something to do with it? I'm using Aeon (Hitched).
EDIT:
With script debugging on:
Code:
09:29:05 T:5508 M:1280204800 NOTICE: OpenSubtitles_OSD version [1.35]
09:29:05 T:5508 M:1280204800 NOTICE: Skin Folder: [ aeon auriga ]
09:29:05 T:5508 M:1280204800 NOTICE: OpenSubtitles_OSD skin XML: [ Aeon ]
09:29:06 T:5508 M:1275088896 NOTICE: Traceback (most recent call last):
09:29:06 T:5508 M:1275088896 NOTICE: File "C:\Users\John Tilly\AppData\Roaming\XBMC\scripts\OpenSubtitles_OSD\default.py", line 151, in ?
09:29:06 T:5508 M:1274929152 NOTICE: ui = gui.GUI( "script-OpenSubtitles_OSD-"+ skin +".xml" , os.getcwd(), "Default")
09:29:06 T:5508 M:1274929152 NOTICE: TypeError
09:29:06 T:5508 M:1274929152 NOTICE: :
09:29:06 T:5508 M:1274929152 NOTICE: XML File for Window is missing
09:29:06 T:5508 M:1274929152 ERROR: Scriptresult: Error- amet - 2009-09-22
mindweaver Wrote:ok, will fix that.
-
On another note:
With the latest SVN (22975) I get the following:
Code:09:24:37 T:4856 M:1237196800 NOTICE: File "C:\Users\XXX\AppData\Roaming\XBMC\scripts\OpenSubtitles_OSD\default.py", line 151, in ?
09:24:37 T:4856 M:1237196800 NOTICE: ui = gui.GUI( "script-OpenSubtitles_OSD-"+ skin +".xml" , os.getcwd(), "Default")
09:24:37 T:4856 M:1237131264 NOTICE: TypeError
09:24:37 T:4856 M:1237131264 NOTICE: :
09:24:37 T:4856 M:1237131264 NOTICE: XML File for Window is missing
09:24:37 T:4856 M:1237131264 ERROR: Scriptresult: Error
Seems that it can't find the xml. Could this have something to do with it? I'm using Aeon (Hitched).
EDIT:
With script debugging on:
Code:09:29:05 T:5508 M:1280204800 NOTICE: OpenSubtitles_OSD version [1.35]
09:29:05 T:5508 M:1280204800 NOTICE: Skin Folder: [ aeon auriga ]
09:29:05 T:5508 M:1280204800 NOTICE: OpenSubtitles_OSD skin XML: [ Aeon ]
09:29:06 T:5508 M:1275088896 NOTICE: Traceback (most recent call last):
09:29:06 T:5508 M:1275088896 NOTICE: File "C:\Users\John Tilly\AppData\Roaming\XBMC\scripts\OpenSubtitles_OSD\default.py", line 151, in ?
09:29:06 T:5508 M:1274929152 NOTICE: ui = gui.GUI( "script-OpenSubtitles_OSD-"+ skin +".xml" , os.getcwd(), "Default")
09:29:06 T:5508 M:1274929152 NOTICE: TypeError
09:29:06 T:5508 M:1274929152 NOTICE: :
09:29:06 T:5508 M:1274929152 NOTICE: XML File for Window is missing
09:29:06 T:5508 M:1274929152 ERROR: Scriptresult: Error
I just edited the previous post
as all the builds after 22528 are very unstable I cant really say if it is the script or the XBMC.
Try this:
- copy script-OpenSubtitles_OSD-Aeon.xml file from scripts 720p folder to skins 720p folder
- copy all the files from scripts media folder to skins media folder.
- copy all the files from scripts media folder to skins media folder.
Let me know
Zeljko
- mindweaver - 2009-09-22
Amet Wrote:I just edited the previous post
as all the builds after 22528 are very unstable I cant really say if it is the script or the XBMC.
Try this:
- copy script-OpenSubtitles_OSD-Aeon.xml file from scripts 720p folder to skins 720p folder
- copy all the files from scripts media folder to skins media folder.
Let me know
Zeljko
Moving those files made it work
but now I'm at the same point as I am with old "stable" svn of XBMC. No GUI background for osOSD. Log:
Code:
09:44:36 T:2396 M:1179537408 NOTICE: OpenSubtitles_OSD version [1.35]
09:44:36 T:2396 M:1179537408 NOTICE: Skin Folder: [ aeon auriga ]
09:44:36 T:2396 M:1179537408 NOTICE: OpenSubtitles_OSD skin XML: [ Aeon ]
09:44:36 T:2396 M:1178800128 DEBUG: LoadLibraryExA called with flags:
- LOAD_WITH_ALTERED_SEARCH_PATH
09:44:36 T:2396 M:1178800128 DEBUG: LoadLibraryA('pyexpat.pyd')
09:44:36 T:2396 M:1178800128 DEBUG: Win32DllLoader::Load(special://xbmc/system/python/DLLs\pyexpat.pyd)
09:44:36 T:2396 M:1178775552 DEBUG: LoadLibraryA('python24.dll')
09:44:36 T:2396 M:1178775552 DEBUG: LoadLibrary('python24.dll') returning: 06F27E60
09:44:36 T:2396 M:1178775552 DEBUG: LoadLibraryA('MSVCR71.dll')
09:44:36 T:2396 M:1178775552 DEBUG: LoadLibrary('MSVCR71.dll') returning: 030C7E50
09:44:36 T:2396 M:1178775552 DEBUG: LoadLibrary('pyexpat.pyd') returning: 0D1138F0
09:44:36 T:2396 M:1177313280 DEBUG: LoadLibraryExA called with flags:
- LOAD_WITH_ALTERED_SEARCH_PATH
09:44:36 T:2396 M:1177313280 DEBUG: LoadLibraryA('_socket.pyd')
09:44:36 T:2396 M:1177313280 DEBUG: Win32DllLoader::Load(special://xbmc/system/python/DLLs\_socket.pyd)
09:44:36 T:2396 M:1177288704 DEBUG: LoadLibraryA('python24.dll')
09:44:36 T:2396 M:1177288704 DEBUG: LoadLibrary('python24.dll') returning: 06F27E60
09:44:36 T:2396 M:1177288704 DEBUG: LoadLibraryA('MSVCR71.dll')
09:44:36 T:2396 M:1177288704 DEBUG: LoadLibrary('MSVCR71.dll') returning: 030C7E50
09:44:36 T:2396 M:1177284608 DEBUG: LoadLibrary('_socket.pyd') returning: 064F1E50
09:44:36 T:2396 M:1177276416 DEBUG: LoadLibraryExA called with flags:
- LOAD_WITH_ALTERED_SEARCH_PATH
09:44:36 T:2396 M:1177276416 DEBUG: LoadLibraryA('_ssl.pyd')
09:44:36 T:2396 M:1177276416 DEBUG: Win32DllLoader::Load(special://xbmc/system/python/DLLs\_ssl.pyd)
09:44:36 T:2396 M:1176866816 DEBUG: LoadLibraryA('python24.dll')
09:44:36 T:2396 M:1176866816 DEBUG: LoadLibrary('python24.dll') returning: 06F27E60
09:44:36 T:2396 M:1176866816 DEBUG: LoadLibraryA('MSVCR71.dll')
09:44:36 T:2396 M:1176866816 DEBUG: LoadLibrary('MSVCR71.dll') returning: 030C7E50
09:44:36 T:2396 M:1176866816 DEBUG: LoadLibrary('_ssl.pyd') returning: 064F0BE0
09:44:36 T:5204 M:1174843392 DEBUG: CPullupCorrection: detected pattern of length 24: 42000.00 42000.00 42000.00 41000.00 42000.00 42000.00 41000.00 42000.00 42000.00 42000.00 41000.00 42000.00 42000.00 41000.00 42000.00 42000.00 41000.00 42000.00 42000.00 42000.00 41000.00 42000.00 42000.00 41000.00
09:44:36 T:2396 M:1172774912 DEBUG: LoadLibraryExA called with flags:
- LOAD_WITH_ALTERED_SEARCH_PATH
09:44:36 T:2396 M:1172774912 DEBUG: LoadLibraryA('unicodedata.pyd')
09:44:36 T:2396 M:1172774912 DEBUG: Win32DllLoader::Load(special://xbmc/system/python/DLLs\unicodedata.pyd)
09:44:36 T:2396 M:1172746240 DEBUG: LoadLibraryA('python24.dll')
09:44:36 T:2396 M:1172746240 DEBUG: LoadLibrary('python24.dll') returning: 06F27E60
09:44:36 T:2396 M:1172746240 DEBUG: LoadLibraryA('MSVCR71.dll')
09:44:36 T:2396 M:1172746240 DEBUG: LoadLibrary('MSVCR71.dll') returning: 030C7E50
09:44:36 T:2396 M:1172746240 DEBUG: LoadLibrary('unicodedata.pyd') returning: 0D112720
09:44:36 T:2396 M:1172045824 NOTICE: INFO: Manual Search : [False]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: Service : [OpenSubtitles]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: SL Service : [True]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: PN Service : [False]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: OS Service : [True]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: Search String: [24+S07E02]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: Temp?: [True]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: File Path: [v]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: Year: [0]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: Subtitle Folder: [C:\Users\xxxxx\Downloads\]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: Language 1: [eng]
09:44:36 T:2396 M:1172045824 NOTICE: INFO: Language 2: [swe]
09:44:36 T:2396 M:1172045824 DEBUG: ------ Window Init (special://home/skin/Aeon Auriga/720p/script-OpenSubtitles_OSD-Aeon.xml) ------
09:44:36 T:2396 M:1172045824 INFO: Loading skin file: special://home/skin/Aeon Auriga/720p/script-OpenSubtitles_OSD-Aeon.xml
09:44:36 T:2396 M:1172017152 DEBUG: Load special://home/skin/Aeon Auriga/720p/script-OpenSubtitles_OSD-Aeon.xml: 5.97ms
09:44:36 T:2396 M:1171972096 DEBUG: Alloc resources: 10.62ms (6.01 ms skin load)
09:44:36 T:2396 M:1171972096 DEBUG: CGUIMediaWindow::GetDirectory (?)
09:44:36 T:2396 M:1171972096 DEBUG: ParentPath = []
09:44:36 T:2396 M:1171972096 ERROR: DIRECTORY::CDirectory::GetDirectory - Error getting ?
09:44:36 T:2396 M:1171972096 ERROR: CGUIMediaWindow::GetDirectory(?) failed
09:44:36 T:2396 M:1171972096 NOTICE: INFO: onInit
09:44:36 T:2396 M:1171001344 NOTICE: INFO: XBOX System: []
09:44:37 T:2396 M:1170870272 NOTICE: INFO: Search by hash and name 24.S07E02.720p.HDTV.X264-DIMENSION.mkv
09:44:37 T:2400 M:1170853888 DEBUG: thread start, auto delete: 0
09:44:37 T:2404 M:1170845696 DEBUG: thread start, auto delete: 0
09:44:37 T:2404 M:1170550784 DEBUG: Thread 2404 terminating
09:44:37 T:2400 M:1170010112 DEBUG: Thread 2400 terminating
09:44:37 T:2396 M:1170046976 NOTICE: INFO: File Hash: [45bfa45639cacaee]
09:44:37 T:2408 M:1170038784 DEBUG: thread start, auto delete: 0
09:44:37 T:2408 M:1170018304 DEBUG: Thread 2408 terminating
09:44:37 T:2396 M:1170042880 NOTICE: INFO: File Size: [1173131318]
09:44:37 T:2396 M:1169469440 DEBUG: LoadLibraryA('ws2_32')
09:44:37 T:2396 M:1169457152 DEBUG: LoadLibrary('ws2_32.dll') returning: 07284850
09:44:37 T:2396 M:1168080896 NOTICE: INFO: Token:[pirnoiso2cp87ht8fke552p1k3]
09:44:38 T:2396 M:1231941632 NOTICE: INFO: 30 subtitles found
09:44:38 T:2396 M:1231941632 NOTICE: INFO: Hash and Name Search: 30 subtitles found
09:44:46 T:3928 M:1203306496 DEBUG: CWinEventsWin32::WndProcWindow is active
09:44:46 T:3928 M:1203322880 DEBUG: CWinEventsWin32::WndProcWindow lost focus