+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Skin Archive (https://forum.kodi.tv/forumdisplay.php?fid=179)
+----- Forum: Night (https://forum.kodi.tv/forumdisplay.php?fid=130)
+----- Thread: Night - 1.4.7 -Release/General Discussion (/showthread.php?tid=82628)
- mcborzu - 2010-12-09
supertom44 Wrote:Not sure if this has been mentioned before but when browsing episodes via the fanart view the season text appears on top of the logo.
Got that, thx and also flags are updated and fixed spacing issues
- KiSUAN - 2010-12-09
Think they didn't suffer much distortion with the resizes and they take less space, good balance. Great job there.
I spotted another problem with the flags yesterday, didn't have time to work on it today, isn't big, tomorrow will fix it and report it.
- mcborzu - 2010-12-09
KiSUAN Wrote:Think they didn't suffer much distortion with the resizes and they take less space, good balance. Great job there.
I spotted another problem with the flags yesterday, didn't have time to work on it today, isn't big, tomorrow will fix it and report it.
Yea I felt, for Night atleast, just a 5% or so shrink would look best...Yea I've been trying to learn Linux so I barely done anything lately too.
- KiSUAN - 2010-12-09
Yeah, already seen your post asking for some help, petty I barely know about PVRs, they are not common in my country and just 6 days ago I see some posts here about it and put it into my "to learn" list.
- logictester - 2010-12-09
would it be possible to add another flag to mark subtitles by reading the info from the .nfo file?
i know that xbmc couldn't identify .srt files in the folder - can it now?
thanks
- KiSUAN - 2010-12-09
From what I understand it would be possible to display a flag for every available subtitle (language). I`m not 100% sure they can be shown, in think they can.
But the thing is, it would get freaking crowded if they were shown as a “flag”. Even one more flag would be crowded (in case you only wanna show the presence of a srt file), plus I just reduced the number from an average of 6-8 to 6-7 and mcborzu resized to be more proportioned, so more flags shown is out of the question.
As for now I'm at work, and the only thing that comes to my mind is an icon or flag set in the style of the MPAAs, as an example, in poster view lets say that would be placed in the line under the MPAA. The same would be off by default and on by user.
- logictester - 2010-12-09
i actually do think it should be a flag, maybe an optional one, but still a flag - since the flags are there to give us info on the media.
to tell the truth i would add more flags
like source - CAM,TS,TC,Screener, R5 and so on and maybe the release group... but that's just me
- KiSUAN - 2010-12-09
I could add CAM, TS, Screener,...., at files level, but wont do it at library.
Thats what I'm willing to do, you can modify the code later if you want of course.
- zwat - 2010-12-10
my poster layout fits 9 flags just perfect. not sure when u say mcborzu have resized em tho.
- KiSUAN - 2010-12-10
zwat Wrote:my poster layout fits 9 flags just perfect. not sure when u say mcborzu have resized em tho.
https://github.com/bartowski/skin.night/commit/111b2a295473f1d44b41ae78df0d5ac1c754f0b2#diff-0
They have to fit all the views, not just the one you use, besides your poster view is modded, so it doesn't count.
Back to the srt topic, i did some research as I thought I saw something related some time ago and found this: http://trac.xbmc.org/ticket/9736. Think its what we are looking for, but hasn't been addressed by any dev in 4 months, don't know how to bring it up or something, or if I should. Some advice from mcbrozu perhaps, I'm pretty new to this.
Anyway, I will be creating the flaggs in the next week I think and already write the code and changes as sublang is working, just not for srt separate files. Also will be creating flags for CAM, TS, Screener,.... for video nav, at least in my MOD.
- logictester - 2010-12-10
great - could you please post your changes and flags?
thanks a lot
- mcborzu - 2010-12-10
KiSUAN Wrote:https://github.com/bartowski/skin.night/commit/111b2a295473f1d44b41ae78df0d5ac1c754f0b2#diff-0
They have to fit all the views, not just the one you use, besides your poster view is modded, so it doesn't count.
Back to the srt topic, i did some research as I thought I saw something related some time ago and found this: http://trac.xbmc.org/ticket/9736. Think its what we are looking for, but hasn't been addressed by any dev in 4 months, don't know how to bring it up or something, or if I should. Some advice from mcbrozu perhaps, I'm pretty new to this.
Anyway, I will be creating the flaggs in the next week I think and already write the code and changes as sublang is working, just not for srt separate files. Also will be creating flags for CAM, TS, Screener,.... for video nav, at least in my MOD.
@logictester
I thought Alaska had subtitle flags? Do you use Alaska or can you confirm?
My feeling about flags is 5-6 is perfect anything above is too much, doesn't stop you guys from modding but official Night will be 5-6 flags...
- KiSUAN - 2010-12-10
Sorry but Im kinda lost with the post. Have you taken a look to the links in my signature?
@ mcborzu
Downloading the SVN, will check it out, anyway don't know them. I doubt they are in the MPAAs style and the code is no problem, already try it and already figured out, as I said the problem is that there is no support in XBMC for .srt files, there is that ticket, but no dev seems no hive any importance to it.
- logictester - 2010-12-10
Transparency! has a subs flag - CC, didn't check it but i'm pretty sure it reads this info from the nfo file, you can set subs in nfo in media managers like EMM, though srt recognition would be so much cooler
- zwat - 2010-12-10
actually different flags could be shown for different views. if u only make more flag groups.
like mediasourceflag, mediafileformat, videocodec, videoaspectratio, audiocodec, audiochannels. then include the wanted flags to what best fits the view. i would also suggest just having one color on flags and then ppl could just move\rename folders for their own taste. this will make the code simpler and the setting simpler. could do themes with different flag color for the addons crowd thou that will not be good for those who want the purity theme and different color flags. maybe a feature request to have support for both flag theme in combination with flag theme.