Posts: 23,259
Joined: Aug 2011
Reputation:
1,073
fritsch
Team-Kodi Developer
Posts: 23,259
2016-02-04, 09:49
(This post was last modified: 2016-02-04, 09:51 by fritsch.)
We don't have an Android maintainer anymore - therefore the job is to be offered. From looking at it, you don't want to name the var s9, cause most likely the s10 will also support it.
In the resolution code you have some whitespace issues and you use the 10 bit decision to set specific video resolutions, which are platform specific and not hevc-10 bit specific. If you need to know that you are running on an S9, then you should find that out in a different way. hevc-10 bit caps and being an s9 are different things. For future maintainance.
Edit: One can also argue if the int needs to be static or rather a member, as the method calling it is not static.
Besides that: PR welcome.
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Posts: 23,259
Joined: Aug 2011
Reputation:
1,073
fritsch
Team-Kodi Developer
Posts: 23,259
2016-02-04, 09:58
(This post was last modified: 2016-02-04, 09:59 by fritsch.)
If there will never be a device _not_ supporting hevc-10 bit and needing that resolutions ... then fine :-)
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Posts: 268
Joined: Nov 2015
Reputation:
22
I guess not, there would be no logical reason to release a S915 (example name) with no 10 bit support when an older one does support it, but right now I cannot find any other way to detect the presence of S9 or S8, I could check "aarch64" in cpuinfo but IMHO is worse
Posts: 31
Joined: Jan 2016
Reputation:
0
You can download the app to a USB Pen/mSD card and install, use ES explorer.
Just select the apk and install
You'll have a Kodi APP and the new modified app from WeTek
Posts: 6,743
Joined: Oct 2008
Reputation:
317
noggin
Posting Freak
Posts: 6,743
2016-02-04, 14:37
(This post was last modified: 2016-02-04, 14:46 by noggin.)
Have installed from the Mega link earlier in this thread.
I get some very strange results. DTS HD MA tracks trigger my Onkyo amp into DTS HD MA mode (the right lights come on) but I get silence. Dolby True HD stuff appears to be output in a format that makes the receiver think it is PCM 2.0 (I get PCM 2.0 reported by the amp when I check what it thinks it is being fed), and I get silence and the odd bit of digital break up.
Are there settings in Android I need to alter. I've enabled bitstream (DD/DTS is fine bitstreamed) and have also enabled EAC3, DTS HD and True HD. I have tried with speakers at 2.0 and 5.1 (in case that was an issue)
Not sure what I've done wrong.
If I disable passthrough DTS HD MA plays back with 7.1 PCM output fed to the amp (though I've configured 5.1 speakers) No way of checking if this is DTS or DTS HD MA decode. The OSD codec overlay says "dts (DTS HD MA)" and the bitrate is around 3.8Mbs.
The same is true of Dolby True HD tracks. I get 7.1 PCM output to my amp, but no way of knowing if it is DD or True HD that is being decoded, though the OSD codec overlay says "true HD (AC3/ xxxxx)" and reports 3.4Mbs bitrate.
Assuming the overlay is correct, then I'm getting Multichannel PCM Decode - (yay!) - (as per the Pi 2) but not bitstreaming with my current set-up (boo!) ?
If this gets rolled into Linux stuff for the C1/C1+, C2 and other AMLogic devices then Wetek will have done an amazing service to the Kodi community. They appear to be doing a great job so far. Many thanks from me for all of their efforts both on their own products, which are very neatly packaged and made and ideal for people who want to avoid "DIY" and want Netflix etc. But they are also potentially helping us DIYers as well. Which is brilliant and in such an amazing contrast to others <cough> Vidon.
Posts: 23,259
Joined: Aug 2011
Reputation:
1,073
fritsch
Team-Kodi Developer
Posts: 23,259
2016-02-04, 14:45
(This post was last modified: 2016-02-04, 14:46 by fritsch.)
I really hope, that someone rebases on v17 - everything v16 / v15 delivers concerning passthrough is suboptimal. For example in v15/ v16 we send zeros (!) to not underrun the sink, this is just bad and bullshit. In v17 we can create pause packages in IEC format with different lenghts, so the sync is much, much improved.
Wetek sent told to send me a SXX sample - so I will see to get at least the AudioTrack parts in line in a non intrusive way, e.g. by not cluttering a well written sink full with #ifdeffery party. I hope amlogic can convince google to stop their insane non IEC passthrough stuff in the future. I think AMLogic offers a better way in that regard.
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.