[ChristianTroy]

Guys I'm an Android Java dev, I can build custom kernels, fix compile failures, etc being a Gentoo user since 15 years but I'm not a kernel dev...
the Core kernel is here btw if anyone wants to give it a look: https://github.com/christiantroy/android...wetek_core

I will ask to some colleague more suited to the job than me to help

[Koying]

Consider enumerating the 23.976 mode as a normal fractional mode like the 24.0 mode is done - that would be much, much better for userspace.

+100, BTW.

You can leave the FW mode hack for other app if you want, but leave full refresh rate control to Kodi for perfect results.
A 23.976 mode is actually already supported in Kodi: https://github.com/koying/xbmc/blob/mast...s.cpp#L489

P.S. It's in the kernel as well: https://github.com/christiantroy/android...hw.c#L1767
Can anyone post the output of "adb shell cat /sys/class/amhdmitx/amhdmitx0/disp_cap" from the core?

[ChristianTroy]

That should be the resolution that kodi uses for 23.976fps on newer (>= KK) Amlogic kernels, without that this patch from codesnake is required: https://github.com/codesnake/linux-amlog...8f9afe765d

@Koying that resolution is not enumerated (like 25hz and few others) in disp_cap, they are there for internal use, and brought in only when CONFIG_FRAMERATE_AUTOMATION is enabled

[Koying]

Yeah, so the aml system refresh rate just has no purpose with Kodi, right? (Beside the fact that refresh rate switching seems non functional on v17, currently)

[ChristianTroy]

it's actually useful only in one case with Kodi... when Kodi tries to set 24p calls 1080p24hz, the internal mechanism tries to adjust it to 1080p23hz (as long as you have codesnake patch included), calling directly that video mode would avoid the double change but when you call 1080p23hz some other parts kicks in to adjust pll/clocks in the hdmi driver, that's the part that make the audio stutter.

edit: in fact I have tried this morning

Kodi refresh rate switch disabled + manually switching resolution to 1080p24hz (tried also 1080p23hz) before starting video playback
- TrueHD - stutters with /sys/class/tv/policy_fr_auto enabled or disabled at 24hz or 23hz
- DTS-HD - same as above

[fritsch]

Then you need to optimize the clocks, fiddle with the PLL values.

[ChristianTroy]

https://github.com/christiantroy/android...fig.c#L540

that's totally beyond me, I will talk to some other colleague to look into it

[fritsch]

// 2975 for hpll: vco2970 * 0.999

That's wrong :-) 2970 * (1000 / 1001) = 2967 or if they in deed want it the other way round: 2970 * 1001 / 1000 = 2973

Does one of those work? :-)

[Koying]

If I get codesnake patch right, just commenting https://github.com/xbmc/xbmc/blob/master....cpp#L1542 should prevent the internal mechanism to kick in...

[ChristianTroy]

@Koying
yes but the overall purpose should be setting the correct pll for the video mode used, not calling the pll will just have a stuttering playback like with the command to disable framerate automation at all, that is still useful though in Android apps, for example in Netflix, since 1080p23hz is not enumerated you can only switch to 1080p24hz, at that point the "thing" adjusts it for the correct output. Disabling it at all leads to having another 8726MX that had no support for that.

@Koying
honestly I have no clue what they wanna do, I know for sure that in s905 kernel sources there is no "{VMODE_1080P_23HZ, 2975, 4, 2, 1, VIU_ENCP, 10, 2, 1, 1, -1, -1, -1, 1, -1}," mode, I found the clocks in a different file, with this content http://xbmclogs.com/pebm3lhah (s9 05 is gxbb, I'm still trying to find out where the clocks are since there are just the two analog ones...)

[fritsch]

That means that this kernel has no fractional modes at all, sadly.

I also don't think that changing those values will do anything good. See the first commit I linked to tune the audio values.

[Koying]

since 1080p23hz is not enumerated

Oh, it's not? Well, it should

[movie78]

@Koying

What is the status on 3D MVC FramePacking playback on the AmLogic S905?

Thanks!

[dukester]

@Koying

What is the status on 3D MVC FramePacking playback on the AmLogic S905?

Thanks!

lol, its all i really care about lately too..

[Koying]

What is the status on 3D MVC FramePacking playback on the AmLogic S905?

Still HTAB-only for all I know