The TVDB scraper is currently broken due to upgrade works at TheTVDB site. We hope this issue will be resolved quickly.

MKA file tagging support in Kodi?
#16
(2019-06-30, 14:51)henkypenky Wrote:
(2019-06-30, 07:16)Karellen Wrote:
(2019-06-30, 07:06)HomerJau Wrote: Anyone know what tagging programs support mka files now?
https://www.mp3tag.de/en/ 
But it seems to me that you cannot edit the tags on a per track level with mp3tag, can you? I am talking about single mka files per album. This is why I switched to foobar for this purpose. However, would prefer mp3tag as it is my standard tagging tool for FLAC.

Of course you can Huh
Reply
#17
(2019-06-30, 18:20)jjd-uk Wrote: I already said passthrough of TrueHD and hence Atmos wouldn't work, all you'll get is 7.1 LPCM as things stand. The music player underwent a significant code change for v18 as a result initially passthrough of both DTS-HD and TrueHD was lost. Passthrough of DTS-HD was added back in v18.3 however due to lack of any test tracks nothing was done to reinstate TrueHD, in theory to add TrueHD back should be a trivial 2 line code change.

Thanks for clarification. I realized that TrueHD pass through is broken by my last experiments. I also noticed that the gapless play issue I mentioned in another post only shows on DTS-HD tracks but not on normal DTS or LPCM mka files. While there is no gap, however, I've got the impression that the last x hundreds milliseconds of a track are skipped... I don't remember this was the case for Kodi 17.
So bottom line, several aspects around DTSHD and TrueHD have been broken by the big overhaul in Kodi18 and some aspects are still broken in 18.3
Reply
#18
I don't believe gapless was ever meant to work with passthrough formats, my understanding is gapless was only ever meant to work stuff Kodi decodes to LPCM.
Reply
#19
(2019-06-30, 20:06)jjd-uk Wrote: I don't believe gapless was ever meant to work with passthrough formats, my understanding is gapless was only ever meant to work stuff Kodi decodes to LPCM.

Well, in Kodi 17 it was worken well for any mka be it AC3, TrueHD, DTS, DTSHD, or LPCM.
Reply
#20
(2019-06-30, 18:23)jjd-uk Wrote: Of course you can Huh 
Yes, see former reply; found it in the settings...
Reply
#21
(2019-06-30, 18:20)jjd-uk Wrote: I already said passthrough of TrueHD and hence Atmos wouldn't work, all you'll get is 7.1 LPCM as things stand. The music player underwent a significant code change for v18 as a result initially passthrough of both DTS-HD and TrueHD was lost. Passthrough of DTS-HD was added back in v18.3 however due to lack of any test tracks nothing was done to reinstate TrueHD, in theory to add TrueHD back should be a trivial 2 line code change.

Thanks for the clarification. I didn’t realise that’s what your original post meant. I was asking about tagging mka and presumed your comment meant tagging wasn’t supported not playback.

Where can I send Dolby TrueHD music samples for testing getting TrueHD support fixed in Kodi 18.4?

EDIT: Sample mka audio files sent to DaveBlake (and hdmkv for addition to the Kodi Sample Files collection)
Reply
#22
@HomerJau thanks for the example files. While Mp3tag happily shows the tags, the ffmpeg tag parser is not returning the ALBUM tag. Actually it is a mess - Mp3tag does not show everything that ffmpeg parses as a tag, ffmpeg fails to returns some tags that Mp3tag shows, and Kodi does not use some of the values that it could (it isn't expecting ffmpeg to return them). 

In a bit more detail. From the tags in the example files the ffmpeg parser (AVDictionaryEntry creation) read:

"encoder"
"creation_time"
"GENRE"
"COMMENT"
"STYLE"
"ARTIST"
"ARTISTSORT"
"CATALOGID"
"COUNTRY"
"DISC TITLE"
"TITLE"
"DISCOGS_RELEASE_ID"
"ORIGINAL_MEDIA_TYPE"
"MUSICBRAINZ_ALBUMID"
"MUSICBRAINZ_ARTISTID"
"MUSICBRAINZ_TRACKID"
"PUBLISHER"
"track"
"WWW"
"DATE_RECORDED"
"language"
"BPS-eng"
"DURATION-eng"
"NUMBER_OF_FRAMES-eng"
"NUMBER_OF_BYTES-eng"
"_STATISTICS_WRITING_APP-eng"
"_STATISTICS_WRITING_DATE_UTC-eng"
"_STATISTICS_TAGS-eng"

Mp3tag does not show DATE_RECORDED and below from that list.
But Mp3tag does show ALBUM, ALBUMARTIST, DISCNUMBER and YEAR tag values, which ffmpeg does not return.

Of  all those returned Kodi is only using ARTIST, TITLE, TRACK and GENRE (not STYLE, COMMENT and mbid tags which would be used from other tag formats). What Kodi expects to be returned is taken from ffmpeg code https://github.com/xbmc/FFmpeg/blob/mast...d3v2.c#L43,  if ffmpeg will return more tags than that  then it is easy to add to Kodi for that once it is clear what ffmpeg returns.

The main issue is the missing ALBUM,  ALBUMARTIST and YEAR values. The fault may lie with Mp3tag adding that tag in the wrong way, or in ffmpeg for not reading it, but it is not something that can be fixed in Kodi itself.

Is there a Matroska tagging standard to refer to? In ffmpeg it reads like it is using ID3v2, but the key names it returned are not e.g. PUBLISHER not TPUB. Anyway I'm afraid I don't have time to poke around ffmpeg code (Kodi is enough!) but it is open source so maybe have a look yourself or raise the question on their forums. Tell me what ffmpeg returns and I'll handle the Kodi side of it.

As for the gapless/passthrough issues, I hope we can attract the attention of a player expert. The example files will help, and maybe rsie an issue on Git
Reply
#23
Thanks Dave.

I will have a look at Matroska and Ffmpeg info and let you know what I find.
Reply
#24
(2019-07-01, 09:40)DaveBlake Wrote: Is there a Matroska tagging standard to refer to?

There is this https://matroska.org/technical/specs/tagging/index.html
Reply
#25
To get TrueHD/Atmos passthrough in music player (paplayer) working should simply be copying https://github.com/xbmc/xbmc/blob/master...#L363-L366

into this block of code https://github.com/xbmc/xbmc/blob/master...#L501-L519

Following what fristch did for DTS-HD in 16027 (PR)

If nobody else has the time, I can maybe raise the code change but it won't be before the weekend.
Reply
#26
(2019-07-01, 13:52)jjd-uk Wrote: To get TrueHD/Atmos passthrough in music player (paplayer) working should simply be copying https://github.com/xbmc/xbmc/blob/master...#L363-L366

into this block of code https://github.com/xbmc/xbmc/blob/master...#L501-L519

Following what fristch did for DTS-HD in 16027 (PR)

If nobody else has the time, I can maybe raise the code change but it won't be before the weekend.
Well that sounds easy enough @jjd-uk I'll give it a go, hope touching paplayer does not come back to bite me. I will need some test volunteers to verify as I have no way to test it myself.

EDIT:
Passthrough fix PR here 16336 (PR), and I will backport (if we decide to do 18.4). Can any of you test this actually works on your AVR system, if a test build is needed let me know and I'll kick one off. Without positive test feedback this won't get merged, and I am working "deaf".
Reply
#27
Meanwhile chatting to Spiff he confirmed that ffmpeg has issues with parsing Matroska tags, in particular it is not picking up the ALBUM tag.

@HomerJau in case you are interested he used mkvextract to look at the metadata,  output for a sample file is here https://pastebin.com/BRY957vW . ALBUM and TITLE tags are both <Name>TITLE</Name> in Matroska, but <TargetTypeValue> 50 is the album name , <TargetTypeValue>30 is the song title, and ffmpeg is not dealing with that.
Reply
#28
(2019-07-01, 17:04)DaveBlake Wrote: Meanwhile chatting to Spiff he confirmed that ffmpeg has issues with parsing Matroska tags, in particular it is not picking up the ALBUM tag.

@HomerJau in case you are interested he used mkvextract to look at the metadata,  output for a sample file is here https://pastebin.com/BRY957vW . ALBUM and TITLE tags are both <Name>TITLE</Name> in Matroska, but <TargetTypeValue> 50 is the album name , <TargetTypeValue>30 is the song title, and ffmpeg is not dealing with that.

I was looking at this last night. Both ffmpeg and MediaInfo don’t show anything from <TargetTypeValue> 50. This is used as the Album metadata node in the Matroska tagging spec. (album title, album artist and release date).

I guess it’s possible ffmpeg and MediInfo use the same codebase to read these tags since both miss the 50 node. They both need same fix.
Reply
#29
(2019-07-01, 15:19)DaveBlake Wrote:
(2019-07-01, 13:52)jjd-uk Wrote: To get TrueHD/Atmos passthrough in music player (paplayer) working should simply be copying https://github.com/xbmc/xbmc/blob/master...#L363-L366

into this block of code https://github.com/xbmc/xbmc/blob/master...#L501-L519

Following what fristch did for DTS-HD in 16027 (PR)

If nobody else has the time, I can maybe raise the code change but it won't be before the weekend.
Well that sounds easy enough @jjd-uk I'll give it a go, hope touching paplayer does not come back to bite me. I will need some test volunteers to verify as I have no way to test it myself.

EDIT:
Passthrough fix PR here 16336 (PR), and I will backport (if we decide to do 18.4). Can any of you test this actually works on your AVR system, if a test build is needed let me know and I'll kick one off. Without positive test feedback this won't get merged, and I am working "deaf".

I’m happy to do a test but will need a build. Will this get into the next Milhouse 19 alpha builds?
Reply
#30
Looks like it is
.
(2019-07-01, 23:01)Milhouse Wrote: New LibreELEC.tv Matrix build #0701: Generic
(Supercedes previous build)

SHA256 Checksum: 612097ed0af81c710948f3a6cd1578ce297cba813ce5a969db23e9ef2f258af6 (Generic)
  • Added: [pkg] PR:16336 (perma): Fix PAPlayer to do passthrough for TrueHD
Reply
 
Thread Rating:
  • 0 Vote(s) - 0 Average



Logout Mark Read Team Forum Stats Members Help
MKA file tagging support in Kodi?00