2014-02-22, 14:59
(2013-08-19, 08:52)pecinko Wrote:@pecinko mentioned what I was trying to explain on "Another issue:".(2013-08-19, 08:45)Martijn Wrote:(2013-08-19, 08:39)pecinko Wrote: If I go to widget settings and enable recommended does that setting gets saved when I leave widget setting window?
only if you click on OK. All the rest cancels the changes
OK, I am confirming every change made to widgets with OK button so I expect settings get saved. Still, widgets is not behaving as I described above it is ignoring all items already in DB and only starts to monitor future events.
Another issue:
You leave settings to default. Recommended window properties get populated with half watched items. You then turn off recommended in settings. Recommended window properties are not cleared (as we know) so I go reboot XBMC. Now they are and everything is good. Now, if I do library scan or cut watching a movie in half, recommended properties gets populating again, regardless the fact they are now turned off in widget settings?
Anyways I realized it's skin issue. I open new topic for this issue on @pecinko's quartz skin forum.
But I can suggest something else. I think on skin widgets _update definition you can some conditions (if statements). Because after XBMC Library Scan skin widget is trying to update everything regardless to check if some of the settings turned off (Recommended etc.).
Example of if conditions:
PHP Code:
def _update(self, type):
xbmc.sleep(1000)
if type == 'movie':
if __addon__.getSetting("recommended_enable") == 'true':
self._fetch_movies('RecommendedMovie')
if __addon__.getSetting("recentitems_enable") == 'true':
self._fetch_movies('RecentMovie')
elif type == 'episode':
if __addon__.getSetting("recommended_enable") == 'true':
self._fetch_tvshows_recommended('RecommendedEpisode')
if __addon__.getSetting("recentitems_enable") == 'true':
self._fetch_tvshows('RecentEpisode')
elif type == 'video':
#only on db update
if __addon__.getSetting("recommended_enable") == 'true':
self._fetch_movies('RecommendedMovie')
self._fetch_tvshows_recommended('RecommendedEpisode')
if __addon__.getSetting("recentitems_enable") == 'true':
self._fetch_movies('RecentMovie')
self._fetch_tvshows('RecentEpisode')
self._fetch_musicvideos('RecentMusicVideo')
elif type == 'music':
if __addon__.getSetting("recommended_enable") == 'true':
self._fetch_albums('RecommendedAlbum')
if __addon__.getSetting("recentitems_enable") == 'true':
self._fetch_albums('RecentAlbum')
if self.RANDOMITEMS_UPDATE_METHOD == 1:
if __addon__.getSetting("randomitems_enable") == 'true':
# update random if db update is selected instead of timer
if type == 'video':
self._fetch_movies('RandomMovie')
self._fetch_tvshows('RandomEpisode')
self._fetch_musicvideos('RandomMusicVideo')
elif type == 'music':
self._fetch_albums('RandomAlbum')
self._fetch_artists('RandomArtist')
self._fetch_songs('RandomSong')
self._fetch_addons('RandomAddon')