[robweber]

First of all i wanna thank you again for all your efforts on creating this Addon. Now about the testing results...

The testing was done with the script running at startup and with the "FanArt" property only.

PHP Code:

<onload>RunScript(script.grab.fanart,mode=random,mediatype=movies,refresh=10)</onload> 


PHP Code:

<control type="multiimage">
 ..................
  <imagepath background="true">$INFO[Window(Home).Property(script.grab.fanart.FanArt)]</imagepath>
 ..................
</control> 


Movies
- Random fanart is working fine.
- Recent fanart it doesn't work and it shows random Movies fanarts.
Looking at XBMC log file says that the script found the correct number of items which matches the total number of movies in the library. The number is the same with both of "mode" parameters (recent/random).

TV Shows
- Random fanart is working fine.
- Recent fanart it doesn't work and it shows random TV SHows fanarts.
Looking at XBMC log file says that the script found the correct number of items which matches the total number of TV Shows in the library if the "mode" parameter is set to "random". When the "mode" parameter is set to "recent" the log says that the script found 1000 of items, while the total number of TV Shows in the library is 38. Note that 1000 is the maximum number that i have set in my Advancedsettings.xml file for the Recently Added items in Video lIbrary.

Music
- Random fanart is working fine.
- Recent fanart it doesn't work and it doesn't shows anything.
Looking at XBMC log file says that the script found the correct number of items which matches the total number of Artist in the library if the "mode" parameter is set to "random". When the "mode" parameter is set to "recent" the log says that the script found 0 items while there are 178 Artists in my Music library.


General
- The script it doesn't update depending on the "mediatype" until you restart XBMC. This behavior is the same even if you change the "mediatype" from Addon's settings.
- When the script is starts it fills the XBMC log with the title names of all fanarts the it finds. That means that if have e.g 1000+ movies in your library, at some point you will have 1000+ entry's in the log file.


Let me know if you need a full debug log.


Suggestions
- IMHO the addon doesn't need to have any settings. They will confuse users if the skinners they set the properties.
- I know that this addon has gone more far away and offers more than we ask for, but it will be nice if we could use the script more than one time with a different "mediatype" property in the same window. What i mean is run the script in some way which will give us the ability to use the window property's in some way like this...

Movies Fanart

PHP Code:

<control type="multiimage">
...................
  <imagepath background="true">$INFO[Window(Home).Property(script.grab.fanart.MoviesFanArt)]</imagepath>
 ..................
</control> 


TVShows Fanart

PHP Code:

<control type="multiimage">
 ..................
  <imagepath background="true">$INFO[Window(Home).Property(script.grab.fanart.TVShowsFanArt)]</imagepath>
 ..................
</control> 


Τhanks again for all your work.


Cheers
Nessus

Thanks for testing this further. I made some changes to fix what you were seeing, but please read my explanations below before testing again.

Recent VS Random:

I've fixed this to pull only 10 recent items as opposed to the tons it was pulling before. Please keep in mind though that this is still presenting a random item from within the "recent" items list. You will not see them sequentially as they were added. For TV Shows you'll get the fanart based on the RecentlyAddedEpisodes list. If you added a lot of the same show, there is a chance these will all be the same.

For the random mode it will pull in all the items of a given media type and display them randomly.

Logging:

All the logging you are seeing is not permanent, just meant to help in testing. I've flagged some of the more spammy entries with the "debug" flag so they only show up when debugging is enabled now.

Settings:

As a finished product I agree that it does not need user settings. For now though they are available as they make testing a lot easier!

Media Type:

I've removed the media type variable, it is no longer necessary. I've implemented the additional properties so at any time you can reference "Video, Movie, TV, or Music" and get a valid entry. See the README for the exact property names. Also, now that there are specific movie, tv, music settings we can include more specific properties if skinners would like them. I'm thinking Episode Names and things like that.

Quick note for anyone testing this. For the most "slideshow-like" experience the random mode using the Video.Fanart property is probably the best choice. This will display fanart for all scanned TV/Movies as a random slideshow.