2017-03-08, 06:50
Just a quick bump with some minor insights.
I don't understand why the code doesn't use replaygain when peak is less than 1. I mean if the entire point was to use kodi's clipping code, well a peak of less than 1 shouldn't clip anyway.
If SetAmplification(gain) is a function that merely adjusts the output stream by "gain", leaving the clipping detection to the audio engine, then clearly it isn't working correctly, or it's getting "gain" from somewhere that isn't the replaygain gain tags in the files.
Removing or adjusting peak tags to 1 is not a good idea. Other players do make use of these values for their clipping prevention.
Couldn't both implementations of gain adjustment be included in the options with a toggle in expert mode? I mean the main purpose of replaygain isn't to prevent clipping, it's to get all tracks to a reference volume.
I don't understand why the code doesn't use replaygain when peak is less than 1. I mean if the entire point was to use kodi's clipping code, well a peak of less than 1 shouldn't clip anyway.
If SetAmplification(gain) is a function that merely adjusts the output stream by "gain", leaving the clipping detection to the audio engine, then clearly it isn't working correctly, or it's getting "gain" from somewhere that isn't the replaygain gain tags in the files.
Removing or adjusting peak tags to 1 is not a good idea. Other players do make use of these values for their clipping prevention.
Couldn't both implementations of gain adjustment be included in the options with a toggle in expert mode? I mean the main purpose of replaygain isn't to prevent clipping, it's to get all tracks to a reference volume.
