2018-03-15, 19:29
I think Neil refers to P_VPU_HDMI_FMT_CTRL, which is used to control rounding and dithering. As you can see from [1] the values are different for GXL and GXM.
Both S912 and S905x will obviously engage 10-8bit dithering when CD is < 10-bit.
12-10 bit dithering is used on S912, but not on S905x. It's unknown if this works properly yet.
We fixed flickering but now we get banding. I have added [2] so we can now poke the regs during playback and see how we can improve this.
With [3], we should also now be able to decouple the colour space and HDR output (which has been a mistake from AMLogic for some time).
We have to poke at some of this because the docs either aren't there; or contradict some of our experiences.
[1] https://github.com/osmc/vero3-linux/blob...hw.c#L1975
[2] https://github.com/osmc/vero3-linux/comm...f273aec6b6
[3] https://github.com/osmc/vero3-linux/comm...2524149d29
Both S912 and S905x will obviously engage 10-8bit dithering when CD is < 10-bit.
12-10 bit dithering is used on S912, but not on S905x. It's unknown if this works properly yet.
We fixed flickering but now we get banding. I have added [2] so we can now poke the regs during playback and see how we can improve this.
With [3], we should also now be able to decouple the colour space and HDR output (which has been a mistake from AMLogic for some time).
We have to poke at some of this because the docs either aren't there; or contradict some of our experiences.
[1] https://github.com/osmc/vero3-linux/blob...hw.c#L1975
[2] https://github.com/osmc/vero3-linux/comm...f273aec6b6
[3] https://github.com/osmc/vero3-linux/comm...2524149d29
