2017-05-04, 13:59
Hello,
I have a question for DaveTBlake if he doesn't mind. I'm still struggling to implement replaygain for dsf files.
In the patch I've submitted, Krypton: add replaygain to dsf files #12049, you've pointed out that I should not make TagLoaderTaglib dependant on FFmpeg tag loader. So here's my issue: the only call to FFmpeg tag loader when encountering a dsf file lies in MusicInfoTagLoaderFactory. But from my tests, it seems TagLoaderTaglib is called instead of the FFmpeg tag loader when reading a DSF file. Is that normal behaviour or am I missing something? Shouldn't MusicInfoTagLoaderFactory points to the correct tag loader while scanning and reading music files? (for scanning no issue, FFmpeg tag loader is correctly used)
Taglib hasn't implemented dsf files yet, so I can't call Taglib library to treat dsf files within TagLoaderTaglib like for instance Flac files. Hence my workaround to call FFmpeg tag loader within TagLoaderTaglib.
I have a question for DaveTBlake if he doesn't mind. I'm still struggling to implement replaygain for dsf files.
In the patch I've submitted, Krypton: add replaygain to dsf files #12049, you've pointed out that I should not make TagLoaderTaglib dependant on FFmpeg tag loader. So here's my issue: the only call to FFmpeg tag loader when encountering a dsf file lies in MusicInfoTagLoaderFactory. But from my tests, it seems TagLoaderTaglib is called instead of the FFmpeg tag loader when reading a DSF file. Is that normal behaviour or am I missing something? Shouldn't MusicInfoTagLoaderFactory points to the correct tag loader while scanning and reading music files? (for scanning no issue, FFmpeg tag loader is correctly used)
Taglib hasn't implemented dsf files yet, so I can't call Taglib library to treat dsf files within TagLoaderTaglib like for instance Flac files. Hence my workaround to call FFmpeg tag loader within TagLoaderTaglib.
