v18 issues with DSF files
#8
(2019-02-06, 21:59)HomerJau Wrote:
(2018-02-21, 15:51)DaveBlake Wrote: With DSF format music files the tag reading is done by ffmpeg, and that is limited on what tags it processes compared to TagLib that is used for other file formats. I don't have any DSF files myself, so I have never tested this or looked deeply at it, but I strongly suspect that you are just seeing internal limits not that you have done anything wrong.

To be honest FLAC does everything I need for quality sound, dare I suggest convert to FLAC Tongue

OK, have looked at the ffmpeg code (a separate project from Kodi but also opensource) and https://github.com/xbmc/FFmpeg/blob/mast...at/id3v2.c it does not support "custom" (non standard ID3v2) tags such as the Musicbrainz id ones. It does have a read comment facility (COMM tag) but that isn't called by CMusicInfoTagLoaderFFmpeg::Load, probably something that could be added. I'll have a chat with the guy that did the ffmpeg tag loader DSF stuff when he gets back off holiday (sorry, but I am just not over enthusiastic about support for yet more music file formats).

Hi Dave,

Based on latest TabLib github comments DSD tagging is now supported with TagLib (checked in 3 months ago). Is there much work involved in getting latest TagLib version into Kodi (if not already done) and to implement DSF tag reading in Kodi?

THX
Garry

That might also be a question to @spiff as changes maybe required in the sacd addon as well.

For reference this appears to be the PR that added support to Taglib https://github.com/taglib/taglib/pull/878

However it looks like they haven't actually tagged a new release of taglib since that went in so any update may have to wait until they do.
Reply


Messages In This Thread
issues with DSF files - by nesys - 2018-02-20, 17:23
RE: issues with DSF files - by DaveBlake - 2018-02-21, 15:51
RE: issues with DSF files - by HomerJau - 2019-02-06, 21:59
RE: issues with DSF files - by jjd-uk - 2019-02-07, 14:56
RE: issues with DSF files - by HomerJau - 2018-02-21, 22:27
RE: issues with DSF files - by DaveBlake - 2018-02-22, 10:26
RE: issues with DSF files - by HomerJau - 2018-02-23, 09:55
RE: issues with DSF files - by DaveBlake - 2018-02-23, 10:10
RE: issues with DSF files - by spiff - 2019-02-08, 13:53
RE: issues with DSF files - by HomerJau - 2019-02-09, 01:23
RE: issues with DSF files - by DaveBlake - 2019-02-11, 12:06
RE: issues with DSF files - by gnm67 - 2019-03-15, 17:27
RE: issues with DSF files - by gnm67 - 2019-03-15, 20:20
RE: issues with DSF files - by HeresJohnny - 2019-03-16, 17:23
RE: issues with DSF files - by HeresJohnny - 2020-06-27, 17:03
Logout Mark Read Team Forum Stats Members Help
issues with DSF files0