Hello amet,
hope I'm posting to the appropriate thread. I'm "RedjV" on GitHub, the user that sent to you two commits for french translation
.
Here are small issues I'd like to help fixing in the near future:
----------------------------------------------------------------------------------------------------
1. Make localizable some english texts that are hardcoded
There is a little number of hardcoded english texts in the add-on:
a. in settings.xml (strings like "Napiprojekt.pl (Polish/English subs only)" )
b. in a few libs for subtitles services (using msg() or return string, for exemple LegendasDivx/service.py lines 125, 271)
2. Ordering of the list of languages, when localized
The order of the languages, in the add-on settings, is hardcoded in settings.xml, based on alphabetical order for those languages'
names written in english. But once localized, the languages names may change a lot, and then the list can be misordered.
For exemple, in french, "Korean" is written "Coreen", "Dutch" is called "Neerlandais", "Farsi" = "Persan", etc (+accents).
----------------------------------------------------------------------------------------------------
My Questions:
=> As xbmc and its add-ons will migrate soon to a new localization method (if I understand correctly), maybe it's better to wait before trying to fix those issues ?
=> About issue 2., I wonder how it can be fixed, as I guess there's no dynamic mecanism for treating that XML file. Do you have an idea ?
Another question about adding new subtitle service
=> Are there guidelines/rules to follow, in order to contribute code for adding a provider ?
Thank you for your help
My best regards, and thank you for that great add-on !
Regis.