• 1
  • 3
  • 4
  • 5(current)
  • 6
  • 7
  • 13
Release 2D Spectrum, visualization
#61
if anyone wants to try this without relying on an entire kodi branch; https://github.com/notspiff/visualization.shadertoy is the add-on done as an add-on...

- syncronized with 0a1026e
- in addition to the buildsystem fix,
- it gets rid of the SDL2 dependency used only for timing by using the platform library (when i think a bit further it might need adjusting for the split of the platform library done by upstream).
- it gets rid of deprecated char* usage (they should be const!)
- adds necessary includes (sstream, fstream).
Reply
#62
Awesome. May I ask a stupid question. Can I compile and load that in upstream xbmc or are you using some functions you have added? I'm terribly noobie on addons Smile

If so I might just fork yours and continue from it instead of doing it in kodi src.
If you have problems please read this before posting

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.

Image

"Well Im gonna download the code and look at it a bit but I'm certainly not a really good C/C++ programer but I'd help as much as I can, I mostly write in C#."
Reply
#63
Now we are talking Wink
Reply
#64
(2015-05-05, 19:29)topfs2 Wrote: Awesome. May I ask a stupid question. Can I compile and load that in upstream xbmc or are you using some functions you have added? I'm terribly noobie on addons Smile

If so I might just fork yours and continue from it instead of doing it in kodi src.

Compile and install it and select it in addons. Smile

Great job you two.
Reply
#65
Can someone post a compiled version of it please?
Reply
#66
(2015-05-05, 15:14)ironic_monkey Wrote: if anyone wants to try this without relying on an entire kodi branch; https://github.com/notspiff/visualization.shadertoy is the add-on done as an add-on...

- syncronized with 0a1026e
- in addition to the buildsystem fix,
- it gets rid of the SDL2 dependency used only for timing by using the platform library (when i think a bit further it might need adjusting for the split of the platform library done by upstream).
- it gets rid of deprecated char* usage (they should be const!)
- adds necessary includes (sstream, fstream).

mmm this is what I get.

Code:
/home/setup/kodi-git/vis/src/main.cpp:29:33: fatal error: kodi/util/timeutils.h: No such file or directory
#include "kodi/util/timeutils.h"
                                 ^
compilation terminated.
make[2]: *** [CMakeFiles/visualization.shadertoy.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/visualization.shadertoy.dir/all] Error 2
make: *** [all] Error 2
[/code]
Reply
#67
it's entirely upstream-able. that ^^ is what i referred to with the platform changes, i'll sync to those once the mess settle.
Reply
#68
upstreamable but uncompilable unless I miss something.

https://github.com/notspiff/visualizatio...in.cpp#L29

That should probably be

Code:
#include "xbmc/util/timeutils.h"

Since upstream havent changed xbmc -> kodi in this aspect yet.

edit...

nope, cant compile it even with that change get same error.
Reply
#69
That should probably be

Code:
#include "xbmc/utils/timeutils.h"


Note the S in utils...
Reply
#70
nope. if you guys just read what i write, it will all make sense. timeutil now sits in libplatform, and needs to be included as platform/util/timeutils.h. but the buildsystem doesnt pull in libplatform in any case.
Reply
#71
(2015-05-05, 22:17)stourwalk Wrote: That should probably be

Code:
#include "xbmc/utils/timeutils.h"


Note the S in utils...

No, https://github.com/xbmc/xbmc/blob/master...imeUtils.h

@notspiff

So once https://github.com/xbmc/xbmc/pull/7069 is merged then or pull that in ontop of mater then pull your shadertoy git and should work, if I read you right.
Reply
#72
yes, that + i need to adjust the buildsystem after that hits.
Reply
#73
this is an addon. sources in the main kodi git are irrelevant apart from the headers defining the API.
Reply
#74
(2015-05-05, 22:32)uNiversal Wrote:
(2015-05-05, 22:17)stourwalk Wrote: That should probably be

Code:
#include "xbmc/utils/timeutils.h"


Note the S in utils...

No, https://github.com/xbmc/xbmc/blob/master...imeUtils.h

@Universal

I'm not a C coder but surely

Code:
#include "xbmc/util/timeutils.h"

refers a directory 'util' that doesn't exist and

Code:
#include "xbmc/utils/timeutils.h"

refers to one that does - and is even listed in your link?

Apologies if there is a completely different xbmc/util/timeutils.h that exists somewhere that I can't see.. unless you're original quoted code was a typo of course - in which case it's obviously irrelevant..
Reply
#75
https://github.com/xbmc/kodi-platform <- that USED to have that file and still does in my fork.
upstream split it in two libraries, https://github.com/Pulse-Eight/platform and https://github.com/xbmc/kodi-platform
Reply
  • 1
  • 3
  • 4
  • 5(current)
  • 6
  • 7
  • 13

Logout Mark Read Team Forum Stats Members Help
2D Spectrum, visualization0