Posts: 1,506
Joined: Nov 2013
if anyone wants to try this without relying on an entire kodi branch;
https://github.com/notspiff/visualization.shadertoy is the add-on done as an add-on...
- syncronized with 0a1026e
- in addition to the buildsystem fix,
- it gets rid of the SDL2 dependency used only for timing by using the platform library (when i think a bit further it might need adjusting for the split of the platform library done by upstream).
- it gets rid of deprecated char* usage (they should be const!)
- adds necessary includes (sstream, fstream).
Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
2015-05-05, 20:03
(This post was last modified: 2015-05-05, 20:04 by un1versal.)
(2015-05-05, 19:29)topfs2 Wrote: Awesome. May I ask a stupid question. Can I compile and load that in upstream xbmc or are you using some functions you have added? I'm terribly noobie on addons
If so I might just fork yours and continue from it instead of doing it in kodi src.
Compile and install it and select it in addons.
Great job you two.
Posts: 4,058
Joined: Oct 2007
Reputation:
89
zag
Team-Kodi Member
Posts: 4,058
Can someone post a compiled version of it please?
Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
(2015-05-05, 15:14)ironic_monkey Wrote: if anyone wants to try this without relying on an entire kodi branch; https://github.com/notspiff/visualization.shadertoy is the add-on done as an add-on...
- syncronized with 0a1026e
- in addition to the buildsystem fix,
- it gets rid of the SDL2 dependency used only for timing by using the platform library (when i think a bit further it might need adjusting for the split of the platform library done by upstream).
- it gets rid of deprecated char* usage (they should be const!)
- adds necessary includes (sstream, fstream).
mmm this is what I get.
Code:
/home/setup/kodi-git/vis/src/main.cpp:29:33: fatal error: kodi/util/timeutils.h: No such file or directory
#include "kodi/util/timeutils.h"
^
compilation terminated.
make[2]: *** [CMakeFiles/visualization.shadertoy.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/visualization.shadertoy.dir/all] Error 2
make: *** [all] Error 2
[/code]
Posts: 1,506
Joined: Nov 2013
it's entirely upstream-able. that ^^ is what i referred to with the platform changes, i'll sync to those once the mess settle.
Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
2015-05-05, 21:34
(This post was last modified: 2015-05-05, 21:42 by un1versal.)
upstreamable but uncompilable unless I miss something.
https://github.com/notspiff/visualizatio...in.cpp#L29
That should probably be
Code:
#include "xbmc/util/timeutils.h"
Since upstream havent changed xbmc -> kodi in this aspect yet.
edit...
nope, cant compile it even with that change get same error.
Posts: 1,506
Joined: Nov 2013
2015-05-05, 22:25
(This post was last modified: 2015-05-05, 22:26 by ironic_monkey.)
nope. if you guys just read what i write, it will all make sense. timeutil now sits in libplatform, and needs to be included as platform/util/timeutils.h. but the buildsystem doesnt pull in libplatform in any case.
Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
2015-05-05, 22:32
(This post was last modified: 2015-05-05, 22:35 by un1versal.)
(2015-05-05, 22:17)stourwalk Wrote: That should probably be
Code:
#include "xbmc/utils/timeutils.h"
Note the S in utils...
No,
https://github.com/xbmc/xbmc/blob/master...imeUtils.h
@notspiff
So once
https://github.com/xbmc/xbmc/pull/7069 is merged then or pull that in ontop of mater then pull your shadertoy git and should work, if I read you right.
Posts: 1,506
Joined: Nov 2013
yes, that + i need to adjust the buildsystem after that hits.
Posts: 1,506
Joined: Nov 2013
this is an addon. sources in the main kodi git are irrelevant apart from the headers defining the API.
Posts: 1,506
Joined: Nov 2013