[nhunt80]

In the next update that you push with the audio patch applied, can you also add a manual entry (in MB) for the Temporary Download Folder Size? This would enable those with larger storage devices to have a larger cache of games for offline use. It's especially useful for the games that are CD images that take up much larger amounts of space.

[zachmorris]

On another note, I haven't used IARL long enough yet to see what happens when an update is pushed in the repo, but I did notice someone in this thread mentioning that all of the external launcher cmd specifications for each rom section in IARL are reset and blanked out upon an addon update. If you can make it so that IARL saves all settings to a seperate config file that remains unaffected by addon updates, then this addon will be 100% complete as far as issues are concerned.

Again great job on this amazing addon!

Alright, good that the fix works. I'll have to look into seeing if this should be configurable or not, I'm not sure what happens in the case where the user calls a script and shuts down Kodi (if audio remains suspended after Kodi restarts or not).

The user data is #1 on my list of things to fix. In the next update I'll fix it so that this no longer happens (data will be saved to the userdata folder), but prior to that, any update that occurs will wipe your data and settings. Just ensure you back up your xml files for now.

[Shinoby92]

can i somehow help for fixing android external launch xd

can't you just look in how rom collection browser does launch external games, or is it too much figure out how the code works

i reallly think that rom collection browser is somehow else using the launch commands, i think just adding in front of launch commands that the system should launch them in folder xx/xx/ doesn't work

[zachmorris]

In the next update that you push with the audio patch applied, can you also add a manual entry (in MB) for the Temporary Download Folder Size? This would enable those with larger storage devices to have a larger cache of games for offline use. It's especially useful for the games that are CD images that take up much larger amounts of space.

I'll add a few more size options, say up to 20GB. Anything larger than that, you might want to think about changing the download location for each archive to manage the files, which provides essentially no limit (it's up to the user to manage the files in an alternate download folder).

[zachmorris]

can i somehow help for fixing android external launch xd

can't you just look in how rom collection browser does launch external games, or is it too much figure out how the code works

i reallly think that rom collection browser is somehow else using the launch commands, i think just adding in front of launch commands that the system should launch them in folder xx/xx/ doesn't work

Android launching is the bain of my existence right now. The launch commands in the addon were taken directly from RCB. I can't figure it out, and without an Android machine I'm basically stuck. There is of course a manual option to put in whatever command you like to launch, so if someone figures this out, please let me know!

For those technically inclined, the addon calls an external command with the code here:

Code:

external_command = subprocess.call(current_external_command,shell=True)

The addon takes the selected external launch command from this database, replaces the ROM_PATH with the actual path to the file, and then executes the subprocess call. Again, this is pretty close to what Advanced Launcher and RCB do, so I think the code is not to far off, but obviously still incorrect. Sorry about that... Thats what you get when you're dealing with a programmer who's learning as he goes

[int13h]

I love this add-on.

Congratulations for the idea and realisation.

I used this add-on for quite some time on Windows/Intel NUC/Kodi 14.
Now I'm using OpenElec on a Raspi2 and Kodi 15 : I'll see if it still works. Well, I hope it will.

Anyway, I'm glad you'll fix the lost of settings after every upgrade, it was quite irritating.
Specifically with the ever-growing number of systems/best-of collections/etc...

Well done Zach !

[Shinoby92]

can i somehow help for fixing android external launch xd

can't you just look in how rom collection browser does launch external games, or is it too much figure out how the code works

i reallly think that rom collection browser is somehow else using the launch commands, i think just adding in front of launch commands that the system should launch them in folder xx/xx/ doesn't work

Android launching is the bain of my existence right now. The launch commands in the addon were taken directly from RCB. I can't figure it out, and without an Android machine I'm basically stuck. There is of course a manual option to put in whatever command you like to launch, so if someone figures this out, please let me know!

For those technically inclined, the addon calls an external command with the code here:

Code:

external_command = subprocess.call(current_external_command,shell=True)

The addon takes the selected external launch command from this database, replaces the ROM_PATH with the actual path to the file, and then executes the subprocess call. Again, this is pretty close to what Advanced Launcher and RCB do, so I think the code is not to far off, but obviously still incorrect. Sorry about that... Thats what you get when you're dealing with a programmer who's learning as he goes

Here some informations that you can maybe use...-> i tried it myself and i couldnt do anything ...

https://pymotw.com/2/subprocess/

http://forums.tvaddons.ag/kodi-for-andro...ators.html

Code:

if(romCollection.usePopen):
        import subprocess
        subprocess.Popen(cmd.encode('utf-8'), shell=True)
    else:
        os.system(cmd.encode('utf-8'))

<- Seems like in rom collection browser the subprocess is using -> .Popen and the command is getting encoded? maybe that is the issue what has to be done before launch?

[zachmorris]

Update to version 1.4.0:
- Added audio pausing for external launching, fixes HDMI output for some machines when Retroarch is launched
- Fixed IARL skin issue when using Retroplayer. When selecting a game there was a "double tap", closing game window inadvertently.
- Changed location of xml files from addondata to userdata. This will fix erasing user settings from here on out :-)
- Added functions to check for new xml files when add-on is updated. If a new version of the XML is available, the addon will ask the user if they want to overwrite their old one (along with the settings).
- Fixed bug in adding Favorites (poorly formatted XML in some cases)
- Added additional emulator launchers for Kodibuntu/Linux (thanks lefty420)
- Added additional settings for larger cache folder size
- Rescraped Sega Master System (391 Games Filtered, 544 Games Unfiltered)
- Rescraped TG16 (345 Games Filtered, 419 Games Unfiltered)
- Added best of PS1
- Added best of MAME/Arcade

[lefty420]

Excellent work as usual Zack

[bakito]

Yes indeed!!
Thanks!

[int13h]

Thank you for the addondata/userdata migration

[zachmorris]

I put up a new version on Github as a test release (must be installed by zip currently)

After talking with Malte (RCB Addon owner) and doing a little more research, it seems that android is the odd one out of the bunch and use of the system commands I was using isn't quite working (more here if anyone cares in the future, it's an issue with python not having the correct paths to shell if I read that correctly)

So, I added some additional code to hopefully get android launching working, but I need some testers. Please check it out and report back (ensure you follow the instructions for setting up external launching).

This may or may not work. If it doesn't the external launch commands for android may have to be changed from (BSNES as an example):

Code:

/system/bin/am start --user 0 -a android.intent.action.MAIN -c android.intent.category.LAUNCHER -e ROM "%ROM_PATH%" -e LIBRETRO /data/data/com.retroarch/cores/bsnes_performance_libretro_android.so -e CONFIGFILE /data/data/com.retroarch/retroarch.cfg -e IME com.android.inputmethod.latin/.LatinIME -n com.retroarch/.browser.retroactivity.RetroActivityFuture

to

Code:

am start --user 0 -a android.intent.action.MAIN -c android.intent.category.LAUNCHER -e ROM "%ROM_PATH%" -e LIBRETRO /data/data/com.retroarch/cores/bsnes_performance_libretro_android.so -e CONFIGFILE /data/data/com.retroarch/retroarch.cfg -e IME com.android.inputmethod.latin/.LatinIME -n com.retroarch/.browser.retroactivity.RetroActivityFuture

I think the first will work, but I'm not sure.

[Shinoby92]

Im gladly telling you it works :-)!!!! with the first one, so ecsactly like you uploaded in the zip file.

Just one question is, can i somehow save my settings. I mean -> N64 starting emulator xxx and after download unzip etc.
somewhere to save these settings or do i have to everytime do these things when changing emulators

[ghizzu]

And it works here too (Minix X7)

[zachmorris]

Thats excellent news Thanks for reporting back. I'll push those changes along with some others to the repo.