[JohnPlayerSpecial]

Code:

SSL: certificate subject name 'NAS326' does not match target host name 'kpbsfsffe0nsfd.myfritz.net'

you're NAS cert doesn't match it's host name   

Yes, it's behind my Router (Fritzbox=kpbsfsffe0nsfd.myfritz.net) on port 5003.

Here a log from older Coreelec build before changes in Kodi: https://pastebin.com/raw/bySDKDjW

This works fine like all other builds in the past! I did not change anything, older builds or Android Es File Explorer can access it without problems.

[Rechi]

Fix your certificate.
While I see the use case for self signed certificates which can now be used by explicitly adding '|verifypeer=false' to the url, I don't see a reason to allow disabling Common Name field and a Subject Alternate Name checking.
It worked fine with earlier builds because verifyhost was disabled too.

[JohnPlayerSpecial]

Ah, thanks for your support guys! After heureka-moment and recognizing what to do I renewed my self signed cert with correct host name and voilà - your patch works! <3

PS As little improvement maybe consider a setting option in kodi under "add network connection.."-menu, at least wiki. People dont know about manually setting ' |verifypeer=false' .

[JohnPlayerSpecial]

https://github.com/xbmc/xbmc/pull/13909 does not work for at all. You can access through |verifypeer=false, but it comes to problems with the library. Adding entries first and playing/accessing the files generally works, but:

when "Cleaning Up" my library the source is unaivailable for Kodi (ERROR: CCurlFile::Stat - Failed: HTTP response code said error(22) ) and deletes movies from the source. Firstly adding files worked so far despite of error in log, but cleaning up deletes it all again because source is recognized as unavailable during cleaning process.
log: https://pastebin.com/raw/czpRv4wq
Tested on fresh KodiSetup-20180609-5da94d19-master-x64.exe and CoreELEC-Odroid_C2.arm-8.90.3.img.gz (Older builds still workes fine (before ' |verifypeer=false' ), I tested this again to exclude problems of my server or network)

[Doktor-X]

On coreelec/libreelec adding |verifypeer=false to my ftps source is not working

[JohnPlayerSpecial]

On coreelec/libreelec adding |verifypeer=false to my ftps source is not working

Do you use a build where it's merged? And pls provide a log, I need this thing to work in future :-D

[Doktor-X]

Coreelec changelog
Features
updated to LibreELEC/master (06/06/18)
OSMC 19 Amlogic 3.14 kernel base *

Log
https://paste.ubuntu.com/p/7Vz7ryvcZP/

[JohnPlayerSpecial]

Cannot work ftps://USERNAME:PASSWORD@HOSTNAME:9999/_/|_verifypeer=false, must be ftps://USERNAME:PASSWORD@HOSTNAME:9999/|verifypeer=false

This is why I hoped for a checkbox-option. Pls report if it works after changing this and maybe you can also try out adding and cleaning a library entry from this source, where I see the extant problems.

[Doktor-X]

No, its not working, i have desided to make signed certificate with site zerossl.com and add this cert and key to my filezilla server and now its working

[yol]

when "Cleaning Up" my library the source is unaivailable for Kodi (ERROR: CCurlFile::Stat - Failed: HTTP response code said error(22) ) and deletes movies from the source. Firstly adding files worked so far despite of error in log, but cleaning up deletes it all again because source is recognized as unavailable during cleaning process.

Can you look at the logs of your webserver? That error code means that your server returned an HTTP error code >= 400, so I'm not sure what the connection to the certificate problem is.  Would help to see what exactly is going on.

[yol]

Can you try https://github.com/xbmc/xbmc/pull/14016 ?

[JohnPlayerSpecial]

Can you try https://github.com/xbmc/xbmc/pull/14016 ?

 I tried, but it's not merged here KodiSetup-20180610-1182314e-master-x64.exe for Win64, isn't it? It's still the same behavior HTTP response code said error(22) - adding and playing the file works, but cleaning up library deletes the movie again https://pastebin.com/raw/hRLyiDmh

Btw:
CE 8.90.3 named another error but in the end its just the same behavior - accessing through -verifypeer is first possible, but when cleaning up library source is unavailable:
15:28:58.679 T:3979334512 ERROR: CCurlFile::Exists - Failed: Timeout was reached(28) for davs://USERNAME[email protected]/webdav/nas2/HD/Am%20Borsigplatz%20geboren%20-%20Franz%20Jacobi%20und%20die%20Wiege%20des%20BVB%20(2015)/Am%20Borsigplatz%20geboren%20-%20Franz%20Jacobi%20und%20die%20Wiege%20des%20BVB-fanart.jpg|verifypeer=false
15:29:02.948 T:4096308016 ERROR: CGUIMediaWindow::GetDirectory(davs://USERNAME[email protected]:5003/webdav/nas2/|verifypeer=false) failed
15:30:12.365 T:4096308016 NOTICE: CleanDatabase: Starting videodatabase cleanup .. (<- Now Kodi asks for deleting or remaining the files from this source)

I will try to find a log from my server, if there is one, but Im not very familiar with linux/my zyxel nas. I hope I can find one. But what I can ensure: In the past I updated and cleaned up my library very often and it still works fine today with CE 8.90.1 on my Odroid, also under LE (another older build) on a 905 AML Box, but this was before -verifypeer was merged. But I dont know if this is the only reason, I only marked this as a difference from older Kodi versions.

[yol]

I'm guessing that the HTTP errors are actually unrelated.
 

I tried, but it's not merged here KodiSetup-20180610-1182314e-master-x64.exe for Win64, isn't it?

No, since I'm not sure yet whether it'll work. Please try http://mirrors.kodi.tv/test-builds/windo...ge-x64.exe

[JohnPlayerSpecial]

I'm guessing that the HTTP errors are actually unrelated.
 

I tried, but it's not merged here KodiSetup-20180610-1182314e-master-x64.exe for Win64, isn't it?

No, since I'm not sure yet whether it'll work. Please try http://mirrors.kodi.tv/test-builds/windo...ge-x64.exe 

 It works partly. I added a webdavs source with verifypeer=false and now cleaning the library not delete them. But as a test I really delete a movie from source and cleaned again but this time the movie also stays. After that I manually delete this movie from the library and tried updating the library for re-adding, but Kodi does not add the movie again and talks about source would be unaivailable and asks for keeping or deleting files from this source. https://pastebin.com/raw/Ez7bR8zj 

I deleted the hole source completely and tried once again: This time only 49 of 59 movies were added. I cleaned, everything stays, ok. I deleted a movie from source and cleaned again and this time 48 movies remain, ok. I added the movie again to webdav and updated library but movie was not not added again, not ok. Still 48 movies instead of 49 (or 59 what it really would be).

Must be curios to read, but all I can say: older builds without verifypeer=false worked fine for me when doing clean up or updating my library. Do you have a clue what the problem is?

[JohnPlayerSpecial]

@yol
In the meantime I tried KodiSetup-20180522-7bc0f452-master-x64.exe from 2018-May-23. This is where [curl] add url option to disable peer verification #13909 first has been merged.

The problems are exactly the same here. Although I still not don't know if this PR really is the only problem, but I cannot do tests with +1 day older builds because they havent the option to disable peer verification and so I cannot connect to my webdavs in general.

This is why my Odroid still runs at CE 8.90.1 - 8.90.2 does not have the option |verifypeer=false and CE 8.90.3 on the other hand has this option, but with same problems like current windows nighlies since 2018-May-23.