Login at Kodi Home

Rantanplan-1 · (This post was last modified: 2018-09-30, 16:22 by Rantanplan-1.)

if a visualisation preset is locked (i.e. via Button id="501" in MusicOSD) "Visualisation.Locked" doesnt return "true".

testet with Milkdrop 1 & 2 on Windows.

**ksooo** · 2018-10-01, 14:04

(2018-09-30, 12:44)Rantanplan-1 Wrote: if a visualisation preset is locked (i.e. via Button id="501" in MusicOSD) "Visualisation.Locked" doesnt return "true".

testet with Milkdrop 1 & 2 on Windows.

You found a bug and I will fix it. Thanks for reporting this.

**ksooo** · 2018-10-01, 14:17

https://github.com/xbmc/xbmc/pull/14503 should fix this.

Rantanplan-1 · 2018-10-02, 07:36

Thnks !

**ksooo** · 2018-10-02, 08:06

(2018-10-02, 07:36)Rantanplan-1 Wrote: Thnks !

Have you runtime tested the fix? There is a guy on github stating it's not fixed but I'm not sure he understood what this fix is about. Can you confirm the fix working?

Rantanplan-1 · 2018-10-02, 08:42

Will test this evening

(latest nightly i guess)

**ksooo** · 2018-10-02, 08:42

(2018-10-02, 08:42)Rantanplan-1 Wrote: Will test this evening

(latest nightly i guess)

Thanks, yep, latest nightly.

Rantanplan-1 · 2018-10-02, 09:35

So, did give it a quick testrun and it works 50% Wink

Works for "Milkdrop"
bot fails in "Milkdropp2"

it looks like i can still lock and unlock Milkdrop2 preset, but still dont get a "true" from "Visualisation.Locked".

in Milkdrop its working.

**ksooo** · (This post was last modified: 2018-10-02, 09:38 by ksooo.)

(2018-10-02, 09:35)Rantanplan-1 Wrote: So, did give it a quick testrun and it works 50% [emoji6]

Works for "Milkdrop"
bot fails in "Milkdropp2"

it looks like i can still lock and unlock Milkdrop2 preset, but still dont get a "true" from "Visualisation.Locked".

in Milkdrop its working.

Okay, thanks for testing. Then it seems that my fix was just one piece of the puzzle and the milkdrop2 add-on needs a fix, too.

EDIT: fixing the add-on is not my job, thus I'm out for now.

Rantanplan-1 · 2018-10-02, 09:41

o.k. thnks

so guess gonna ask in the visualisation subforum as soon as i finde some time.

**ronie** · 2018-10-02, 10:16

@Rantanplan-1 there's a thread about the subject in the vis dev forum: https://forum.kodi.tv/showthread.php?tid...pid2779152

@afedchin in case you have some spare time can you take a look if something need to be adjusted on the addon side?

**spiff** · 2018-10-02, 11:38

fix submitted (untested, but trivial); https://github.com/afedchin/visualizatio...p2/pull/10

Rantanplan-1 · 2018-10-07, 06:01

(2018-10-02, 11:38)spiff Wrote: fix submitted (untested, but trivial); https://github.com/afedchin/visualizatio...p2/pull/10

thnx!

this fixed it. (tested with beta3)

---

only "issue" which is left over, is that as soon as i leave the Musicvisualisation Window, it isnt locked anymore. But guess thats by design, as then an other control thakes over to display the visualisation.