Login at Kodi Home

User 405025 · (This post was last modified: 2022-08-11, 15:25 by User 405025.)

Hi, @pkscout . The addon xml leads me here.

Ii got a big request.
- https://github.com/xbmc/metadata.tvshows...on/pull/82

After some research i found this scrapper, is the only one which writes the 'rating_type' for tmdb ratings as <tmdb>, all others i checked use the <themoviedb> as type.

The issue is (at least for me, maybe other skinners ) when it comes to skinning.It surely depends how ratings can / are be skinned, but
i also thought the naming sheme for the same rating_type, should be "unique" and not differ from scraper to scraper.

So, i checked most of the default scrappers (same 1 movie - 3 scrappers, same 3 tvshows - 2 scrappers )

- themoviedb metadata.common.themoviedb.org
- themoviedb metadata.movies.thetvdb.com.v4.python
- themoviedb metadata.themoviedb.org.python

- themoviedb metadata.tvshows.themoviedb.org
- tmdb : metadata.tvshows.themoviedb.org.python

So, it is more a friendly request / wish to get a unique naming sheme for this.
Would be nice if it found some relevance.

Have a nice day Smile

**Karellen** · (This post was last modified: 2022-08-11, 22:55 by Karellen.)

(2022-08-11, 14:54)mardukL Wrote: - themoviedb metadata.common.themoviedb.org
- themoviedb metadata.movies.thetvdb.com.v4.python
- themoviedb metadata.themoviedb.org.python

- themoviedb metadata.tvshows.themoviedb.org
- tmdb : metadata.tvshows.themoviedb.org.python

I think you have made some mistakes there.

metadata.common.themoviedb.org - is not a scraper
metadata.movies.thetvdb.com.v4.python - is the scraper for TheTVDB not TMDB, so I doubt it is using themoviedb
metadata.themoviedb.org.python - uses tmdb (my library is full of it)

metadata.tvshows.themoviedb.org - no longer exists for v19 and later. I just tested this on v18.9 and it uses tmdb
metadata.tvshows.themoviedb.org.python - uses tmdb
Universal movie scraper - uses tmdb

Possibly you have an older library and you have leftover ID's?

But you are correct, there was a time when the ID's were mixed between using tmdb and themoviedb but they have been changed at some stage. Honestly I don't remember when they were changed. Possibly media managers are still using themoviedb?
As you have your db open, simply change the wrong entries. No harm done to the database.

fyi... https://github.com/xbmc/metadata.themovi.../issues/12

User 405025 · (This post was last modified: 2022-08-12, 07:45 by User 405025.)

(2022-08-11, 22:11)Karellen Wrote: I think you have made some mistakes there.

metadata.common.themoviedb.org - is not a scraper
metadata.movies.thetvdb.com.v4.python - is the scraper for TheTVDB not TMDB, so I doubt it is using themoviedb
metadata.themoviedb.org.python - uses tmdb (my library is full of it)

metadata.tvshows.themoviedb.org - no longer exists for v19 and later. I just tested this on v18.9 and it uses tmdb
metadata.tvshows.themoviedb.org.python - uses tmdb
Universal movie scraper - uses tmdb

Possibly you have an older library and you have leftover ID's?

But you are correct, there was a time when the ID's were mixed between using tmdb and themoviedb but they have been changed at some stage. Honestly I don't remember when they were changed. Possibly media managers are still using themoviedb?
As you have your db open, simply change the wrong entries. No harm done to the database.

fyi... https://github.com/xbmc/metadata.themovi.../issues/12

No, sorry no mistakes (at least in scraping and lookup the results), but i did the same test again.

txt:


2022-08-12 06:38:57.303 T:5724 INFO <general>: Starting Kodi (20.0-ALPHA1 (19.90.701) Git:20220706-c6ef0c3469). Platform: Windows NT x86 64-bit

2022-08-12 06:38:57.303 T:5724 INFO <general>: Using Release Kodi x64

2022-08-12 06:38:57.303 T:5724 INFO <general>: Kodi compiled 2022-07-07 by MSVC 192930143 for Windows NT x86 64-bit version 10.0 (0x0A000008)

2022-08-12 06:38:57.304 T:5724 INFO <general>: Running on Windows 11 21H2, kernel: Windows NT x86 64-bit version 10.0.22000.856

a) Folder structure

txt:
movies\tmdb\movie a (1994)

\tmdb_py\movie a (1994)

\tvdbv4\movie a (1994)

\universal\movie a (1994)



tvshows\tmdb\show a\1\*2episodes

\tmdb\show b\1\*2episodes

\tmdb\show c\1\*2episodes



\tmdb_py\show d\1\*2episodes

\tmdb_py\show e\1\*2episodes

b ) NO NFO PLACED ANYWHERE

RESULTS REMAIN AS LAST TEST YESTERDAY

txt:
movie

    universal                - themoviedb      - <addon id="metadata.universal" name="Universal Movie Scraper" version="5.5.10" provider-name="Olympia, Team Kodi">

    tvdbv4                  - none      (you're right)           - <addon id="metadata.movies.thetvdb.com.v4.python" name="The TVDB v4 (Movies)" version="1.0.10" provider-name="TVDB Team">

    tmdb python         - themoviedb      - <addon id="metadata.themoviedb.org.python" name="The Movie Database Python" version="1.6.2+matrix.1" provider-name="Team Kodi">

    tmdb                     - themoviedb     - <addon id="metadata.common.themoviedb.org" name="The Movie Database Scraper Library" version="3.2.18" provider-name="Team Kodi">

    

tvshow

    tmdb_py                - tmdb             - <addon id="metadata.tvshows.themoviedb.org.python" name="TMDb TV Shows" version="1.5.3" provider-name="Team Kodi">

    tmdb                     - themoviedb     - <addon id="metadata.tvshows.themoviedb.org" name="The Movie Database" version="3.5.14 "provider-name="Team Kodi">

So, may something went wrong by switch to unique naming sheme for tmdb ?
In the table for unique_id , the naming conentions is always tmdb

**Karellen** · (This post was last modified: 2022-08-13, 23:59 by Karellen.)

(2022-08-12, 07:28)mardukL Wrote: 2022-08-12 06:38:57.303 T:5724 INFO <general>: Starting Kodi (20.0-ALPHA1 (19.90.701) Git:20220706-c6ef0c3469). Platform: Windows NT x86 64-bit2022-08-12 06:38:57.303 T:5724 INFO <general>: Using Release Kodi x64
2022-08-12 06:38:57.303 T:5724 INFO <general>: Kodi compiled 2022-07-07 by MSVC 192930143 for Windows NT x86 64-bit version 10.0 (0x0A000008)
2022-08-12 06:38:57.304 T:5724 INFO <general>: Running on Windows 11 21H2, kernel: Windows NT x86 64-bit version 10.0.22000.856

Ok, you are using v20. I tested on v19.4

I tried on v20, and I still scrape tmdb. I have no themoviedb anywhere in my uniqueid table.

Here is my log. Search for <details><uniqueid and you should find scraping of uniqueid... https://paste.kodi.tv/odobuheguv.kodi

**Karellen** · (This post was last modified: 2022-08-14, 00:10 by Karellen.)

@mardukL I've split this into a new thread

@pkscout, @rmrector any thoughts?

**pkscout** · 2022-08-14, 12:42

If I remember correctly, The IDs I used were the ones being used by the other scrapers I looked at when building the TMDb TV Shows scraper. That would have been the TVMaze scraper and the TMDB Movies one. There doesn't seem to be any documentation I can find on the IDs, so it appears it's not really a standard as much as a common understanding. I could certainly *add* another ID that has 'themoviedb' and just duplicate the one labeled "tmdb," but it wouldn't really matter. You'll forever have to deal with the two IDs, as you have to rescrape to update those IDs. So anyone who ever used a scraper that saved the ID as 'themoviedb' will always have that in the database (and not 'tmdb'), and (assuming I did that) anyone who's using the current scraper won't have 'themoviedb' except for shows they scraped after the update.

User 405025

(2022-08-13, 23:57)Karellen Wrote:
(2022-08-12, 07:28)mardukL Wrote: 2022-08-12 06:38:57.303 T:5724 INFO <general>: Starting Kodi (20.0-ALPHA1 (19.90.701) Git:20220706-c6ef0c3469). Platform: Windows NT x86 64-bit2022-08-12 06:38:57.303 T:5724 INFO <general>: Using Release Kodi x64
2022-08-12 06:38:57.303 T:5724 INFO <general>: Kodi compiled 2022-07-07 by MSVC 192930143 for Windows NT x86 64-bit version 10.0 (0x0A000008)
2022-08-12 06:38:57.304 T:5724 INFO <general>: Running on Windows 11 21H2, kernel: Windows NT x86 64-bit version 10.0.22000.856
Ok, you are using v20. I tested on v19.4

I tried on v20, and I still scrape tmdb. I have no themoviedb anywhere in my uniqueid table.

Here is my log. Search for <details><uniqueid and you should find scraping of uniqueid... https://paste.kodi.tv/odobuheguv.kodi

i did a look, wondered how it not show up in your <rating_type> table as "themoviedb"

as metadata.themoviedb.org is using it.

there are (at quick look,) 5 scrapings using it.
best is search for "rating name="themoviedb" via strg+f

log:
ParseTMDBRatings returned <details><ratings><rating name="themoviedb" default="true"><value>5.928</value><votes>5171</votes></rating></ratings></details>

What i now just wonder is...
how will it be in future, is it so that the scrappers should move to a unique <rating_type> value for tmdb.org ratings, so it match the <unique_id> table values
or is this up to the maintainer of the scrapper?

it's not a huge problem, but a unique rating id would be great as it simplifies the skinning at least when it comes to use a fallback to show a rating ( e.g. tmdb helper )

(2022-08-14, 12:42)pkscout Wrote: If I remember correctly, The IDs I used were the ones being used by the other scrapers I looked at when building the TMDb TV Shows scraper. That would have been the TVMaze scraper and the TMDB Movies one. There doesn't seem to be any documentation I can find on the IDs, so it appears it's not really a standard as much as a common understanding. I could certainly *add* another ID that has 'themoviedb' and just duplicate the one labeled "tmdb," but it wouldn't really matter. You'll forever have to deal with the two IDs, as you have to rescrape to update those IDs. So anyone who ever used a scraper that saved the ID as 'themoviedb' will always have that in the database (and not 'tmdb'), and (assuming I did that) anyone who's using the current scraper won't have 'themoviedb' except for shows they scraped after the update.

yepp, makes sense ( populate same ratings with different rating_type values will fill the db unnecessary.
i didnt thought about that point.
but where does the raise go then ?

i think a unique rating_type id would be great, but i can see the cons now...