[thica]

Hello all,

when I started a few months ago using xbmc, I was wondering, that fanarts and cover in my mixed movie nfos are not recognized (fanarts) or not used as the default cover.

Having a deeper look in the sources I found a bug in NFO handling and a design mistake in mixed movie nfos.

Bug in fanart handling:

in CVideoInfoTag:arseNative(..)

m_fanart.m_xml << *fanart;

This is not working, as for mixed mode nfos m_xml is always filled from scrapers. In that case a further <fanart> block is added to a string (m_xml ) which already contains a <fanart> block. This does not work.

In addition: The fanart definition is added to the end, which means, that scraper fanarts will be used and nfo fanarts will not be used as the default fanart

For cover (thumbs) this is similar: nfo thumbs will be added to the end, therefor nfo thumbs will not be used as the default cover.

I will submit a patch later, which will remove the bug and will add nfo fanart/cover to the top of the fanart/cover list , so they are used as default.

[AaronD]

What do you mean by "mixed movie nfos"?

[thica]

What do you mean by "mixed movie nfos"?

http://wiki.xbmc.org/index.php?title=Imp...rt_Library

Video nfo files containing a mix of XML and URL
You can also create nfo files that contain both XML data and an URL. This is useful for instance, if you want the entry in your database to have another name than the one officially provided by the scraper, for the movie to sort differently or the movie to be a part of a movie set.

Example:

<movie>
<title>Sin City (Recut, Extended, Unrated)</title>
<runtime>147 min.</runtime>
</movie>
http://www.imdb.com/title/tt0401792/ <movie>
<title>Star Wars (1977 Original Theatrical Release)</title>
<runtime>121 min.</runtime>
<set>Star Wars Saga</set>
<sorttitle>Star Wars1</sorttitle>
</movie>
http://www.imdb.com/title/tt0076759/By default the xml entry is added to the scraped entry in the database and may result in some duplicates. If you want to completely override the scraped result you need to set a clear attribute for the relevant xml tag in the nfo file.

Example:

<movie>
<genre clear="true">Action</genre>
<genre>Horror</genre>
<genre>Thriller</genre>
<director clear="true">Frank Miller</director>
<director>Robert Rodriguez</director>
<director>Quentin Tarantino</director>
</movie>
http://www.imdb.com/title/tt0401792/

Mixed movie nfos means, that your nfo has xml-data AND an url link