Posts: 672
Joined: Aug 2010
Reputation:
13
pieh
Retired Team-Kodi Member
Posts: 672
how about just on/true (aggressive) and off/false (disabled) and aggressive being default? I would like to avoid complicating things too much, but limiting possibilities is not good either ... what do You think about it?
Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first
My previous forum/trac nickname: grajen3
Posts: 26,215
Joined: Oct 2003
Reputation:
187
It seems to me that we should just allow the focused item to swing as much in either direction as it would if it was centered? i.e. allow from left-K to right+K for suitable K. Here "left" and "right" would be the left most and right most slots focusable, so may need to be container-dependent.
Agreed the Aggressive looks better than Default - Default has just a tad too much movement.
Cheers,
Jonathan
Posts: 672
Joined: Aug 2010
Reputation:
13
pieh
Retired Team-Kodi Member
Posts: 672
it's already depend on container type - fixedlist and wraplist have different handling than list and panel (because of the nature of list container - we need to allow it going of the renderarea to see any scrolling)
this idea looks great to me - just how do we define K? hardcoing?
f.e.
K = items_per_page (or row/column in panel) * HARD_CODED_PERCENT_VALUE %
this value should be different for fixed/wraplists (like 50%) and lists/panels (25% - as it is now)
Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first
My previous forum/trac nickname: grajen3
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Why does it need to be different for fixed/wrapped and lists/panels exactly? I would have thought all that would change is the allowed "slots" that the center of the interval may take.
eg for a list the slots would be 0 and m_itemsPerPage-1. From each of these you'd move down K and up K to give [-K, m_itemsPerPage+K-1].
For a wrap list that centers at slot C, you'd just have [C-K, C+K]?
Cheers,
Jonathan
Posts: 2,441
Joined: Apr 2009
Reputation:
73
`Black
Team-Kodi Member
Posts: 2,441
Tested it just now and it works perfectly, thanks.
Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
this seems to fix the missing scroll offset label too.