[ronie]

Code:

Window(Visualisation).Property(ArtistSlideshowRefresh)

is no longer needed (see below for explanation). If you leave it in it won't hurt anything, you just don't need it.

I found a different way to do the refresh after download that, I believe, should work more consistently (it certainly does for me). It mirrors what happens when you change artists. Instead of trying to do a refresh via the skin, when the image downloads are done, the script switches to an "empty" directory, pauses, and then switches back to the correct directory. Switching into or out of a truly empty directory caused a jarring transition, so the empty directory actually as a black image that is 16x9 pixels. That allows for a nicer fade out and in.

nice find!
this indeed works great :-)

besides not needing the refresh property anymore, would this also fix the issue some users are having with the slideshow not refreshing after all images are downloaded?

Fade time after all images loaded: (default 2 seconds)
when the addon starts downloading images, it shows the first one while it downloads all the others. When it refreshes the directory it fades out and back in. For the most seamless experience, set this to the same fade time as your skin uses.

if not strictly needed (as per my comment above), i'd say just hard-code it to 1 second.

we don't want users have to dig through skin xml files to figure out what fadetime their skin uses.

imo, the addon sets the standard and skins should adopt to it.

Let me know if you find issues. I'm going to let this burn in for a week or so and then talk to Ronie about merging all this into the official add-on.

i'm perfectly fine if you want to maintain the addon from this point on.
if so, just submit a pull request on the addon mailing list as soon as you think things are stable enough for inclusion in the addon repo.


oh btw , i've updated the skin integration info on the first post, you may want to make the same changes in the readme file.