2012-01-09, 09:39
tsp42 Wrote:grad: Does the xvba version of xbmc contains the PVR code? if so you could try to diff opdenkamps master branch and my master branch and use it on the xvba version.
Thanks - I have tried to extract a patch. It applies cleanly to the xvba git and compiles. I can also activate it a Live-TV PVR and it does fetch EPG all right. However when I want to watch a recording, it crashes with an arithmetic error. Just to be sure I got everything, could I bother you to quickly review the patch? I've put it here: http://minus.com/mOZIvM6ry#1
I don't know a lot about git. I used git blame to see if a diff came from you or not. Maybe I missed something. Besides the obvious changes in *cmyth* I ran into some changes in the common GUI library right? I skipped everything related to VDPAU, as I'm on AMD graphics. Anything else you know I'll definitely be needing?
Also, don't you think it would be a good idea if you were developing on a branch instead of rebasing your master? Again, I don't know the first thing about git but it appears to be easier to isolate your diffs if you used a branch. Also, if you ever want to submit to upstream you'll be needing that too, right?