[Hitcher]

I think this will quickly get out of control - we need better approach than adding zillions of ListItem.Is*** infobools

Whatever's easiest but I hate having to use a bunch of conditions just to know one thing (and it can't be good for slower systems).

Thanks.

[Hitcher]

OK different approach -

How about making it a ListItem.Overlay object?

That way we could kill two birds with one stone by not having to use conditions if the skinner wants the movie set image in the same place as the un/watched overlay, and/or use <visible>StringCompare(ListItem.Overlay,OverlaySet.png)</visible> to determine if the item is a set.

Thanks.

[Hitcher]

Shameless bump.

[pieh]

Hitcher:
This won't be added before eden in any form. I try to focus on bugfixing right now. Bump this topic after release please.

[Hitcher]

OK, thanks.

[pecinko]

OK, thanks.

Hitcher, I'm curious how did you solve this?

I'm using <visible>Container.content(movies) + ListItem.IsFolder</visible> which seams as a fairly simple solution as long as I don't run into any issues.

Or am I missing something? Thoughts?

[Hitcher]

<visible>!StringCompare(ListItem.Label,..) + ListItem.IsFolder + Container.Content(Movies) + SubString(Container.Folderpath,videodb://,left)</visible>

The StringCompare check is so it doesn't show up for the parent folder, and the SubString check is so it doesn't show up for addons that contain movies and folders.

[pecinko]

<visible>!StringCompare(ListItem.Label,..) + ListItem.IsFolder + Container.Content(Movies) + SubString(Container.Folderpath,videodb://,left)</visible>

The StringCompare check is so it doesn't show up for the parent folder, and the SubString check is so it doesn't show up for addons that contain movies and folders.

Thanks.

Have you noticed speed penalty with all those checks used?

[Hitcher]

I can't say I have on my PCs but you never know.

Ideally I'd like smarter visibility checks where if a group check fails XBMC then ignores all the other checks inside that group and simply goes to the next check. That way we wouldn't have to worry about having lots of them in one section.

[pecinko]

I can't say I have on my PCs but you never know.

Ideally I'd like smarter visibility checks where if a group check fails XBMC then ignores all the other checks inside that group and simply goes to the next check. That way we wouldn't have to worry about having lots of them in one section.

Are you saying that if I put several controls into a group and add a visibility check to it, XBMC will check item visibility conditions regardless of the fact that group visibility has not been met? I believe it won't and will go to next control.

[FrostBox]

Hi,

i use this simple condition in my skin and work perfectly

SubString(ListItem.Path,videodb://1/7) = IsSet

Example with my contextmenu, button to run my addon moviesets
if current ListItem is Set

PHP Code:

<control type="button" id="3020">
                <description>Movie Set info button</description>
                <font>fontContextMenu</font>
                <width>340</width>
                <height>40</height>
                <textcolor>grey2</textcolor>
                <focusedcolor>white</focusedcolor>
                <align>center</align>
                <textwidth>290</textwidth>
                <texturefocus border="25,5,25,5">ShutdownButtonFocus.png</texturefocus>
                <texturenofocus border="25,5,25,5">ShutdownButtonNoFocus.png</texturenofocus>
                <pulseonselect>no</pulseonselect>
                <label>$LOCALIZE[20457] Info</label>
                <onclick>RunScript(script.moviesets,moviesetinfo)</onclick>
                <visible>System.HasAddon(script.moviesets) + SubString(ListItem.Path,videodb://1/7)</visible>
            </control> 


Frost

[pecinko]

Hi,

i use this simple condition in my skin and work perfectly

SubString(ListItem.Path,videodb://1/7) = IsSet

Very nice. Simpler and faster, too! Many thanks.

Is your add-on available in the main repo?

[Hitcher]

Nice one FrostBox.

[FrostBox]

Very nice. Simpler and faster, too! Many thanks.

Nice one FrostBox.

Is your add-on available in the main repo?

no, my last version is currently on my SVN only

I will soon be uploaded/updated here passion-repo http://passion-xbmc.org/addons/?Page=Vie....moviesets

and after soon :p i submit to main repo

Cheers
Frost