• 1
  • 15
  • 16
  • 17(current)
  • 18
  • 19
  • 31
[RELEASE] Artwork Downloader - Skin support
(2012-03-19, 15:09)mikebzh44 Wrote: OK. I think that the issue is due to Glass skin and not to your addon.

On my PC, everything is OK with Aeon Nox. I have modifie DialogVideoInfo.xml this way :

In Glass, XBMC freeze and it's due to DialogSelect.xml

If I take DialogSelect.xml from Aeon Nox directory and copy it to Glass directory, addon can work in mode=gui but display is quite stange (normal because it's Aeon's DialogSelect Big Grin).

I will explain this to fmronan in French Wink

Thanks for your help (XBMC custom compile).

Sure no problem. Hopefully the issue will be resolved Smile
Might some ID is missing in dialogselect.xml

If it's working for everyone i might push it to repo later on today or tomorrow.
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
Bad news. Even with DialogSelect from Aeon Nox, Glass can freeze.

I think it's occure when addon use fileops to cleanup directory.

Because, when it work I can see (less than 1 second) the progress bar and the dialog box is display with differents artwork category to choose.

And when XBMC freeze, progress bar was not displayed.

On Aeon Nox, I didn't manage to freeze XBMC but fmronan does on is PC.

Very strange Sad
Sorry for my english, but, you know, I'm French so ...

Main HTPC : Odroid-C2 running CoreELEC with Titan Bingie
Secondary HTPC : Freebox Mini 4K running Android TV with Titan Bingie
Reply
(2012-03-19, 15:38)mikebzh44 Wrote: Bad news. Even with DialogSelect from Aeon Nox, Glass can freeze.

I think it's occure when addon use fileops to cleanup directory.

Because, when it work I can see (less than 1 second) the progress bar and the dialog box is display with differents artwork category to choose.

And when XBMC freeze, progress bar was not displayed.

On Aeon Nox, I didn't manage to freeze XBMC but fmronan does on is PC.

Very strange Sad

Well you have the latest XBMC build from latest code and fmroman doesn't?
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
I don't know if it could help you but I have put al lot of debug print in script and each type XBMC freeze, the script was in utils.py, method dialog_msg, action create :

line 85 dialog.create( __addonname__, line1, line2, line3 )

Freeze occures in Glass but not in Aeon Nox. I have copy DialogProgress.xml from Aeon to Glass with no success Sad
Sorry for my english, but, you know, I'm French so ...

Main HTPC : Odroid-C2 running CoreELEC with Titan Bingie
Secondary HTPC : Freebox Mini 4K running Android TV with Titan Bingie
Reply
(2012-03-19, 16:53)mikebzh44 Wrote: I don't know if it could help you but I have put al lot of debug print in script and each type XBMC freeze, the script was in utils.py, method dialog_msg, action create :

line 85 dialog.create( __addonname__, line1, line2, line3 )

Freeze occures in Glass but not in Aeon Nox. I have copy DialogProgress.xml from Aeon to Glass with no success Sad

what happens if you replace it with
PHP Code:
dialog.create'Artwork Downloader''line1''line2''line3' 

just for testing sake. So now the the dialog will just show line1, line2,line 3 as text output to see if that works.
And this is with the build I send you?
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
Same issue Sad

Each time, last line in log is : INFO: Loading skin file: DialogProgress.xml

For testing, I have completly disable Dialog by modding code this way :

Code:
if not background:
        """
        if action == 'create':
            #dialog.create( __addonname__, line1, line2, line3 )
            dialog.create( 'Artwork Downloader', 'line1', 'line2', 'line3' )
        if action == 'update':
            dialog.update( percentage, line1, line2, line3 )
        if action == 'close':
            dialog.close()
        if action == 'iscanceled':
            if dialog.iscanceled():
                return True
            else:
                return False
        if action == 'okdialog':
            xbmcgui.Dialog().ok(line0, line1, line2, line3)
        if action == 'yesno':
            return xbmcgui.Dialog().yesno(line0, line1, line2, line3, nolabel, yeslabel)
        """
        return False

And I have seach extrafanarts in GUI mode for a lot of movies and I didn't manage to freeze XBMC.

Frost (aka Frostbox on this forum) has the same issue when developping Metadata Actors addon and he has developped is own progress bar window.
Sorry for my english, but, you know, I'm French so ...

Main HTPC : Odroid-C2 running CoreELEC with Titan Bingie
Secondary HTPC : Freebox Mini 4K running Android TV with Titan Bingie
Reply
(2012-03-19, 17:31)mikebzh44 Wrote: Same issue Sad

Each time, last line in log is : INFO: Loading skin file: DialogProgress.xml

For testing, I have completly disable Dialog by modding code this way :

And I have seach extrafanarts in GUI mode for a lot of movies and I didn't manage to freeze XBMC.

Frost (aka Frostbox on this forum) has the same issue when developping Metadata Actors addon and he has developped is own progress bar window.

This should really be fixed in XBMC core. If frostbox can make some stacktrace on why it is crashing that would be great. so the devs can try to fx it.
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
Is there a backtrace available? Can someone that can make this freeze please pastebin a full backtrace?
Reply
How to produce a full back trace ?

Did you mean full debug log ? I can do that.

EDIT : OK backtrace is different from debug log.

I will install Visual C++ on my PC and download XBMC source code to produce backtrace.
Sorry for my english, but, you know, I'm French so ...

Main HTPC : Odroid-C2 running CoreELEC with Titan Bingie
Secondary HTPC : Freebox Mini 4K running Android TV with Titan Bingie
Reply
(2012-03-19, 17:46)mikebzh44 Wrote: How to produce a full back trace ?

Did you mean full debug log ? I can do that.

For example running running XBMC in a debugger like Microsoft Visual Studio. Only then you get the real reason why it's crashing.
Debug Log won't be any good. Maybe the crashlog on a ATV would help
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
No. I need someone to run it in gdb (or VS) and when it locks up, send a picture of the complete call-stack for each thread. On linux it's easy. You:

1) Compile it for debugging (assuming you're compiling it)
2) run it in gdb
from the directory where the executable built run: gdb xbmc.bin
then type "run" at the gdb prompt - this will start xbmc
3) When it locks up hit Ctrl-c in the gdb window
4) Then type "thread apply all bt" and pastebin everything that prints out (and put a link here)
Reply
(2012-03-19, 17:31)mikebzh44 Wrote: If frostbox can make some stacktrace on why it is crashing that would be great. so the devs can try to fx it.

yes i can. but tonight, Québec time.
but on trac, there are already similar bugs!

http://trac.xbmc.org/ticket/12581
http://trac.xbmc.org/ticket/12274
http://trac.xbmc.org/ticket/10303

frost
For my bad English, sorry. I am French Canadian.
Admin @ Passion-XBMC.org
Reply
Thanks. 12581 will help - it has a backtrace. I might be able to do a patch tonight.
Reply
Strange thing happening here...

Everytime I launch AD, XBMC minimizes to the taskbar. This happens anytime I use the script, whether within an info panel, initiating it from program addons, or searching for artwork individually.

Here's a log with manually launching AD.

http://pastebin.com/22P3gK0s
Quick Links: debug log (wiki) | userdata (wiki) | advancedsettings (wiki) | adding videos to the library (wiki)
Reply
Hello!

I've added support for Artwork Downloader in Shade and there's some strange behavior. I wouldn't be surprised the problem is my implementation but who knows..! The script works, but strangely.

Here's what happen : in the info screen (DialogVideoInfo.xml), I've added the following code :

PHP Code:
<control type="button" id="13">
               <
description>Get Artwork</description>
               <include>
ButtonInfoDialogsCommonValues</include>
        <
onclick condition="Container.Content(tvshows)">XBMC.RunScript(script.artwork.downloadermode=guimediatype=tvshowmedianame=$INFO[ListItem.TVShowTitle])</onclick>
        <
onclick condition="Container.Content(movies)">XBMC.RunScript(script.artwork.downloadermode=guimediatype=moviemedianame=$INFO[ListItem.Title],mediapath=$INFO[ListItem.Path])</onclick>
        <
visible>[Container.Content(tvshows)|Container.Content(movies)]+system.hasaddon(script.artwork.downloader)</visible>
              <
label>Get Artwork</label>                                                    
 </
control

Now, when I click Get Artwork for a movie, I have a dialog where i choose the movie, but then, it's just like the "information screen" is loaded again and the window where I could chose the type of artwork is behind the information screen. It's just when I escape from the information screen and go back to movie selection that the window to chose the type of media is shown.

Thanks for any help!

edit - Skin is available here in case someone would like to test it out : here or here
Reply
  • 1
  • 15
  • 16
  • 17(current)
  • 18
  • 19
  • 31

Logout Mark Read Team Forum Stats Members Help
[RELEASE] Artwork Downloader - Skin support3