Login at Kodi Home

jpsdr · (This post was last modified: 2012-09-03, 16:49 by jpsdr.)

I'm trying to implement the solution i've described for ticket 12012 i've opened. If after testing on my system it seems to work without introducing regression, what should i do to propose a commit or the modification to be more tested by developpers before commit ?

**Montellese** · 2012-09-03, 19:26

Get it on github (i.e. fork the xbmc git repository to get your own copy, create a new branch and apply your changes). Then send a pull request to the xbmc/xbmc repo with the code changes in that branch.

jpsdr · 2012-09-04, 10:51

To create a new branch, is it the correct thing to do :
right click on my "dvdplayer" directory of xbmc project -> turtoise git -> Create Branch

**Montellese** · 2012-09-04, 11:59

I'm not using tortoise git so I can't really help you there but sounds like it's the right way to go. You don't have to create the branch on a specific directory. A branch will always include the whole project.

In command line it's "git checkout -b <name-of-your-branch>".

jpsdr · 2012-09-04, 12:32

I've created a branch (apparently), modify the files in VS2010, been able to commit in the branch i've created.
Now, from the branch i've created, when i try to "push" with turtoise git, i've the following error :
Pushing to https://github.com/xbmc/xbmc.git
error: The requested URL returned error: 403 while accessing https://github.com/xbmc/xbmc.git/info/refs
fatal: HTTP request failed

**Montellese** · 2012-09-04, 12:57

Ah you need to go to github, create an account and then go to https://github.com/xbmc/xbmc and press the "Fork" button on the top right to get your own copy of the xbmc repo. You can follow this help page on github on how to fork a repository: https://help.github.com/articles/fork-a-repo
Then you need to push your branch to your own repo and create a pull request for that branch and send it to xbmc/xbmc.

jpsdr · 2012-09-04, 16:59

I hope i've done things properly...
The pull request is here to discuss.

FernetMenta · 2012-09-04, 18:21

@jpsdr

Would you have a sample to duplicate this problem?

jpsdr · 2012-09-04, 18:55

A sample not. Because first, mkv are hard to edit/modify/cut, and they are often "all or nothing".
I've updated my ticket 12012 with more information, eventualy.
Nevertheless, you can download this file.
You have to play it on a TV wich will play at 23.976fps and/or 29.97fps. Playing it on a PC monitor may probably mask the issue.

jpsdr · (This post was last modified: 2012-09-05, 12:00 by jpsdr.)

Here a direct link of the torrent file, if going on nyaatorrent bothers some.
You can also find the file on newsgroup on alt.binaries.multimedia.anime.highspeed.

**jjd-uk** · 2012-09-05, 13:01

Have you tried creating a sample with mkvmerge?

Example of use I've found at http://www.networkedmediatank.com/showth...p?tid=7310

If you know a specific section use timecodes, see http://www.bunkus.org/videotools/mkvtool...obal_split

jpsdr · 2012-09-06, 13:00

I know and use mkvmerge since a long time, but didn't know this splitting function, wich is indeed interesting. Thanks for this information. I'll try and make some tests.