Posts: 5,184
Joined: Jan 2009
Reputation:
131
IS this an auto-generated thumb?
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
Posts: 5,184
Joined: Jan 2009
Reputation:
131
Does VideoLibrary.GetEpisodeDetails return the proper thumbnail value after you played the item? Or does it always return an empty value?
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
Posts: 5,952
Joined: Sep 2008
Reputation:
201
Koying
Retired Team-Kodi Member
Posts: 5,952
Mmm... Now that you point at it, I don't think auto-generated thumbs show up in upnp, either...
Posts: 548
Joined: Jul 2010
Reputation:
14
if i play from XBMC ui the thumbnail is added in Player.GetItem. if i open player via json the thumbnail field in Player.GetItem is empty.
On both occasions the VideoLibrary.GetEpisodeDetails thumbnail field remains empty.
Posts: 5,184
Joined: Jan 2009
Reputation:
131
I just asked jmarshall and he told me that auto-generated thumbs are not stored in the database and cached. They are simply generated when needed. That's why they are not available through JSON-RPC and UPnP. Will see if it can be fixed somehow.
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
Posts: 5,952
Joined: Sep 2008
Reputation:
201
Koying
Retired Team-Kodi Member
Posts: 5,952
Ahh... Storing them might be quite a performance saver, especially for the likes of android/rpi.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
They're stored in the texture database, as they're defined on a filename rather than a library item. Basically, at scan time they're not generated, so they're only generated when you browse the list (same with stream details).
There's two potential ways to fix this:
1. In the thumbloader, once we've generated a thumb, if it's a videodb item, add it to the video database rather than storing it in the texture database. I'm not sure if this will hit all cases though (e.g. if the thumb is generated while browsing files, rather than when browsing the library...)
2. Scan both stream details and generate auto-thumbs during scan.
I suspect both are required. i.e. update the db if we have a video db item to scan from the thumb generation/stream details job, and then call those jobs from the scanner.
Cheers,
Jonathan
Posts: 5,952
Joined: Sep 2008
Reputation:
201
Koying
Retired Team-Kodi Member
Posts: 5,952
Sorry, I'm lost. You mean they are NOT stored in the texture db, right?
Posts: 26,215
Joined: Oct 2003
Reputation:
187
They are stored in the textures database.
JSON-RPC doesn't use that for art. That's another possibility for a fix though, though not something that's very pretty.
Posts: 5,952
Joined: Sep 2008
Reputation:
201
Koying
Retired Team-Kodi Member
Posts: 5,952
Sorry if it is documented somewhere, but could you summarize the use and differences between the art table and the texture db?
So far, what I understand:
- the art table stores url's as returned from the scrappers; apparently, generated thumbs are not referenced there but imported local .jpg/.png thumbs are.
- the texture db stores generated thumbnails and ..? How is it used?
You say that using the texture db for art wouldn't be pretty. Why so? It'd seem logical to me to store all art url's in the art table, whether they are remote, local or in the texture db...
Posts: 26,215
Joined: Oct 2003
Reputation:
187
The texture database only stores information for file items. i.e. items that aren't in libraries.
I agree that the ideal is for auto-generated thumbs to be placed in the video library art table.
Posts: 5,952
Joined: Sep 2008
Reputation:
201
Koying
Retired Team-Kodi Member
Posts: 5,952
Ah Ok, thanks for clarifying.
If you want, I can handle this but ETA would be end of next week at worst...