Guest - Testers are needed for the reworked CDateTime core component. See... https://forum.kodi.tv/showthread.php?tid=378981 (September 29) x
adjust device volume when launching xbmc
#16
nice, now they have a choice Smile squash the PR down, let's go over it and get it in.
Reply
#17
No choice yet in the UI, but the underlying code to make it a 100% choice is there.

How do you recommend squashing down the PR?
Reply
#18
squash down the previous commits into one, looks like everything can go into one. The idea of a PR is to commit a new feature, you don't really want to show the process in getting there. In other words, you don't have to show your work Smile
Reply
#19
(2013-01-23, 21:27)davilla Wrote: squash down the previous commits into one, looks like everything can go into one. The idea of a PR is to commit a new feature, you don't really want to show the process in getting there. In other words, you don't have to show your work Smile

Just create a new PR with a single commit and close the original?
Reply
#20
(2013-01-23, 21:41)kemonine96 Wrote:
(2013-01-23, 21:27)davilla Wrote: squash down the previous commits into one, looks like everything can go into one. The idea of a PR is to commit a new feature, you don't really want to show the process in getting there. In other words, you don't have to show your work Smile

Just create a new PR with a single commit and close the original?

Squash commits and force push to your branch will auto update the PR Smile
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#21
(2013-01-23, 21:43)Martijn Wrote: Squash commits and force push to your branch will auto update the PR Smile

I was unaware git let you do this. Thanks for the trick, done on PR.
Reply
#22
The PR for getting native volume controls working has been merged. Do you want to keep the thread open still?
Reply
#23
no, close it. any issues can be handled in a new thread.
Reply

Logout Mark Read Team Forum Stats Members Help
adjust device volume when launching xbmc0
This forum uses Lukasz Tkacz MyBB addons.