2015-06-23, 14:22
VPP fully ignores all color flags we give it, therefore we need to use the relevant matrices (that are already in kodi's shadercode) afterwards ourselves. We now get out something "looking like" Limited RGB Range with wrong 601 colorspace, this won't change for now.
We hope to implement this NV12 surface copy and afterwards scale with the correct functions (matrices, that are already there) to be able to output RGB (at the very last moment), which is what OpenGL does at the end. For now nothing else is possible in this "fast path" or in shorter: We have to take _that_ RGB that we are given and have no influence on it.
See: https://github.com/FernetMenta/xbmc/comm...t-11814215 (make sure to also read the commit he answered to, I wanted to get the colorspace right, but VPP ignores it).
Btw. we are working with Lauri Millary to make fully sure we get "the best out of it" that is possible. E.g. direct unaltered output of the HW decoder, then asking the color space via dvdplayer / ffmpeg and use the relevant shader code to output in the color format we want.
We hope to implement this NV12 surface copy and afterwards scale with the correct functions (matrices, that are already there) to be able to output RGB (at the very last moment), which is what OpenGL does at the end. For now nothing else is possible in this "fast path" or in shorter: We have to take _that_ RGB that we are given and have no influence on it.
See: https://github.com/FernetMenta/xbmc/comm...t-11814215 (make sure to also read the commit he answered to, I wanted to get the colorspace right, but VPP ignores it).
Btw. we are working with Lauri Millary to make fully sure we get "the best out of it" that is possible. E.g. direct unaltered output of the HW decoder, then asking the color space via dvdplayer / ffmpeg and use the relevant shader code to output in the color format we want.
