[sunlollyking]

Sorry buddy - One more thing. Your new build is a dead link: https://github.com/garbear/xbmc/releases...f6c7e2dimg.

EDIT ** ALL GOOD - You've fixed

[sunlollyking]

Cool had a mess around with it. A few things i've seen.

https://gist.github.com/sunlollyking/db9...615589e504 - A random unexplained crash when loading up a playstation game.
Interestingly with this emulator, some games seem to run fine and others are into under 10 frames even in just the bios boot screen. weird.

All emus and games seem to default to the CRT filter (third element) which works great but i'm not sure if tha's your intended behaviour.

Some weirdness i've videoed here with the OSD for filters, some appearing ahead of the game and some behind the game layer. Similarly the OSD too is transparent and i'm not sure it should. I've taken a quick video for you here. 
https://photos.app.goo.gl/JNoqMJ7EPjZow442A

Apologies i don't have a log here but when loading up a genesis game using genesis plus gx. All the games have a broken default aspect ratio. They're all set to widescreen letterboxed i think ? I had to manually select 4:3 stretched where previously i didn't need to do this.
And lastly, the majority of the filters are broken, although i'm not sure if this is something i should be doing in terms of installing files. Currently i've just gone from installing the build straight into loading up a game.

Tons of info here, cheers for the good work.

[garbear]

Thanks for the feedback.

https://gist.github.com/sunlollyking/db9...615589e504 - A random unexplained crash when loading up a playstation game.
Interestingly with this emulator, some games seem to run fine and others are into under 10 frames even in just the bios boot screen. weird.

The libretro core doesn't have debug symbols, so I'd have to reproduce locally. The debug log is cut off before I can see the RetroPlayer logging. However, hunting down individual emulator problems is a game of whack-a-mole that I'm not able to put time toward currently. Your best shot is to try to reproduce in RetroArch, and if it still crashes then file a bug report upstream.

All emus and games seem to default to the CRT filter (third element) which works great but i'm not sure if tha's your intended behaviour.

Nope, but once you play a game with a video filter, all games will default to that filter. You possibly selected CRT on an earlier playthrough or run of Kodi. Otherwise, minor details like this will get hammered out when shaders gets closer to being ready for merge.

Some weirdness i've videoed here with the OSD for filters, some appearing ahead of the game and some behind the game layer. Similarly the OSD too is transparent and i'm not sure it should. I've taken a quick video for you here. 
https://photos.app.goo.gl/JNoqMJ7EPjZow442A

This is a known issue with GL shaders. It's actually the main issue before we can PR them. I'm not a GL expert so help fixing this problem is needed.

Apologies i don't have a log here but when loading up a genesis game using genesis plus gx. All the games have a broken default aspect ratio. They're all set to widescreen letterboxed i think ? I had to manually select 4:3 stretched where previously i didn't need to do this.

Are you perhaps using the Genesis GX Wide core? It purposely does widescreen modifications. There's another GenPlus GX core that should have the game's original aspect ratio. Maybe we should remove Genesis Plus GX Wide.

And lastly, the majority of the filters are broken, although i'm not sure if this is something i should be doing in terms of installing files. Currently i've just gone from installing the build straight into loading up a game.

Yes, both Windows/GL have many broken shaders. They were working the moments GSoC 2017/2019 ended, but not widely tested in the years since then, and there's lots of variation in what features GPUs will support, especially on Android.

[garbear]

@sunlollyking Your feedback is pretty much aligned with the current state of shaders. This is where we're at, it's just a process of fixing the show-stopping bugs before we PR.

Broken shaders aren't an issue, the team agreed that as long as a single shader works and doesn't break anything else then we can merge. If 3 of the 14 shaders work we'll ship with 3.

Last request, do you have any feedback on the new read-only "View Players" dialog? I'm demoing it to see if it could work as a framework for a fully-featured Player Manager.

[KOPRajs]

Broken shaders aren't an issue, the team agreed that as long as a single shader works and doesn't break anything else then we can merge. If 3 of the 14 shaders work we'll ship with 3.

When I've created the first LE build with enabled shaders for testing (here: https://forum.kodi.tv/showthread.php?tid...pid3150987), I've spent some time by finding GL shaders that actually do work. The included add-on zip contains the modified shader presets.xml + corresponding translations.

You can download the add-on here and use the list of working shaders from it as a reasonable default for GL shaders: http://koprajs.mx-net.cz/game.shader.pre....0.1.1.zip

[garbear]

Broken shaders aren't an issue, the team agreed that as long as a single shader works and doesn't break anything else then we can merge. If 3 of the 14 shaders work we'll ship with 3.

When I've created the first LE build with enabled shaders for testing (here: https://forum.kodi.tv/showthread.php?tid...pid3150987), I've spent some time by finding GL shaders that actually do work. The included add-on zip contains the modified shader presets.xml + corresponding translations.

You can download the add-on here and use the list of working shaders from it as a reasonable default for GL shaders: http://koprajs.mx-net.cz/game.shader.pre....0.1.1.zip

In my 2023-07-09 builds, I fixed the path selection, so if you try the add-on from @KOPRajs it should override the embedded add-on and give you more working shaders (though it might have to be recompiled with a version greater than 21.0.1, which is included with the builds).

FWIW: I created a glsl branch with all glsl shaders: https://github.com/kodi-game/game.shader.../tree/glsl

[sunlollyking]

Cool just off out but ill test the player manager later if i get a chance.
One thing i did notice though is that retroachievements aren't working. No notification popped when i should have seen one. When i look into logging into RetroAchievements via Kodi. I keep seeing a dialog "Your accounts is not verified. Please check your email to complete your sign up"
I've tested this with accounts i know are verified and even made a new one to test with but nothing.

EDIT: I just found this rooting in my logs  - I've asterisked out my password

2023-07-11 14:35:32.493 T:798     debug <general>: CurlFile::Open - <http://retroachievements.org/dorequest.php?r=login&u=itsmechrissyd1 &p=*********>
2023-07-11 14:35:32.493 T:798     error <general>: CCurlFile::CReadState::FillBuffer - (0x81cc520) Failed: URL using bad/illegal format or missing URL(3)
2023-07-11 14:35:32.494 T:798     error <general>: CCurlFile::Open - <http://retroachievements.org/dorequest.php?r=login&u=itsmechrissyd1 &p=***********> Failed with code 0:

Malformed URL because of the space between username and password ?

[sunlollyking]

Tried my best to dig through it and think it's code in this class https://github.com/garbear/xbmc/blob/519...gs.cpp#L38 
Doesn't look like anything's changed since it was working.... so i'm not sure why there's a space in my log?

[garbear]

Can you check your userdata guisettings.xml? (I know, totally secure how we store RA creds.) When signed in properly it should look like:
 

Code:

<setting id="gamesachievements.username">xxx</setting>
<setting id="gamesachievements.password">yyy</setting>
<setting id="gamesachievements.token">zzz</setting>

You'll notice a pattern, most things are tested and working, but this doesn't apply to some of the projects that only had a single summer's worth of time put in.

I've been maintaining the GSoC code but it really needs more humanpower to get the things working that never worked due to time constraints, or perhaps broke in the many years since they were written.

That said, the architecture is in place, so with a little elbow work hammering out the bugs, shaders and achievements can be merged upstream, allowing them to stay working going forward.

[sunlollyking]

Cool so checked my userdata - The format seems to be saved as:

<setting id="gamesachievements.username">xxx </setting>
<setting id="gamesachievements.password">yyy</setting>
<setting id="gamesachievements.token">zzz</setting>

With the extra space after username. I amended the file and replaced it on my system but the errors still are occurring and after trying to authenticate the guisettings properties seem to be back to how they were also.

2023-07-13 08:09:48.479 T:800     debug <general>: CurlFile::Open - <http://retroachievements.org/dorequest.php?r=login&u=itsmechrissyd1 &p=yyy>
2023-07-13 08:09:48.479 T:800     error <general>: CCurlFile::CReadState::FillBuffer - (0x581cd00) Failed: URL using bad/illegal format or missing URL(3)
2023-07-13 08:09:48.479 T:800     error <general>: CCurlFile::Open - <http://retroachievements.org/dorequest.php?r=login&u=itsmechrissyd1 &p=yyy> Failed with code 0:

[garbear]

I went through the code and don't see where a space can be getting introduced. Can you exit Kodi, delete guisettings.xml entirely, and restart Kodi, verifying that it's starting from fresh settings? Then insert your username in the GUI, and check guisettings.xml to see if a space was erroneously added.

[sunlollyking]

So this worked! No idea why it wasn't but starting from scratch did. The only problem now seems to be "Your Account Is Not Verified....." I've raised with retroachievement team because it could be something to do with them. I've got multiple accounts all verified but Kodi seems to not see them as verified.

[garbear]

I think I remember getting the same error and it took several tries, then when it worked I made a instantly made a backup of my guisettings.xml! Keep in mind, if you have RA look into it, that our code could very well have a bugs.

[sunlollyking]

From the RA site.... Ah! I wish they published maintenance in their API or refused connections


WilHiteWarrior
Site Moderator

Joined Apr 13, 2018

53 minutes ago

The API is currently down for repairs. Apologies for the inconvenience, we are working on it but no ETA on when it will be fixed

[sunlollyking]

Using the new port manager i've been trying to test out rumble through my 8bitdopro2. However every time i try switch to the DualShock control profile i get a system lockup and and a reset. Not sure if you're aware of it. Here's a log:
https://gist.github.com/sunlollyking/1cd...1386a447d8