[garbear]

Nestopia:
Failed the first time I launched. Said it required game.controller.nes.zapper.
Deleted <import addon="game.controller.nes.zapper" version="1.0.0" optional="true"/> from the addon.xml and now it launches. Doesn't look like the optional flag is being adhered to.

Same issue for 4DO, worked after i deleted the optional controller in the addon.xml

Noted, I'll look into this.

Genesis Plus GX launches and plays fine, but then when I stop the game (using the stop button on OSD), Kodi crashes. log here.

Crash could be caused by the core. I'll try to step through in debug mode and see if I can find the crash.

Beetle NGP fails to launch game, log here.

This one I can actually fix I changed retroplayer to fail hard and fast if the core's addon.xml lies. In this case,

Code:

DEBUG: AddOnLog: Neo Geo (Beetle NGP): CORE: Supports VFS:    false
DEBUG: AddOnLog: Neo Geo (Beetle NGP): CORE: ----------------------------------
ERROR: AddOnLog: Neo Geo (Beetle NGP): CORE: VFS support doesn't match addon.xml: true
ERROR: ADDON: Dll Neo Geo (Beetle NGP) - Client returned bad status (6) from Create and is not usable

This change should fix it: https://github.com/kodi-game/game.libret...it/d92be00

One additional nitpick: when a bios file is not present, you get a generic error dialog, while the log specifies the issue. If it's possible to tell the user the bios file isn't present using a dialog that might help them understand what the issue is.

I plan to handle bioses using "game resource add-ons". If the add-on isn't found, Kodi will say "Could not launch game: game.resource.gensis not found", and giving the user a specific google search term is about as easy as it gets

Looking forward to when it's a part of Kodi.

The PR is scheduled to be merged soon after Kodi branches for release. Maybe a month, but now that Kodi is in the windows store a lot of bugs are popping up, so maybe more.