[garbear]

Is the proposal to do whatever the game would normally do on pressing Start, and then do another thing if the button is still held at the 1000ms point?

This is the behavior proposed in PR12180.

If so, that seems like a fairly ideal way of doing things.

Not exactly. For example: In 2048 I press and hold start. Immediately the game is paused in-game, then after a second the OSD pops up (currently without pausing the game, but that is trivial to change). When the OSD is closed, we return to 2048 which is still on the pause screen. Start must be pressed again to resume gameplay.

The discussion here is how to improve this flawed behavior. Basically when start is pressed, we need to *not* send the press to the game and pause the game loop when the OSD is opened. The question is, how, when and for how long do we send a regular start press to the game?

The game SHOULD pause by default when you open the OSD anyway, shouldn't it? You wouldn't want to accidentally die because you can't control the game anymore.

Yes of course, I'll make sure to change this.