[mikeSiLVO]

@bsoriano Please try latest from Git.

I think I fixed it.

[bsoriano]

@bsoriano Please try latest from Git.

I think I fixed it.

@mikeSiLVO , thank you! Just tested and the icons are back for the widget categories, and there are no more errors in the log.

Will you be submitting this version to the Kodi repo? Will you also be submitting your updated version of service.library.data.provider?

Regards,

Bart

[jurialmunkey]

@mikeSiLVO
Working well for most icons in customisation dialog now.

I had one icon not showing. It uses an override based on label:

xml:
<icon labelID="24001">special://skin/extras/icons/addons.png</icon>

In mainmenu.DATA.xml

xml:


<shortcut>

    <label>24001</label>

    <label2/>

    <defaultID>addons</defaultID>

    <icon />

    <action>ActivateWindow(AddonBrowser)</action>

</shortcut>

Also, thanks for working on making skinshortcuts Matrix compatible. It's the one add-on that I absolutely cannot live without!

[mikeSiLVO]

@mikeSiLVO , thank you! Just tested and the icons are back for the widget categories, and there are no more errors in the log.

Will you be submitting this version to the Kodi repo? Will you also be submitting your updated version of service.library.data.provider?

Regards,

Bart

I guess I could submit them but not sure if I have to be added as a maintainer. I'd rather not be since I am still learning Python and don't know how much I can do with the scripts in general.

In regards to Skin Shortcuts though, I definitely want to wait a bit more for any other bug reports before even thinking of submitting.

@mikeSiLVO
Working well for most icons in customisation dialog now.

I had one icon not showing. It uses an override based on label:

xml:
<icon labelID="24001">special://skin/extras/icons/addons.png</icon>

In mainmenu.DATA.xml

xml:


<shortcut>

    <label>24001</label>

    <label2/>

    <defaultID>addons</defaultID>

    <icon />

    <action>ActivateWindow(AddonBrowser)</action>

</shortcut>

Also, thanks for working on making skinshortcuts Matrix compatible. It's the one add-on that I absolutely cannot live without!

I didn't test but I hopefully fixed it with the latest changes.

Let me know

[sualfred]

Before you could submit it -> Python3 compatiblity, the bigger part, has to be done. Not a big deal, it usually just takes a few hours for everything incl. testing.

Is anyone still active who has write access to this repo?

[mikeSiLVO]

Before you could submit it -> Python3 compatiblity, the bigger part, has to be done. Not a big deal, it usually just takes a few hours for everything incl. testing.

Is anyone still active who has write access to this repo?

I started to add Python 3 compatibility.

Slow going cause I don't really know what I am doing yet.

Python 3 WiP branch is HERE.

I am just checking the log for errors and fixing things as I go and right now I am up to this error:

Code:


EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'TypeError'>
Error Contents: can only concatenate str (not "bytes") to str
Traceback (most recent call last):
File "C:\Kodi (Python 3)\portable_data\addons\script.skinshortcuts\default.py", line 426, in <module>
Main()
File "C:\Kodi (Python 3)\portable_data\addons\script.skinshortcuts\default.py", line 83, in __init__
XML.buildMenu( self.MENUID, self.GROUP, self.LEVELS, self.MODE, self.OPTIONS, self.MINITEMS )
File "C:\Kodi (Python 3)\portable_data\addons\script.skinshortcuts\resources\lib\xmlfunctions.py", line 76, in buildMenu
log( "Profile found: " + name + " (" + dir + ")" )
TypeError: can only concatenate str (not "bytes") to str
-->End of Python script error report<--


So I am trying to fix that ATM and any help or PR's to get it working on Python 3 would be most appreciated

[mikeSiLVO]

I was able to get the script to not crash but still have to figure out the error above and then this new one that popped up :

ERROR: Traceback (most recent call last):
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR: File "C:\Kodi (Python 3)\portable_data\addons\script.skinshortcuts\resources\lib\datafunctions.py", line 518, in _get_overrides_skin
self._save_hash( overridePath, xbmcvfs.File( overridePath ).read() )
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR: File "C:\Kodi (Python 3)\portable_data\addons\script.skinshortcuts\resources\lib\datafunctions.py", line 1128, in _save_hash
hasher.update( file )
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR: TypeError: Unicode-objects must be encoded before hashing
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR:
During handling of the above exception, another exception occurred:
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR: Traceback (most recent call last):
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR: File "C:\Kodi (Python 3)\portable_data\addons\script.skinshortcuts\resources\lib\xmlfunctions.py", line 109, in buildMenu
self.writexml( profilelist, mainmenuID, groups, numLevels, buildMode, progress, options, minitems )
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR: File "C:\Kodi (Python 3)\portable_data\addons\script.skinshortcuts\resources\lib\xmlfunctions.py", line 342, in writexml
DATA._reset_backgroundandwidgets()
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR: File "C:\Kodi (Python 3)\portable_data\addons\script.skinshortcuts\resources\lib\datafunctions.py", line 791, in _reset_backgroundandwidgets
tree = self._get_overrides_skin()
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR: File "C:\Kodi (Python 3)\portable_data\addons\script.skinshortcuts\resources\lib\datafunctions.py", line 524, in _get_overrides_skin
self._save_hash( overridePath, xbmcvfs.File( overridePath ).read() )
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR: File "C:\Kodi (Python 3)\portable_data\addons\script.skinshortcuts\resources\lib\datafunctions.py", line 1128, in _save_hash
hasher.update( file )
2019-08-29 12:43:05.887 T:18446744073709551614 ERROR: TypeError: Unicode-objects must be encoded before hashing

[mikeSiLVO]

Not a big deal, it usually just takes a few hours for everything incl. testing.

HA! A few hours... For me it is days so far and still not done.

I am at the point now where I could use some testers for backward compatibility on Python 2 as well as anyone who can test on Python 3.

Foreign language users who can test for those dang Unicode errors would also be helpful.

Known issues I am still trying to fix are icons in the management dialog not updating. They change correctly for the menu but list 211 doesn't ever show the new icon.

The other issue that I have noticed is the script not able to get the hash for the script-skinshortcuts-includes.xml file but I have not experienced any problems due to that.

The branch to test Py2 & Py3 is HERE

[sualfred]

Are you in touch with @BobCratchett ?
As far as I can see he is also working on it again. At least he forked it from you.

[mikeSiLVO]

Are you in touch with @BobCratchett ?
As far as I can see he is also working on it again. At least he forked it from you.

He has been helping me and we have talked on Git but I don't know if he plans on returning to development on a larger scale.

[sualfred]

I'm sure he will still help you out. He knows the code and is the best address.

I would join but my vacation is over and I only had time to port the colorpicker and simplecache to Py3. My wife is pregnant and I have to deal with the our first little monster in the evening. So....not much time left of a working day.
Maybe I'll find some quiet minutes on the weekend to take a look, too.

[mikeSiLVO]

Quick update.

Pretty sure the latest master and python_3 branches of the script has everything working now. Including icons in the management dialog.

Just need folks to test it all out.

The python_3 branch should behave the same way but if nobody wants to help debug that one then master is just to get it all working on Matrix.

Please test if you can

[bsoriano]

Quick update.

Pretty sure the latest master and python_3 branches of the script has everything working now. Including icons in the management dialog.

Just need folks to test it all out.

The python_3 branch should behave the same way but if nobody wants to help debug that one then master is just to get it all working on Matrix.

Please test if you can

@mikeSiLVO, thanks! I will test both branches today and let you know how it goes.

Regards,

Bart

[BobCratchett]

Are you in touch with @BobCratchett ?
As far as I can see he is also working on it again. At least he forked it from you.

He has been helping me and we have talked on Git but I don't know if he plans on returning to development on a larger scale.    

Nope, not in a position to do the larger scale development.

I'm sure he will still help you out. He knows the code and is the best address.

Happy to help out where I can, and certainly I'll test the Python 3 stuff to the best of my ability over the next few days. And, as saulfred says, I definitely do know the code so if I can help out with where in the code the bugs might be lurking or simply what the code is doing and why, please feel free to hit me up.

[annomatik]

Hi! Switching from Kodi 17 to 18, my custom "System.logoff" entry in my menu has disappeared. I was logging in automatically in my Master profile (skipping the login screen) and used that command to exit back to the login screen.

After a long search, I found out, that this seems to be a feature -- not a bug. Still, If I comment out this part of datafunctions.py, everything works as before:

        elif action == "system.logoff":
            return "[System.HasLoginScreen | IntegerGreaterThan(System.ProfileCount,1)] + System.Loggedon"

Would it be possible to remove the visibility-statement for system.logoff so my use case would work again? I tried it with System.ProfileCount,1 only but for some reason, it still did not work -- I had to remove all three criterias ( HasLoginScreen, ProfileCount greater 1 and System.Loggedon).

Thanks!