Guest - Testers are needed for the reworked CDateTime core component. See... https://forum.kodi.tv/showthread.php?tid=378981 (September 29) x
Subtitle handling in OSD
#1
When pressing next in OSD of subtitles in Gotham the subtitle can be disabled. While this makes perfect sense if you have "next" and/or "previous" subtitle mapped to a key on the keyboard/remote, it is frustrating in the GUI. I mean, there is an "enable/disable" button and its not at all clear that the next will do that. Even worse, when you disable it the little popup vanishes Smile

I propose that we add either an option to the [Next|Previous]Subtitle action which allows for disable, or we add another action. It is confusing that it disables in OSD GUI.

Thoughts?
If you have problems please read this before posting

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.

Image

"Well Im gonna download the code and look at it a bit but I'm certainly not a really good C/C++ programer but I'd help as much as I can, I mostly write in C#."
Reply
#2
+1
Reply
#3
sure, introduce a new action which only cycles through subtitles but does not disable those and use it in skins. Keep keymappings as they are.
Reply
#4
Sounds logical
Reply
#5
So now to the really hard question, What to name the action Tongue

The current one is NextSubtitle. To me that naming suggest _nothing_ about it disableing subtitles. So IMO that one should perhaps be the one which just selects a subtitle?
The other name I can come up with is CycleSubtitle, not sure if thats a good naming for with disable or without disable? To be frank its quite hard to name it in any way so that it makes perfect sense its a different action and what the intent is Tongue

Thoughts?
If you have problems please read this before posting

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.

Image

"Well Im gonna download the code and look at it a bit but I'm certainly not a really good C/C++ programer but I'd help as much as I can, I mostly write in C#."
Reply
#6
Very quickly thrown together for the sake of testing it out. https://github.com/topfs2/xbmc/commit/24...84a1baee8f
If you have problems please read this before posting

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.

Image

"Well Im gonna download the code and look at it a bit but I'm certainly not a really good C/C++ programer but I'd help as much as I can, I mostly write in C#."
Reply

Logout Mark Read Team Forum Stats Members Help
Subtitle handling in OSD0
This forum uses Lukasz Tkacz MyBB addons.