[MacGyver]

So I downloaded nightlies between Nov 11 and Dec 11 until I could say definitively.
$COMMA works perfectly on the Dec 5,2013 nightly build, and does not work on anything after (it no longer works on Dec 6,2013 and up til 2 days ago.)

JM, I am using the the same machine with the same settings, same skin, and same database, the only thing changing is the build version.
I'm at work and can't track it down any further, but it is a bug.

[jmarshall]

So the first nightly it broke on was: http://mirrors.xbmc.org/nightlies/win32/...master.exe ?
but it still worked fine in http://mirrors.xbmc.org/nightlies/win32/...master.exe ?

Can you provide a simple way for me to reproduce (Confluence ideally)

Thanks,
Jonathan

[Hitcher]

Could it have something to do with this commit?

CharsetDetection: add "ConvertPlainTextToUtf8()"

[MacGyver]

That is correct JM, worked on 20131205, broken on 20131206.

Simplest way to test would be to replace the <textcolor> of a focused ListItem.Label control with:

Code:

<textcolor>$VAR[value_ratingcolor]</textcolor>

and add this to Includes_Variables.xml

Code:

<variable name="value_ratingcolor">
        <value condition="!SubString(ListItem.Votes,$COMMA)">FFFF0000</value>
        <value condition="SubString(ListItem.Votes,1$COMMA,Left)">FFFF5555</value>
        <value condition="SubString(ListItem.Votes,2$COMMA,Left)">FFFFFF00</value>
        <value condition="SubString(ListItem.Votes,3$COMMA,Left)">FFFFFF00</value>
        <value condition="SubString(ListItem.Votes,4$COMMA,Left)">FFFFFF00</value>
        <value condition="SubString(ListItem.Votes,5$COMMA,Left)">FFFFFF00</value>
        <value condition="SubString(ListItem.Votes,$COMMA)">FF00FF00</value>
    </variable>

Is that what you meant?

[jmarshall]

Thanks. This looks like the offending commit:

https://github.com/jmarshallnz/xbmc/comm...39683f11d0

Pretty subtle one - would break lots of things in other ways, so nice find

EDIT: Fix here: https://github.com/xbmc/xbmc/pull/4082

EDIT2: Committed.