Release - TIDAL music (former WiMP)

  Thread Rating:
  • 6 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
takoi Offline
Team-Kodi Member
Posts: 1,225
Joined: Oct 2009
Reputation: 25
Location: Norway
Post: #46
Ok, test tidal or lossless support by getting the staging branch here: https://github.com/tamland/xbmc-wimp/commits/staging
Like I said I've done it blindly. If I get feedback that it's working, I will push to repo.
find quote
theli_ua Offline
Junior Member
Posts: 21
Joined: Feb 2015
Reputation: 0
Post: #47
(2015-02-14 19:05)takoi Wrote:  Ok, test tidal or lossless support by getting the staging branch here: https://github.com/tamland/xbmc-wimp/commits/staging
Like I said I've done it blindly. If I get feedback that it's working, I will push to repo.

Code:
15:55:16 T:1657988160  NOTICE: Thread LanguageInvoker start, auto delete: false
15:55:16 T:1657988160  NOTICE: -->Python Interpreter Initialized<--
15:55:20 T:1657988160   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.ValueError'>
                                            Error Contents: too many values to unpack
                                            Traceback (most recent call last):
                                              File "/storage/.kodi/addons/xbmc-wimp-staging/addon.py", line 241, in <module>
                                                plugin.run()
                                              File "/storage/.kodi/addons/xbmc-wimp-staging/routing.py", line 75, in run
                                                self._dispatch(path)
                                              File "/storage/.kodi/addons/xbmc-wimp-staging/routing.py", line 85, in _dispatch
                                                view_func(**kwargs)
                                              File "/storage/.kodi/addons/xbmc-wimp-staging/addon.py", line 234, in play
                                                host, app, playpath = media_url.split('/', 3)
                                            ValueError: too many values to unpack
                                            -->End of Python script error report<--
15:55:20 T:1969004544   ERROR: Playlist Player: skipping unplayable item: 32, path [plugin://plugin.audio.wimp/play/5580097?]
I'll see if I'll have time to fix it myself and file a pull requests
find quote
theli_ua Offline
Junior Member
Posts: 21
Joined: Feb 2015
Reputation: 0
Post: #48
Ok, I fixed TIDAL support and tested.
However it *only* works with LOSSLESS for me ... with low/high it succeeds in getting stream URL but kodi fails to play it stating some decoding errors...
Didn't have time to debug it much.
Anyway, LOSSLESS with tidal works just fine for me
I posted a pull request with my changes.
find quote
theli_ua Offline
Junior Member
Posts: 21
Joined: Feb 2015
Reputation: 0
Post: #49
oops, spoke too early about "no problems"
For w/e reason everything works fine if I switch tracks manually - just start another one, press next/prev/etc.
But if I let track finish and start another one - every subsequent stream opening fails... maybe kodi doesn't close a previous connection before starting streaming another file and thats why it fails?
(This post was last modified: 2015-02-15 11:05 by theli_ua.)
find quote
theli_ua Offline
Junior Member
Posts: 21
Joined: Feb 2015
Reputation: 0
Post: #50
Alright, I fixed all problems I had with tidal by setting correct mimetype and updated my pull request.

Now everything seem to work - all different qualities and haven't seen any problems with tracks skipping whatsoever

Also, takoi, does WIMP really uses rtmp? Cause I've only seen TIDAL use http streams


edit: I've also add featured playlists, new/recommended/top albums/tracks/playlists as well as mood playlists navigation, I'll add genre navigation later
(This post was last modified: 2015-02-16 10:17 by theli_ua.)
find quote
takoi Offline
Team-Kodi Member
Posts: 1,225
Joined: Oct 2009
Reputation: 25
Location: Norway
Post: #51
(2015-02-16 05:05)theli_ua Wrote:  Alright, I fixed all problems I had with tidal by setting correct mimetype and updated my pull request.

Now everything seem to work - all different qualities and haven't seen any problems with tracks skipping whatsoever

Also, takoi, does WIMP really uses rtmp? Cause I've only seen TIDAL use http streams


edit: I've also add featured playlists, new/recommended/top albums/tracks/playlists as well as mood playlists navigation, I'll add genre navigation later
Yep. It used to be plain http that worked flawlessly, then some tabloid wrote about how easy it was to download, and copyright holders demanded it fixed. And the 'fix' was to replace html5 with flash+rtmp.

Since you say tidal use http for everything, I'm not sure if wimp will work after all. It may still be using that proprietary chome only solution..
(This post was last modified: 2015-02-16 16:44 by takoi.)
find quote
theli_ua Offline
Junior Member
Posts: 21
Joined: Feb 2015
Reputation: 0
Post: #52
(2015-02-16 16:43)takoi Wrote:  
(2015-02-16 05:05)theli_ua Wrote:  Alright, I fixed all problems I had with tidal by setting correct mimetype and updated my pull request.

Now everything seem to work - all different qualities and haven't seen any problems with tracks skipping whatsoever

Also, takoi, does WIMP really uses rtmp? Cause I've only seen TIDAL use http streams


edit: I've also add featured playlists, new/recommended/top albums/tracks/playlists as well as mood playlists navigation, I'll add genre navigation later
Yep. It used to be plain http that worked flawlessly, then some tabloid wrote about how easy it was to download, and copyright holders demanded it fixed. And the 'fix' was to replace html5 with flash+rtmp.

Since you say tidal use http for everything, I'm not sure if wimp will work after all. It may still be using that proprietary chome only solution..
I suspect that its the matter of grabbing right token. I took mine from android app and I heard people having problems with TIDAL's web player token as well.
I think I can also grab a token from WIMP's android app but I won't really have a way to test it.
find quote
takoi Offline
Team-Kodi Member
Posts: 1,225
Joined: Oct 2009
Reputation: 25
Location: Norway
Post: #53
(2015-02-16 20:21)theli_ua Wrote:  
(2015-02-16 16:43)takoi Wrote:  
(2015-02-16 05:05)theli_ua Wrote:  Alright, I fixed all problems I had with tidal by setting correct mimetype and updated my pull request.

Now everything seem to work - all different qualities and haven't seen any problems with tracks skipping whatsoever

Also, takoi, does WIMP really uses rtmp? Cause I've only seen TIDAL use http streams


edit: I've also add featured playlists, new/recommended/top albums/tracks/playlists as well as mood playlists navigation, I'll add genre navigation later
Yep. It used to be plain http that worked flawlessly, then some tabloid wrote about how easy it was to download, and copyright holders demanded it fixed. And the 'fix' was to replace html5 with flash+rtmp.

Since you say tidal use http for everything, I'm not sure if wimp will work after all. It may still be using that proprietary chome only solution..
I suspect that its the matter of grabbing right token. I took mine from android app and I heard people having problems with TIDAL's web player token as well.
I think I can also grab a token from WIMP's android app but I won't really have a way to test it.
The wimp android app use a completely different api (thrift based).. Are you sure it's the same app with different branding?
find quote
theli_ua Offline
Junior Member
Posts: 21
Joined: Feb 2015
Reputation: 0
Post: #54
(2015-02-16 22:39)takoi Wrote:  
(2015-02-16 20:21)theli_ua Wrote:  
(2015-02-16 16:43)takoi Wrote:  Yep. It used to be plain http that worked flawlessly, then some tabloid wrote about how easy it was to download, and copyright holders demanded it fixed. And the 'fix' was to replace html5 with flash+rtmp.

Since you say tidal use http for everything, I'm not sure if wimp will work after all. It may still be using that proprietary chome only solution..
I suspect that its the matter of grabbing right token. I took mine from android app and I heard people having problems with TIDAL's web player token as well.
I think I can also grab a token from WIMP's android app but I won't really have a way to test it.
The wimp android app use a completely different api (thrift based).. Are you sure it's the same app with different branding?
No, I'm not sure about that. But I'll take a look anyway
find quote
theli_ua Offline
Junior Member
Posts: 21
Joined: Feb 2015
Reputation: 0
Post: #55
So, I'm not sure if WIMP android app uses the same API but it does use a different token than then one in wimpy
Also, I didn't have time to fix/update my PR, I'll work on it in the next couple of days
find quote
geofstro Offline
Junior Member
Posts: 20
Joined: Nov 2012
Reputation: 0
Post: #56
edited to remove comments. I realised I downloaded the wrong code.

theli_ua is your fix for the above logged problem available for download? I'd like to test it on Wimp lossless.

When I dowloaded from the link I got the same problem, so I couldn't have downloaded the files that incorporate your fixes.

I'm very excited to try this.

Thanks in advance.

geoff
(This post was last modified: 2015-02-22 23:34 by geofstro.)
find quote
theli_ua Offline
Junior Member
Posts: 21
Joined: Feb 2015
Reputation: 0
Post: #57
(2015-02-22 22:35)geofstro Wrote:  edited to remove comments. I realised I downloaded the wrong code.

theli_ua is your fix for the above logged problem available for download? I'd like to test it on Wimp lossless.

When I dowloaded from the link I got the same problem, so I couldn't have downloaded the files that incorporate your fixes.

I'm very excited to try this.

Thanks in advance.

geoff
From what I see that doesn't look like latest code. Could you please try latest version in my fork? https://github.com/theli-ua/xbmc-wimp/tree/staging
find quote
theli_ua Offline
Junior Member
Posts: 21
Joined: Feb 2015
Reputation: 0
Post: #58
(2015-02-22 22:35)geofstro Wrote:  edited to remove comments. I realised I downloaded the wrong code.

theli_ua is your fix for the above logged problem available for download? I'd like to test it on Wimp lossless.

When I dowloaded from the link I got the same problem, so I couldn't have downloaded the files that incorporate your fixes.

I'm very excited to try this.

Thanks in advance.

geoff

try https://www.sendspace.com/file/2fnnih
find quote
geofstro Offline
Junior Member
Posts: 20
Joined: Nov 2012
Reputation: 0
Post: #59
Great thanks. Will test today.

geoff
find quote
geofstro Offline
Junior Member
Posts: 20
Joined: Nov 2012
Reputation: 0
Post: #60
OK; at the moment I have both Tidal and Wimp accounts (will cancel one of them eventually) Your code works with Tidal; but not Wimp:

Here is the log from Wimp:

failed to open source <http://front02.cph.wimpmusic.com/3/Gc0Zw8MY4MbWusmplJ%2BD2zr4u2hCQePhqj5dr60zQrOlEG6ZJ9ksYrfgCBueGvsHlm932hyikCe8Zm​W39kgDBClJ7asm2tOdwe1PMwwteZRZeU1rz09JubcgsDjCAcL3qOhohOUG0hQNWnMuDx%2BD8p2hMWMM​ysIzW7aEFHuxJtul3DS%2B2KC8E4e7N4mpuqQ0tezTW7eNY0W%2FCgbP53KSP%2F47WTaYwqe99R80pZ​iJjq4XoPflZzBHTYrNjYU9E3MgwImP>
13:35:40 T:140735313269504 ERROR: Init: Error opening file http://front02.cph.wimpmusic.com/3/Gc0Zw...U9E3MgwImP
13:35:40 T:140735313269504 ERROR: CAudioDecoder: Unable to Init Codec while loading file http://front02.cph.wimpmusic.com/3/Gc0Zw...U9E3MgwImP
13:35:40 T:140735313269504 WARNING: PAPlayer::QueueNextFileEx - Failed to create the decoder

I hope this helps,

geoff
find quote
Post Reply