2015-08-02, 11:57
(2015-08-02, 11:56)Jayz2K Wrote: You can still use the modded Conq file I sent you through PM (the second one).
Right
(2015-08-02, 11:56)Jayz2K Wrote: You can still use the modded Conq file I sent you through PM (the second one).
(2015-08-02, 12:25)mkortstiege Wrote: I am pretty sure it was non-working before and with my label2 PR. Here's a follow up PR that handles the UpdateColor() for sliderex. https://github.com/xbmc/xbmc/pull/7691Well, my bad :/ Sorry.
(2015-08-02, 16:37)mkortstiege Wrote: Merged. Would be awesome if you could give tomorrows nightly another try and report back if all those label2 and textcolor issues are addressed.I'm using the August 1 Isengard nightly. If I remember correctly, labels used to not show up when using variables inside [COLOR] tags in itemlayout/focusedlayout. Now, the labels show up but they do not use the color variable. I had heard that this was fixed for Jarvis, did this fix not make it into the Isengard branch?
<value>[COLOR $VAR[ColorHighlightVar]]$INFO[ListItem.Tagline,, ][/COLOR]$INFO[ListItem.PlotOutline]</value>
(2015-08-02, 16:37)mkortstiege Wrote: Merged. Would be awesome if you could give tomorrows nightly another try and report back if all those label2 and textcolor issues are addressed.
(2015-08-03, 09:09)mkortstiege Wrote: Hmz, just tested with mimic and i see the tagline (blue) in both versions.Should have mentioned that it's only Shift view with the plot turned on from the side menu where I'm seeing the issue. Infowall view, where the plot is outside the layout, displays the tagline in blue. In Shift view, where the plot var is inside the layout, the tagline is displayed in the main text color.
(2015-08-03, 16:27)braz Wrote:(2015-08-03, 09:09)mkortstiege Wrote: Hmz, just tested with mimic and i see the tagline (blue) in both versions.Should have mentioned that it's only Shift view with the plot turned on from the side menu where I'm seeing the issue. Infowall view, where the plot is outside the layout, displays the tagline in blue. In Shift view, where the plot var is inside the layout, the tagline is displayed in the main text color.
Will test latest master tonight. Thanks!
(2015-08-03, 16:29)mkortstiege Wrote:(2015-08-03, 16:27)braz Wrote:(2015-08-03, 09:09)mkortstiege Wrote: Hmz, just tested with mimic and i see the tagline (blue) in both versions.Should have mentioned that it's only Shift view with the plot turned on from the side menu where I'm seeing the issue. Infowall view, where the plot is outside the layout, displays the tagline in blue. In Shift view, where the plot var is inside the layout, the tagline is displayed in the main text color.
Will test latest master tonight. Thanks!
Works in master. Will find the commit that fixed it and backport as well.
(2015-08-03, 16:34)mkortstiege Wrote:Working here now too, and all I did was restart Kodi, Something must have gotten hung up with that view, as reloading the skin wasn't refreshing it. Thanks for testing and great work on the new features.(2015-08-03, 16:29)mkortstiege Wrote:(2015-08-03, 16:27)braz Wrote: Should have mentioned that it's only Shift view with the plot turned on from the side menu where I'm seeing the issue. Infowall view, where the plot is outside the layout, displays the tagline in blue. In Shift view, where the plot var is inside the layout, the tagline is displayed in the main text color.
Will test latest master tonight. Thanks!
Works in master. Will find the commit that fixed it and backport as well.
Hm, works in todays Isengard for me Will wait for your feedback.