Bug FLAC audio encoder not working
#16
Length matters [FACE WITH STUCK-OUT TONGUE AND WINKING EYE]
AppleTV4/iPhone/iPod/iPad: HowTo find debug logs and everything else which the devs like so much: click here
HowTo setup NFS for Kodi: NFS (wiki)
HowTo configure avahi (zeroconf): Avahi_Zeroconf (wiki)
READ THE IOS FAQ!: iOS FAQ (wiki)
Reply
#17
ah yes, M$ has to compensate...
Reply
#18
Well i had a look into beta2 and all encoders are there @ned:

https://dl.dropboxusercontent.com/u/3037...coders.png

Also setting the action to "rip" when putting an audio cd in immediatly starts ripping. I have the problem that the CD doesn't show up at all in music->files - (internal cd drive on hackbook here). Well i guess everything might be fine really. Whats with our dozens of macbook using developers now? Can somebody give it a shot with a genuine mac?

Edit: once i ejected and put the cd back in when kodi was already running it showed up in music->files - no rip in context menu though - but playing the aiff files worked for me (might be really related to usb cd drive @ned). Will investigate the missing context rip entry ...
AppleTV4/iPhone/iPod/iPad: HowTo find debug logs and everything else which the devs like so much: click here
HowTo setup NFS for Kodi: NFS (wiki)
HowTo configure avahi (zeroconf): Avahi_Zeroconf (wiki)
READ THE IOS FAQ!: iOS FAQ (wiki)
Reply
#19
K fixed the cd/dvd drive detection on osx:

https://github.com/xbmc/xbmc/pull/5738
AppleTV4/iPhone/iPod/iPad: HowTo find debug logs and everything else which the devs like so much: click here
HowTo setup NFS for Kodi: NFS (wiki)
HowTo configure avahi (zeroconf): Avahi_Zeroconf (wiki)
READ THE IOS FAQ!: iOS FAQ (wiki)
Reply
#20
(2014-11-16, 20:31)Memphiz Wrote: K fixed the cd/dvd drive detection on osx:

https://github.com/xbmc/xbmc/pull/5738

Thanks, I can confirm it works.

Seems the audio encoder add-ons aren't included in nightly builds, but they are in the beta snapshots.
Reply
#21
found that one too...
AppleTV4/iPhone/iPod/iPad: HowTo find debug logs and everything else which the devs like so much: click here
HowTo setup NFS for Kodi: NFS (wiki)
HowTo configure avahi (zeroconf): Avahi_Zeroconf (wiki)
READ THE IOS FAQ!: iOS FAQ (wiki)
Reply
#22
(2014-11-16, 14:24)da-anda Wrote: I'm just ripping an Audio-CD as FLAC with default compression and it's playing just fine. Using Windows nightly 2cd9438.

edit: ok, half of the files is broken it seems
So it works for you sometimes and sometimes not? Could you backup the audioencoder.flac.dll file from the installation and use the one from https://www.dropbox.com/s/exxb620xnmsiw9...c.dll?dl=0 instead and try again? This is the same audioencoder but with a small change that fixes the issue for me. But I've tried 4 audio CDs and couldn't get any working encoded files.

(2014-11-16, 20:31)Memphiz Wrote: K fixed the cd/dvd drive detection on osx:

https://github.com/xbmc/xbmc/pull/5738
Great that this issue uncovered and fixed more issues Wink Thanks for looking into it.
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#23
@Montellese - sure, will test in a sec

edit: yes, that DLL fixed it - all ripped FLAC files are working now
Reply
#24
Ohh i completely missed the point here - i was supposed to test the flac encoder really was i? Wink
AppleTV4/iPhone/iPod/iPad: HowTo find debug logs and everything else which the devs like so much: click here
HowTo setup NFS for Kodi: NFS (wiki)
HowTo configure avahi (zeroconf): Avahi_Zeroconf (wiki)
READ THE IOS FAQ!: iOS FAQ (wiki)
Reply
#25
You're not supposed to but would be nice if someone did on OSX and Linux Wink
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#26
not sure you noticed my edit above Montellese - patched DLL fixed all FLAC rips for me (currently listening to the album for any glitches)
Reply
#27
@da-anda: Thanks for taking the time to test this. I'll wait for feedback from one of the other platforms to see if the current behaviour is the same. I already discussed the issue quickly with Jonathan (who made the problematic change) and we agree that the current audioencoder interface is either being misused (e.g. we're setting the number of total samples as "track length") or needs to be changed to be based on samples.
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#28
I did a couple of FLAC on OS X and they seem fine. I'll do a couple of different CDs and see if anything breaks.
Reply
#29
@wsnipex / @Memphiz: I started an OSX build on jenkins for a branch I created with an updated version of audioencoder.flac to make sure that my change doesn't break FLAC encoding on OSX (as it seems to work there with current master but not on win32). All I did was change the URL and git commit hash in project/cmake/addons/addons/audioencoder.flac/audioencoder.flac.txt. I checked the build logs of http://jenkins.kodi.tv/view/OSX/job/OSX-32/2419/ and http://jenkins.kodi.tv/view/OSX/job/OSX-64/2544/ but couldn't find any reference to the audioencoder addons being rebuilt. Is it possible that the audioencoder addons are not rebuilt because we cache depends builds for linux and osx? If that's the case this needs to be addressed somehow because otherwise we will end up with builds containing old binary addons everytime we bump them.

EDIT: @Ned: Thanks for taking the time to test this. Very odd that it works fine on OSX but not on win32. I'll try to get you a build with the updated version of the FLAC encoder which works fine on win32.
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#30
yes, thats possible. We only rebuild depends if something has changed. For a test, touch a Makefile in there Smile
Reply

Logout Mark Read Team Forum Stats Members Help
FLAC audio encoder not working0