Login at Kodi Home

wyrm · 2019-02-18, 03:28

(2019-02-18, 02:16)kostaman Wrote: @wyrm

Stumbled on a serious Bug.

Adding any addon to Kodi Favourites and Enabling Favourites Icon to home Page.

Open favourites / Select an addon (Any Addon)

Kodi Crashes. Tested on Android Leia and CoreELEC Leia

@kostaman,

Sorry sport, just tried it on my dev box, worked fine.

Couple of things to remember. First, while not impossible a skin should not cause a Kodi crash (PVR for a little while there would crash Kodi if skin writer made the wrong change to skin files), skin engine will most times just ignore incorrect skin code. So usually if you see a kodi crash, you should try the same action in the Estuary skin if possible and see if crash occurs there as well. If crashes in Estuary as well, it's a Kodi bug, otherwise probably a skin bug. And second, very hard to track down problems leading to crashes without a debug log and crash log. Have tried really hard to make as easy as possible for users to be able to post logs from within the skin (skin settings/support menu) you will need to turn on debug logging in Kodi's System menu. Don't turn on component logging as that can make for a very large debug file. Also if Kodi crashes, it will be the old log file, not the current one you will need to post link to. If you can't use the built in script for log uploads, please don't post file to a non pastebin type location as that involves me downloading the file locally instead of reading it online. This is usually a massive PITA.

At this stage I am leaning towards a issue with CoreElec, but post your old debug log as detailed above and I will see if I can't spot something.

Wyrm

kostaman · 2019-02-19, 02:48

(2019-02-18, 03:28)wyrm Wrote: At this stage I am leaning towards a issue with CoreElec, but post your old debug log as detailed above and I will see if I can't spot something.

Leave it with me.
I need a moment of time to do debug on all OS Platforms because the issue happens with LibreELEC Leia as well on my Rock64.
So i've got the issue on all OS Platforms.

I did SMB into CE box when it happened 2 days ago and took logs.
So until i get time to do the other OS's here are the CE logs.

Kodi Crash Log

https://pastebin.com/nzqNYGHA

Kodi Log

https://pastebin.com/7y5s7Dar

Estuary Skin has no issues opening favourites on any OS.

wyrm · 2019-02-19, 03:48

(2019-02-19, 02:48)kostaman Wrote:
(2019-02-18, 03:28)wyrm Wrote: At this stage I am leaning towards a issue with CoreElec, but post your old debug log as detailed above and I will see if I can't spot something.

Leave it with me.
I need a moment of time to do debug on all OS Platforms because the issue happens with LibreELEC Leia as well on my Rock64.
So i've got the issue on all OS Platforms.

I did SMB into CE box when it happened 2 days ago and took logs.
So until i get time to do the other OS's here are the CE logs.

Kodi Crash Log

https://pastebin.com/nzqNYGHA

Kodi Log

https://pastebin.com/7y5s7Dar

Estuary Skin has no issues opening favourites on any OS.

@kostaman,

Sorry sport, only error I can see in that log relates to CoreElec update script crashing. Would recommend you update by hand and see if you are still seeing issue. Not saying there is not a problem with favourites in my skin, just no evidence in current log file. Please keep posting logs so that we can pin down exactly what's going on.

Wyrm

kostaman · 2019-02-19, 03:56

@wyrm

https://paste.kodi.tv/otiquzates

Nvidia Shield log

wyrm · 2019-02-19, 04:12

(2019-02-19, 03:56)kostaman Wrote: @wyrm

https://paste.kodi.tv/otiquzates

Nvidia Shield log

Sorry, Nada in that one. Did you mean to post old log as that one was of currently running session. Last entry was for log upload script.

So to just be clear, are your crashes occurring from the Favourites screen or is the crash happening from a customised home menu button? If from home menu, have you also tried from one of the other two home menu types?

Wyrm

kostaman · (This post was last modified: 2019-02-19, 04:30 by kostaman.)

(2019-02-19, 04:12)wyrm Wrote: So to just be clear, are your crashes occurring from the Favourites screen or is the crash happening from a customised home menu button? If from home menu, have you also tried from one of the other two home menu types?

Favourites Screen Only.
Customised home menu buttons are fine.
Sorry they don't show in video.
I did a CLEAN FRESH INSTALL to avoid conflicts.

Nvidia Shield Android Leia 18.1 VIDEO.
I open favourites / Click on Ted Talks.
Thrown out of Kodi.
https://youtu.be/2uVG335eTKo

kostaman · (This post was last modified: 2019-02-19, 04:55 by kostaman.)

(2019-02-19, 04:12)wyrm Wrote: Sorry, Nada in that one. Did you mean to post old log as that one was of currently running session. Last entry was for log upload script.

Mate this is really weird. It's like Kodi is quitting upon me pressing a favourites addon.
Maybe it's not crashing kodi.
I enabled debug logging.
Quit Kodi.
Then opened Kodi.
Navigated to Ted in Favourites.
Clicked on it to open it.
Kodi seemed to Quit as in my vid.
I opened kodi and then navigated to upload log.
Bloody Android does my head in. Hope that's the right way ??
So no old log means no crash recorded right ??

wyrm · 2019-02-19, 05:17

(2019-02-19, 04:49)kostaman Wrote:
(2019-02-19, 04:12)wyrm Wrote: Sorry, Nada in that one. Did you mean to post old log as that one was of currently running session. Last entry was for log upload script.

Mate this is really weird. It's like Kodi is quitting upon me pressing a favourites addon.
Maybe it's not crashing kodi.
I enabled debug logging.
Quit Kodi.
Then opened Kodi.
Navigated to Ted in Favourites.
Clicked on it to open it.
Kodi seemed to Quit as in my vid.
I opened kodi and then navigated to upload log.
Bloody Android does my head in. Hope that's the right way ??
So no old log means no crash recorded right ??

@kostaman,

Should be at least a kodi.log and kodi.old.log in the directory that contains addons and userdata directories. May also include kodi_crashlog and kodi_stacktrace files. Following your procedure above, the file you need to send is the kodi.old.log file as on restart of Kodi the kodi.log file is renamed kodi.old.log and a new kodi.log file is created.

Still can't understand why skin code would crash Kodi, as normally faulty skin code is just ignored. Just need to catch in the log file why Add-ons appear to be crashing and should have a solution. If we get really stuck, you could try turning on component logging in Kodi's System settings menu for the addon you are trying to run (Ted talks in videos case), but that does generate a lot of log entries so log file will get bigger.

Wyrm

kostaman · 2019-02-19, 05:49

Repeated steps and manually retrieved logs with a file explorer.
Nvidia Shield.

Kodi Log

https://pastebin.com/RK5k9SwU

Old Kodi Log

https://pastebin.com/5yCRHYAj

wyrm · 2019-02-19, 06:36

(2019-02-19, 05:49)kostaman Wrote: Repeated steps and manually retrieved logs with a file explorer.
Nvidia Shield.

Kodi Log

https://pastebin.com/RK5k9SwU

Old Kodi Log

https://pastebin.com/5yCRHYAj

@kostaman,

Well is clear now that favourites screen is acting correctly. Right at end of both logs is initialise favourites screen, select button was pressed, de-initialise favourites screen. that's all she wrote.

I have also checked over the favourites dialog code. NOTHING to suggest code is faulty or even that there is an errant close command that is shutting it down. Code can't possibly get any less complex. May I suggest that you find the favourties.xml file in your userdata directory and post the contents here (will be small unless you have a truckload of favourites) so that we can see what exactly is being called.

The only other thing that might be causing an issue (and this is a very long shot) is maybe there is a errant command in your keymap file. Other than that, sorry sport, just went above my pay grade.

So, suggestions would be, post favourites.xml file, check your keymaps file or try another favourite and see if that is also failing.

Wyrm

kostaman · 2019-02-19, 07:06

(2019-02-19, 06:36)wyrm Wrote:

So, suggestions would be, post favourites.xml file, check your keymaps file or try another favourite and see if that is also failing.

Only 2 Favourites. Tried both. Same issue.
Remember i did a fresh install. Nothing but 2 addons installed.
My Keymaps folder is Empty. Nothing to see.

I've tried with my TV remote to navigate and enter as well.
Keyboard i use same issue. I tried using mouse cursor as well. Same result.

I'm defeated for the Time Being.

Wish others were here to test.

Code:
<favourites>

    <favourite name="TED Talks" thumb="/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.ted.talks/icon.png">ActivateWindow(10025,&quot;plugin://plugin.video.ted.talks/&quot;,return)</favourite>

    <favourite name="YouTube" thumb="/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.youtube/icon.png">ActivateWindow(10025,&quot;plugin://plugin.video.youtube/&quot;,return)</favourite>

</favourites>

wyrm · 2019-02-19, 08:56

(2019-02-19, 07:06)kostaman Wrote:
(2019-02-19, 06:36)wyrm Wrote:

So, suggestions would be, post favourites.xml file, check your keymaps file or try another favourite and see if that is also failing.
Only 2 Favourites. Tried both. Same issue.
Remember i did a fresh install. Nothing but 2 addons installed.
My Keymaps folder is Empty. Nothing to see.

I've tried with my TV remote to navigate and enter as well.
Keyboard i use same issue. I tried using mouse cursor as well. Same result.

I'm defeated for the Time Being.

Wish others were here to test.
Code:
<favourites> <favourite name="TED Talks" thumb="/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.ted.talks/icon.png">ActivateWindow(10025,"plugin://plugin.video.ted.talks/",return)</favourite> <favourite name="YouTube" thumb="/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.youtube/icon.png">ActivateWindow(10025,"plugin://plugin.video.youtube/",return)</favourite> </favourites>

@kostaman,

Damn it, now its happening here. Think favourites is a red herring, have not tried it yet but have done everything short of replacing my favourite dialog code with the Estuary code. There is NO desernable difference between my code and Estuary code. Guess will have to try and track down from here. Stupid thing is that this code has not changed in two years (I just checked), so has either been broken for at least two years, or you gave my system the flu.

Will try to track down before they lock me up.
Wyrm

wyrm · 2019-02-19, 12:27

@kostaman,

Ronie found a solution to Crash issue for me. Have pushed fix upto my github, or you can wait a little while and hopefully 1.6.0 of the skin will be available in main Kodi repo.

Wyrm

kostaman · 2019-02-19, 13:39

(2019-02-19, 12:27)wyrm Wrote: Ronie found a solution to Crash issue for me. Have pushed fix upto my github, or you can wait a little while and hopefully 1.6.0 of the skin will be available in main Kodi repo.

Just updated this version of Skin on my LE Rock64.
Glad to say it's FIXED Shocked

Now release the bloody thing before i find something else. Laugh

wyrm · 2019-02-19, 14:02

Funny enough, that is exactly what I told Ronnie Laugh

Wyrm