Develop PVR addons with new cmake build system

  Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
dhead Offline
Donor
Posts: 696
Joined: May 2010
Reputation: 3
Post: #16
@ironic_monkey

Thanks, I changed to kodi/libXBMC_codec.h and both pvr.hts and pvr.vdr.vnsi builds perfect. Edit: without any manually set include paths.

Your pvr.hts repo is missing xbmc_codec_descriptor.hpp (I checked, Kodi 15.0a1 doesn't install it with the other headers nor kodi-platform).
(This post was last modified: 2015-03-03 11:01 by dhead.)
find quote
ironic_monkey Offline
Posting Freak
Posts: 1,423
Joined: Nov 2013
Reputation: 66
Post: #17
yes, there has been back and forth. in my tree it's part of the addon bindings, but upstream prefers to dupe. sorry, forgot about that little detail Smile
(This post was last modified: 2015-03-03 11:13 by ironic_monkey.)
find quote
dhead Offline
Donor
Posts: 696
Joined: May 2010
Reputation: 3
Post: #18
p.s.

Might be a minor but I noticed (while packaging) that there are no licenses at the root of each addon's repo.
find quote
ironic_monkey Offline
Posting Freak
Posts: 1,423
Joined: Nov 2013
Reputation: 66
Post: #19
not a minor at all, but that's up to the authors to add.
find quote
h.udo Offline
Is a huge ABBA fan
Posts: 1,166
Joined: Feb 2009
Reputation: 18
Location: 25:17
Post: #20
(2015-03-03 10:41)ironic_monkey Wrote:  1) don't set any include paths (i get that it's a test)
2) pvr.hts master is broken - it shall include kodi/libXBMC_codec.h not libXBMC_codec.h - naughty hudo Wink in the mean time you can build mine; https://github.com/notspiff/pvr.hts

Aha!
No, naughty Sascha! Rofl

https://github.com/Montellese/pvr.hts/bl...or.hpp#L23 and https://github.com/Montellese/pvr.hts/bl...er.cpp#L35

I'm sure I screwed something during migration but source files were (mostly) a drag and drop task. I wonder how it compiled during jenkins tests...

btw, your repo doesn't have xbmc_codec_descriptor.hpp. Should that file be dropped from hts repo?

Difference:
https://github.com/kodi-pvr/pvr.hts/blob...er.cpp#L35
https://github.com/notspiff/pvr.hts/blob...er.cpp#L35

@Montellese?
find quote
Montellese Offline
Team Kodi Developer
Posts: 4,836
Joined: Jan 2009
Reputation: 72
Location: Switzerland
Post: #21
Someone (don't remember who) said that xbmc_codec_descriptor.hpp shouldn't be part of Kodi but should live in the PVR addons that use it (IIRC there are two PVR addons that use it) so I put it in there. No idea how that ever compiled with that include path Cool

Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
find quote
ironic_monkey Offline
Posting Freak
Posts: 1,423
Joined: Nov 2013
Reputation: 66
Post: #22
opdenkamp wanted to dupe.

just so everybody got the history right: i created all the addons. they were then refined while upstream added multiplatform versions of my concepts for building things. thus, mine lack some of those refinements.
(This post was last modified: 2015-03-03 16:27 by ironic_monkey.)
find quote
wsnipex Offline
Team-Kodi
Posts: 6,386
Joined: Jun 2011
Reputation: 165
Post: #23
@FernetMenta. you might want to update the OP. Symlinking is not needed anymore, you can point to a local addon repo in two ways now:
* -DADDON_SRC_PREFIX=/path/to/addon_parent_dir
* using a file:// URL pointing to a local directory in the addon definition file.
find quote
h.udo Offline
Is a huge ABBA fan
Posts: 1,166
Joined: Feb 2009
Reputation: 18
Location: 25:17
Post: #24
@wsnipex

Works great, thanks!
find quote
negge Offline
yo guysv7may bd latr tomorroe
Posts: 3,715
Joined: Dec 2010
Reputation: 53
Location: Finland
Post: #25
The steps for Windows have a small bug, it should be

Quote:-DADDONS_TO_BUILD="pvr.demo"

instead of

Quote:-DADDONS_TO_BUILD=pvr.demo

Note the added citation marks. Without these the step fails immediately with something like "cannot find bla\bla\addons\.demo".

Thanks for the guide, I'm working my way through it right now, will post back if I find any other issues.
find quote
FernetMenta Offline
Team-Kodi Developer
Posts: 6,190
Joined: Jul 2010
Reputation: 140
Location: Munich
Post: #26
thanks! I will update the first post.
find quote
h.udo Offline
Is a huge ABBA fan
Posts: 1,166
Joined: Feb 2009
Reputation: 18
Location: 25:17
Post: #27
Steps for linux development are fairly easy:

Code:
$ cd /home/hudo/dev/ws_kodi/pvr.demo/
$ mkdir build/
$ cd build/
$ cmake -DADDONS_TO_BUILD=pvr.demo -DCMAKE_BUILD_TYPE=Debug -DADDON_SRC_PREFIX=/home/hudo/dev/ws_kodi -DCMAKE_INSTALL_PREFIX=/home/hudo/dev/tmp/share/kodi/addons -DPACKAGE_ZIP=1 /home/hudo/dev/ws_kodi/kodi/project/cmake/addons
$ cd ..
$ make -j4 -C build/

Didn't test windows.
(This post was last modified: 2015-03-08 14:06 by h.udo.)
find quote
negge Offline
yo guysv7may bd latr tomorroe
Posts: 3,715
Joined: Dec 2010
Reputation: 53
Location: Finland
Post: #28
@Montellese your .bat script seems to work fine, mind PRing it?
find quote
negge Offline
yo guysv7may bd latr tomorroe
Posts: 3,715
Joined: Dec 2010
Reputation: 53
Location: Finland
Post: #29
Could someone explain how I can get header files to show up in the generated Visual Studio projects? At the moment only the .cpp files are present.
find quote
ironic_monkey Offline
Posting Freak
Posts: 1,423
Joined: Nov 2013
Reputation: 66
Post: #30
just add them to the SOURCES variable. see e.g. pvr.mediaportal.tvserver, https://github.com/kodi-pvr/pvr.mediapor...ver/pull/2
(This post was last modified: 2015-03-09 14:56 by ironic_monkey.)
find quote
Post Reply