[Milhouse]

I believe this also happens on the Pi1. Thanks for taking a look.

[Milhouse]

@margro: Initial indications suggest that reverting PR6306 stops the crashing (which is BufferReader related), presumably the PVR code needs tweaking to match the revised Kodi behaviour?

[margro]

Ouch... now I understand the crash log...

Both the MediaPortal and ArgusTV addons have a FileReader class too for reading the timeshift buffer.
See:
https://github.com/margro/xbmc-pvr-addon...Reader.cpp

So, what probably happens here is that the addon creates an object of the internal Kodi FileReader class instead of the one in the addon...
Wow... this will definitely crash on all non-Windows targets.

This basically means that we should either fix the addon by renaming the FileReader class (or by moving it into a different namespace) or rename the FileReader class at the Kodi side.

Conclusion from this crash is that it would be better to add a unique namepace around most of the PVR addon code and for all C++ addons.

Will see if I can submit a fix later this week (not before Friday).

[Milhouse]

Many thanks.

[mylle]

Hi Margro,

Did you get a chance to look at providing a fix yet?

Regards
Jacob

[margro]

I've submitted a change that probably fixes the crash but I can't test it right now. The fix is already included in the latest Milhouse RPi build but none of the addons will load right now on my Pi.

Code:

13:36:30 197.908798 T:1664083008   ERROR: Unable to load /usr/lib/kodi/addons/pvr.mediaportal.tvserver/pvr.mediaportal.tvserver.so, reason: libkodiplatform.so.15.0: cannot open shared object file: No such file or directory
13:36:30 197.914368 T:1664083008 WARNING: UpdateAndInitialiseClients - failed to create add-on MediaPortal PVR Client, status = 6
13:36:30 197.914612 T:1664083008 WARNING: UpdateAndInitialiseClients - failed to load the dll for add-on MediaPortal PVR Client, disabling it
13:36:30 197.918213 T:1949197376  NOTICE: Thread AddonStatus pvr.mediaportal.tvserver start, auto delete: true

One of the shared libraries for all PVR addons cannot be found by Kodi.

[Milhouse]

Yes, there's a problem with libkodiplatform.so - it's not being built by the upstream patch I'm using. Which fix is preventing the crash?

Edit: Hopefully fixed in tonight's build - the addons will now build statically linked against libkodiplatform.so.

[margro]

This change (6a584d6a) moves the addon version of the FileReader class inside its own namespace. From what I could see in the crash log, the PVR addon managed to make an instance of the Kodi-internal FileReader class instead of the one included in the addon.
I've tested it under x64 Linux and it worked there, so I'm hoping that it will also work on the RPi.

As soon as I can test it on my Pi and it works, I will also send a PR for the pvr.argustv addon since it crashes due to the same conflicting FileReader class.

[Milhouse]

Right, yes, that fix should be in my build (since #0310) as it was merged to pvr.mediaportal.tvserver a few days ago, hopefully that's stopped pvr.mediaportal.tvserver from crashing.

I'll hopefully be able to upload a test build with statically linked libkodiplatform.so in a couple of hours, then maybe @mylle can test.

[mylle]

OK. Let me know when the test build is up and i will test

Thanks guys!

[Milhouse]

Test builds are uploaded, links are in the test build thread.

[mylle]

Testes it briefly. Pvr addon says loading channel but then nothing. The live TV option menu point never loads wont be able to provide logs until tomorrow

[margro]

Testbuild #0314x fixes the PVR addons. Furthermore, I've specifically tested the MediaPortal PVR addon and it does not crash anymore on opening a Live TV stream, so my crash fix seems to work fine on my RPi 1.

[Milhouse]

Excellent! Hopefully it won't be long before ArgusTV is fixed, once you have a PR I can add that to a build if it needs testing, or just wait for it to be merged.

[margro]

Just submitted the corresponding pvr.arrgustv fix with https://github.com/kodi-pvr/pvr.argustv/pull/3