Store skin theme and colours as skin variable

  Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Martijn Offline
Team Kodi
Posts: 16,910
Joined: Jul 2011
Reputation: 310
Location: Dawn of time
Post: #1
Currently theme and colour are stored as global settings and are reset when switching skins.
Ideally these should be moved to skin specific stored variables. This way switching skins you retain the theme/colour you choose for a specific skin.

Additionally these could be stored as skin specific settings as well:
  • sounds
  • startup window
  • skin zoom

Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
find quote
Koying Offline
Team-Kodi Developer
Posts: 5,693
Joined: Sep 2008
Reputation: 178
Location: Brussels, Belgium
Post: #2
Maybe already answered, but is there a reason (beside historical) why the skin-specific data aren't stored in addon_data, like any plain addon?
If you experiment a bit with skins, guisettings.xml is spammed with skin settings forever, which, imo, doesn't belong there.

Furthermore, I don't know if it's related or my fault, but I more than often loose view settings when switching skins...
find quote
Martijn Offline
Team Kodi
Posts: 16,910
Joined: Jul 2011
Reputation: 310
Location: Dawn of time
Post: #3
(2015-06-23 11:15)Koying Wrote:  Maybe already answered, but is there a reason (beside historical) why the skin-specific data aren't stored in addon_data, like any plain addon?
If you experiment a bit with skins, guisettings.xml is spammed with skin settings forever, which, imo, doesn't belong there.

Furthermore, I don't know if it's related or my fault, but I more than often loose view settings when switching skins...

no one has ported it yet to be stored like other add-ons. so simply lack of time Smile
There's some other thread where this was brought up as well. Ideally skin settings would indeed be completely stored in addon_data yes.
Same story as splitting up installed add-ons per profile.

viewsettings are stored in separate database so it could be that it stores the view ID specific to that skin. Switching to another skin might not have that view and it falls back to the default one. (don't shoot me if i'm wrong on this)

Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
find quote
Montellese Offline
Team Kodi Developer
Posts: 4,834
Joined: Jan 2009
Reputation: 72
Location: Switzerland
Post: #4
View settings are saved per skin so you shouldn't loose those. But they are also per path.

Concerning skin settings there are (at least) two ways to move forward:
  1. Simply store the settings (in the same format) that we currently store in guisettings.xml into ther skin's addon data directory in a settings.xml file
  2. Force skinners to write a proper settings.xml like every other addon. That will allow us/them to also make use of the addon settings dialog but it will also limit their possibilities a lot.
The former shouldn't be too difficult to achieve but it will still leave us with two different setting systems used for skins and other addons.
The latter would completely unify the two settings systems but it would most likely be completely backwards incompatible for skins and would be a lot of work for skinners.

Also moving the whole addon settings system to the same system we now use for core settings is still on my TODO list and we're probably quite a bit closer now than we were with Helix (with the group titles/labels) but I think there are still features in the addon settings system that will be difficult / hacky to implement in the core settings system.

Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
find quote
ronie Offline
Team-Kodi Member
Posts: 13,165
Joined: Jan 2009
Reputation: 391
Post: #5
(2015-06-23 14:16)Montellese Wrote:  [*]Force skinners to write a proper settings.xml like every other addon. That will allow us/them to also make use of the addon settings dialog but it will also limit their possibilities a lot.

-1 for the reason you mentioned.

skin settings are very flexible and allow you to do just about anything.
addon settings on the other hand are limited and clumsy (especially the visible conditions).

Do not PM or e-mail Team-Kodi members directly asking for support.
Always read the Forum rules, Kodi online-manual, FAQ and Search the forum before posting.
For troubleshooting and bug reporting please make sure you read this first.
find quote
Montellese Offline
Team Kodi Developer
Posts: 4,834
Joined: Jan 2009
Reputation: 72
Location: Switzerland
Post: #6
(2015-06-23 14:21)ronie Wrote:  -1 for the reason you mentioned.

skin settings are very flexible and allow you to do just about anything.
addon settings on the other hand are limited and clumsy (especially the visible conditions).

Yeah that's what I figured. But storing them in a settings.xml file in the skin's addon data instead of in guisettings.xml shouldn't be an issue right?
The only downside I can think of is that the settings are lost when manually uninstalling and then re-installing a skin (but that might already be the case right now, I don't really know).

Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
find quote
Koying Offline
Team-Kodi Developer
Posts: 5,693
Joined: Sep 2008
Reputation: 178
Location: Brussels, Belgium
Post: #7
(2015-06-23 14:25)Montellese Wrote:  The only downside I can think of is that the settings are lost when manually uninstalling and then re-installing a skin (but that might already be the case right now, I don't really know).

Not a (pure) downside, imo. At least, there would be a way to get rid of them.
Afaik, currently, just giving a skin a try makes those settings stick in guisettings forever.
find quote
ronie Offline
Team-Kodi Member
Posts: 13,165
Joined: Jan 2009
Reputation: 391
Post: #8
(2015-06-23 14:25)Montellese Wrote:  But storing them in a settings.xml file in the skin's addon data instead of in guisettings.xml shouldn't be an issue right?
yup that would be fine.
(2015-06-23 14:25)Montellese Wrote:  The only downside I can think of is that the settings are lost when manually uninstalling and then re-installing a skin
afaik we don't delete addon settings. ever.

Do not PM or e-mail Team-Kodi members directly asking for support.
Always read the Forum rules, Kodi online-manual, FAQ and Search the forum before posting.
For troubleshooting and bug reporting please make sure you read this first.
find quote
Martijn Offline
Team Kodi
Posts: 16,910
Joined: Jul 2011
Reputation: 310
Location: Dawn of time
Post: #9
(2015-06-23 17:09)ronie Wrote:  
(2015-06-23 14:25)Montellese Wrote:  The only downside I can think of is that the settings are lost when manually uninstalling and then re-installing a skin
afaik we don't delete addon settings. ever.
Indeed. Addons settings are kept forever, till user wipes his userdata of course. Uninstalling addons has no effect on this

Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
(This post was last modified: 2015-06-23 17:16 by Martijn.)
find quote