Thread Closed
OpenELEC Testbuilds for RaspberryPi (Kodi 16.0)
(2015-09-25, 15:50)SpuDy Wrote: at the last two builds in a video settings is available only

Image

This problem actually starts with build #0918, which reintroduced RapidJSON in place of YASL. However it's not a RapidJSON problem as build #0928z (which reverts to the original YASL) also has the same video settings dialog problem.

This isn't a problem in my x86 OE builds (FernetMenta/master in place of newclock5), nor latest Kodi master on Ubuntu (ie. with DVDPlayer not VideoPlayer).

Disabling Fritsch's Intel patches from https://github.com/fritsch/OpenELEC.tv/c...jarvis-egl doesn't fix the problem, so they're not the cause.

So I don't know what patch is causing this problem.

The dialog contents comes from xbmc/video/dialogs/GUIDialogVideoSettings.cpp

This is the latest version from Kodi master: http://sprunge.us/Hcbb
This is the latest version in my RPi builds (after newclock5 has been applied): http://sprunge.us/RZGg
This is the diff between the two: http://sprunge.us/ifQC

It seems that every item in CGUIDialogVideoSettings::InitializeSettings() that checks if it should appear (or after being added, should be removed because it's not a supported feature) is missing, which suggests the call to g_application.m_pPlayer->Supports() is no longer returning "true" for supported features, in which case perhaps it's an issue in g_application.m_pPlayer->Supports()?

Commenting out the following lines (patch) from CGUIDialogVideoSettings::InitializeSettings()
Code:
for (StaticIntegerSettingOptions::iterator it = entries.begin(); it != entries.end(); )
  {
    if (g_application.m_pPlayer->Supports((EINTERLACEMETHOD)it->second))
      ++it;
    else
      it = entries.erase(it);
  }
so that the added items are *not* removed results in the VS_INTERLACEMETHOD_* items appearing in the dialog, which pretty much confirms that g_application.m_pPlayer->Supports() is returning "false" for everything, even supported features.

Unfortunately I have no idea which commit is causing this new Supports() behaviour.
Texture Cache Maintenance Utility: Preload your texture cache for optimal UI performance. Remotely manage media libraries. Purge unused artwork to free up space. Find missing media. Configurable QA check to highlight metadata issues. Aid in diagnosis of library and cache related problems.
  Thread Closed
 
Thread Rating:
  • 10 Vote(s) - 5 Average


Messages In This Thread
RE: OpenELEC Testbuilds for RaspberryPi (Kodi 16.0) - by Milhouse - 2015-10-02, 16:52
Bluetooth on #1003 - by cdvreede - 2015-10-13, 11:08
Re: RE: Bluetooth on #1003 - by Milhouse - 2015-10-13, 13:24


Logout Mark Read Team Forum Stats Members Help
OpenELEC Testbuilds for RaspberryPi (Kodi 16.0)510