Amber Skin for Kodi 15 Isengard

  Thread Rating:
  • 5 Vote(s) - 4.2 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Jester Offline
XBMC for iOS* forums Moderator
Posts: 1,076
Joined: Oct 2008
Reputation: 14
Lightbulb  Amber Skin for Kodi 15 Isengard
Post: #1
So,

Now that we have Isengard release, I will use this thread as a placeholder for all issues that need to be fixed for Isengard.

to be clear, NO feature requests, just fixes to make Amber work properly with Isengard.

Just explain the issue in a post (with screenshots is better) and I will look at them one by one and hopefully fix them Smile

Also, i'm going to work through this list to make sure all the changes are done (lots of work)
http://forum.kodi.tv/showthread.php?tid=211896

Thanks


P.S.
If you REALLY want to help, i'm open to pull requests and/or problem reports here:

https://github.com/jester-xbmc/skin.amber



EDIT:
Video done by Martijn after 15.1 release


https://www.youtube.com/watch?v=a4uzJHtSPic
(This post was last modified: 2015-08-18 17:24 by Jester.)
find quote
joethepartylion Offline
Fan
Posts: 390
Joined: Sep 2014
Reputation: 27
Location: Peterborough, UK
Post: #2
Hi Jester

I have updated the skin with the Isengard skinning changes plus fixed a few things (mainly PVR windows\SublimeKodi flagged errors) and it is working fine for me. Unfortunately I am away on business and can't upload until I get back home on Friday.

I'll submit a pull request once I get home for you to review.

Thanks

Kevin
find quote
joethepartylion Offline
Fan
Posts: 390
Joined: Sep 2014
Reputation: 27
Location: Peterborough, UK
Post: #3
Hi Jester

I have just sent you a pull request for my changes for Isengard support and fixes, I hope they look ok, let me know if you have any problems.

Thanks

Kevin
find quote
anekice Offline
Junior Member
Posts: 1
Joined: Jul 2015
Reputation: 0
Post: #4
Hello,

I have Windows 8.1 64-bit and Kodi 15 Isengard. I like Amber skin a lot and in Library mode I use Big List view. But in Big List view the background is just black. How can I enable artwork in backgroud for Bil List or at least to put some picture instead of pure black background?

Sorry if this was answered previously, but I searched the forum and couldn't find any answer.
find quote
Jester Offline
XBMC for iOS* forums Moderator
Posts: 1,076
Joined: Oct 2008
Reputation: 14
Post: #5
(2015-07-31 12:28)joethepartylion Wrote:  Hi Jester

I have just sent you a pull request for my changes for Isengard support and fixes, I hope they look ok, let me know if you have any problems.

Thanks

Kevin

Cheers Kevin,

I'm traveling myself for work, I will take a peek later tonight and push some updates myself and merge what looks ok.

Thanks
find quote
psyc0ld Offline
Junior Member
Posts: 14
Joined: Dec 2014
Reputation: 0
Post: #6
Hi there,
With the new addition of chapters, the bookmark menu when playing a video isn't display any picture nor visual selection of chapter.
Thanks for keeping Amber alive!
find quote
fab42 Offline
Junior Member
Posts: 10
Joined: May 2014
Reputation: 0
Post: #7
Hi,
just an issue with the new Adaptive seeking (aka Skip Steps) feature: when I press the seek back/forward button I see no immediate feedback about the skip period, we should see 10 seconds / 30 seconds / 1 minute etc.
I can only see that at the end when the player is skipping, test it with the default Confluence skin.
find quote
joethepartylion Offline
Fan
Posts: 390
Joined: Sep 2014
Reputation: 27
Location: Peterborough, UK
Post: #8
(2015-08-01 23:07)fab42 Wrote:  Hi,
just an issue with the new Adaptive seeking (aka Skip Steps) feature: when I press the seek back/forward button I see no immediate feedback about the skip period, we should see 10 seconds / 30 seconds / 1 minute etc.
I can only see that at the end when the player is skipping, test it with the default Confluence skin.

Thanks, this one is fixed in my pull request to Jester.

Thanks

Kevin
find quote
Jester Offline
XBMC for iOS* forums Moderator
Posts: 1,076
Joined: Oct 2008
Reputation: 14
Post: #9
I've merged your pull, thanks !

some other changes have been done, i'm currently testing, will push an isengard release soon
find quote
fab42 Offline
Junior Member
Posts: 10
Joined: May 2014
Reputation: 0
Post: #10
Ok thanks
I just checked out a copy from Github and started my own testing, I will report here any issue I should notice.
find quote
fab42 Offline
Junior Member
Posts: 10
Joined: May 2014
Reputation: 0
Post: #11
A visual nuisance I just discovered (actually using version 2.1.0 from Github):
Going to a Movie or Episode "Info" screen and then into the "Actors" section, when I highlight an actor's name his/her picture is properly showed but the name disappears because it's covered by a black/white image that I guess should be a transparent background but covers instead the actor's name.
find quote
Smultie Offline
Member
Posts: 58
Joined: Mar 2012
Reputation: 0
Post: #12
Could someone please take a look at https://github.com/pecinko/skin.amber/issues/88
find quote
joethepartylion Offline
Fan
Posts: 390
Joined: Sep 2014
Reputation: 27
Location: Peterborough, UK
Post: #13
(2015-08-03 07:42)Smultie Wrote:  Could someone please take a look at https://github.com/pecinko/skin.amber/issues/88

Hi

The problem with this one is that the icons can be different aspect ratios and at the moment the images are all stretched to fit the container. It can be changed so that the aspect ratio is not changed during the stretch but then the border will no longer fit the image perfectly as it isn't possible to dynamically detect what type of image is displayed and modify the border accordingly.

I guess this is why the Confluence skin uses a list and only shows one icon at a time so this issue isn't visible.

It comes down to what would people prefer:

1. Stretched icons, consistent border
2. Correctly proportioned icons, inconsistent border.
3. A different way of displaying it entirely, (if so, what?)

Thanks

Kevin
find quote
Smultie Offline
Member
Posts: 58
Joined: Mar 2012
Reputation: 0
Post: #14
(2015-08-03 11:41)joethepartylion Wrote:  
(2015-08-03 07:42)Smultie Wrote:  Could someone please take a look at https://github.com/pecinko/skin.amber/issues/88

Hi

The problem with this one is that the icons can be different aspect ratios and at the moment the images are all stretched to fit the container. It can be changed so that the aspect ratio is not changed during the stretch but then the border will no longer fit the image perfectly as it isn't possible to dynamically detect what type of image is displayed and modify the border accordingly.

I guess this is why the Confluence skin uses a list and only shows one icon at a time so this issue isn't visible.

It comes down to what would people prefer:

1. Stretched icons, consistent border
2. Correctly proportioned icons, inconsistent border.
3. A different way of displaying it entirely, (if so, what?)

Thanks

Kevin

Being consistent with the borders would solve my specific problem I think?!
find quote
fab42 Offline
Junior Member
Posts: 10
Joined: May 2014
Reputation: 0
Post: #15
(2015-08-03 11:41)joethepartylion Wrote:  
(2015-08-03 07:42)Smultie Wrote:  Could someone please take a look at https://github.com/pecinko/skin.amber/issues/88

Hi

The problem with this one is that the icons can be different aspect ratios and at the moment the images are all stretched to fit the container. It can be changed so that the aspect ratio is not changed during the stretch but then the border will no longer fit the image perfectly as it isn't possible to dynamically detect what type of image is displayed and modify the border accordingly.

I guess this is why the Confluence skin uses a list and only shows one icon at a time so this issue isn't visible.

It comes down to what would people prefer:

1. Stretched icons, consistent border
2. Correctly proportioned icons, inconsistent border.
3. A different way of displaying it entirely, (if so, what?)

Thanks

Kevin

I guess that removing the border is not a good thing because it would break the skin's visual consistency, so I think that option 2 is better than option 1 (actually in use).

Did someone check the actor's name issue I reported yesterday? I tried myself but I'm not skilled in Kodi skins.
(This post was last modified: 2015-08-04 11:41 by fab42.)
find quote
Post Reply