Posts: 8,283
Joined: Jul 2014
(2016-02-22, 16:59)Jayz2K Wrote: A sliderex would also be awesome, but icing on the cake
One great thing with skinsettings is the file is stored in extras folder, I really enjoy having those scripted ones out of the main skin folder but AFAIK, it's not possible to include a file from outside this main. Also, would be interresting having more than one script-skin_helper_service-Constants.xml file (to separate settings sets) but seems hard to implement even by numbering the files.
It's a quick though but what do you think ?
This is all do-able pretty easy but I'd like to suggest the following changes.
I will do some basic coding for you to test and from that we can work further up.
Posts: 8,283
Joined: Jul 2014
(2016-02-22, 18:58)tomer953 Wrote: 1. clearing the properties from the skinshortcuts dialog is not working. http://pastebin.com/K4yHm0RD
i'm clicking on the "none" button, the picker closed, and the property is stay. (I check with labels for easy debugging)
2. in strings case, the none button seems to work, but is setting "None" to the string, and in my skin I check for IsEmpty, and not comparing to None.
Code:
<setting id="list_bg_color" type="string">None</setting>
is it possible to reset the string? will save me a lot of coding.
10Q
1. Should now be fixed on Git, please test.
2. Clearing the skin will be a terrible wrong idea because it will collide with any defaults you set in your skin when it's empty. Better to check against None
Posts: 8,283
Joined: Jul 2014
(2016-02-22, 22:52)tomer953 Wrote: 2. mmm, actually my defaults values is come to play when the string IsEmpty, for example:
Code:
<variable name="main_color">
<value condition="!IsEmpty(Skin.String(main_color))">$INFO[Skin.String(main_color)]</value>
<value>FFE66A4F</value>
</variable>
now with the "None" option, I will need to add !StringCompare(...,None) to the first condition.. and do that in all my skin variable.. so In my case, it won't collide.
If you\other skinners, made it differently from my way - so I'll fix my code, but just wanted to show you that no problem in my code to reset the string..
You can drop the extra variable and call the skin string directly.
Just it's default somewhere in the onload of your home window for example:
<onload condition="IsEmpty(Skin.String(main_color))">Skin.SetString(main_color,FFE66A4F)</onload>
Get what I mean ?
Posts: 8,283
Joined: Jul 2014
(2016-02-22, 23:02)sualfred Wrote: Thanks for the fast fix. It's working again for the movies, but no results for TV Shows
Did you restart Kodi ?
Posts: 8,283
Joined: Jul 2014
(2016-02-23, 01:04)sualfred Wrote: Yep? ^^
Strange... working fine on my end
Posts: 8,283
Joined: Jul 2014
(2016-02-23, 09:15)tomer953 Wrote: I get it, and I used that way in my old mods, but in Phenomenal I wanted to give up all the massive "onloads"..
but ok, leave it for me, I will add the None check... one last question - it is always "None" in English or the translated string?
The value is None and the .label is the translated variant.
Take a look at Titan skin, IncludesDefaultSkinSettings.xml it's a clean implementation of how to set some defaults for your skin without continuous hammering with onload
Posts: 8,283
Joined: Jul 2014
(2016-02-23, 23:57)Gade Wrote: Hi Marcel.
I use
Code:
plugin://script.skin.helper.service/?action=nextepisodes&limit=20&reload=$INFO[Window(Home).Property(widgetreload)]
in the Rapier skin.
Everything works perfectly for me on several platforms and Kodi versions.
However, a user has reported a strange issue.
(2016-02-21, 20:08)jmarcon Wrote: I'm having a small issue with the "In Progress" tv shows widget. For some reason, it has started to show tv shows which I have not yet started to watch. This has started to do so a few days ago when I was still using Jarvis RC3. I just updated to stable release Jarvis but the issue is still present. I have tried to mark as watched then unwatched the tv shows in question but it didn't solve it.
You can see the thread here.
Any idea what's going on?
Cheers
Gade
The user is talking about the "In progress Tv Shows widget" that would be something else than the "next episodes" widget.
Sure he's referring to next episodes and not the kodi default In progress node ?