Release - skin helper service

  Thread Rating:
  • 15 Vote(s) - 4.47 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
DaveBlake Offline
Team-Kodi Member
Posts: 2,440
Joined: Jun 2015
Reputation: 68
Location: South West England
Post: #3781
(2017-09-16 00:59)Gracus Wrote:  Kodi devs have limited time and I do not think that music artworks could have a place in Kodi 18 roadmap (or, as for movies, just a few of them will be available through kodi core and we will still need SHS for the others)

That is why I thought simplier to make small correction to SHS than trying to add all of these in Kodi
You are of course right about limited time and help with deveolpment is welcome, the active dev team is very small compared to the millions of users Kodi has. But to my knowledge there is no "roadmap" it is just a matter of what gets done (implemented and approved) in time.

While I am not going to be able to replace SHS, and not sure I would even want to try, I am working on where Kodi looks for artist nfo and art. The current approach - trying to identify a unique folder in the music files - is flawed. It can only work for abum artists with very simple muisc folder layouts, collaborations (multiple album artists) or multiple music sources confuse it. In v18 there will be a nominated artists folder, and it would be sensible for addons that fetch art to use this folder too, not go off and create yet another structure with different naming etc.

I don't have time to trawl through Python and work out how these addons work, and I am not even a regular addon user, so I am unclear on what addons like SHS need to be able to make use of the features I am adding. All I can do is raise awareness of what I am working on, and hope that those on the addon side of things will come forward and work with me.

For example if there are issues with turning artist names into folders, then it would help me to know about it and to work together to come up with a collective solution that can be implemented in core and accessed by addons.

The v18 music db already holds Muisicbrainz release group id. It is this, not Muisicbrainz (album) release id, that is needed for online lookup of album art and info. Using this would speed up art retrieval by removing the need to requery Muiscbrainz (throttled to 1 call per sec), but I need to know what needs adding so that SHS and other addons have access to this.

(2017-09-16 07:50)Gade Wrote:  Sounds very interesting. Is there a PR for this?
Not quite but near, the work is in my repo. I am working on it as part of improving the music library export/import facility. The aim is to reduce the number of times users rescrape the same online information. If we continue to unnecessarily batter the servers of the free online music info services they will eventually either fail or limit Kodi's access. Better export/import will mean that users can save scraped data locally and restore it to any fresh installations with ease.

I know that core changes are slow compared to addon development, but I would like to work with the addon devs and users rather than in isolation.

Some design and testing discussion here https://forum.kodi.tv/showthread.php?tid...pid2644241 Perhaps a better place to discuss it than mixed in with other SHS requests?
find quote
Angelinas Offline
Posting Freak
Posts: 1,037
Joined: Sep 2013
Reputation: 96
Location: Србија...бре :)
Post: #3782
thetvdb.get_episode have data in simplecache....but, Window(Home).Property(SkinHelper.ListItem.####) not working for episode and seasons.
Info for this content are only from tvshow.

Window(Home).Property(SkinHelper.ListItem.GuestStars)
dont have info in thetvdb.get_episode string have info in simplecache.db
Code:
'gueststars': [u'Katie Cassidy', u'John Barrowman', u'Manu Bennett', u'Rick Gonzalez', u'Juliana Harkavy', u'Katrina Law', u'Madison McLaughlin', u'Lexa Doig', u'Anna Hopkins', u'Nick E. Tarabay', u'Dolph Lundgren']
Same for all data....for content.episode.(plot,seriesid,....)

XBoxMediaCenter (Kodi Leia) 18.0 , LibreElec RasPi3 Krypton Skin AeonMQ6
find quote
Gade Offline
Skilled Skinner
Posts: 1,971
Joined: Jan 2013
Reputation: 75
Location: Copenhagen, Denmark
Post: #3783
(2017-09-16 08:58)DaveBlake Wrote:  Not quite but near, the work is in my repo. I am working on it as part of improving the music library export/import facility. The aim is to reduce the number of times users rescrape the same online information. If we continue to unnecessarily batter the servers of the free online music info services they will eventually either fail or limit Kodi's access. Better export/import will mean that users can save scraped data locally and restore it to any fresh installations with ease.

I know that core changes are slow compared to addon development, but I would like to work with the addon devs and users rather than in isolation.

Some design and testing discussion here https://forum.kodi.tv/showthread.php?tid...pid2644241 Perhaps a better place to discuss it than mixed in with other SHS requests?

Sounds very well thought out.
Let's continue discussion in the other thread.
find quote
the_bo Offline
Fan
Posts: 480
Joined: Mar 2015
Reputation: 27
Post: #3784
Hi Guys

How do I set the interval to retrieve new rotten tomatoes ratings etc longer say every 3 months.

What file I need to edit.

Thanks
find quote
Angelinas Offline
Posting Freak
Posts: 1,037
Joined: Sep 2013
Reputation: 96
Location: Србија...бре :)
Post: #3785
Find in script.module.metadatautils what info you want change.(for rottentomatoes is OMDB.py)
OMDB info is set to expires after 2 or 14 days,just change in 90 Smile

Code:
@use_cache(14)
@use_cache(2)
@use_cache(2)

XBoxMediaCenter (Kodi Leia) 18.0 , LibreElec RasPi3 Krypton Skin AeonMQ6
(This post was last modified: 2017-09-17 23:31 by Angelinas.)
find quote
the_bo Offline
Fan
Posts: 480
Joined: Mar 2015
Reputation: 27
Post: #3786
(2017-09-17 23:26)Angelinas Wrote:  Find in script.module.metadatautils what info you want change.(for rottentomatoes is OMDB.py)
OMDB info is set to expires after 2 or 14 days,just change in 90 Smile

Code:
@use_cache(14)
@use_cache(2)
@use_cache(2)

Thanks Angelinas

What about the simplecache do i need to adjust that also, so it doesnt need to recache info?

Code:
def set(self, endpoint, data, checksum="", expiration=datetime.timedelta(days=30)):
find quote
heula Offline
Senior Member
Posts: 225
Joined: Sep 2015
Reputation: 0
Location: Spijkenisse, The Netherlands
Post: #3787
How do I get my own images working for my recordings in the PVR widget?

I have set several setting in the artwork options that are available in the context menu of the TV guide. I have set it to search in my custem folder for artwork but it in the widget I see other images or no images at all. I have set in the widget options the art should be square poster but the widget shows fanart format most of the time.
Also enabled search for PVR artwork in the skin helper widgets settings.

Any help here is appreciated.

Using Aeon Nox:Silvo 6.0.11 and Kodi Krypton 17.4 with all needed addons up to date.

This is how my recordings widget looks like most of the time.

[Image: wbGzQC5.jpg]

[Image: pSgGjyv.jpg]

[Image: lvCRVXx.jpg]

My custom folder

[Image: hyftHGd.jpg]

Thanks
find quote
Post Reply